Skip to contentSkip to conversation

reset: meson: add g12a SoC support

PATCH Superseded Jerome Brunet 2 participants 4 messages Jan 28, 2019 – Jan 29, 2019

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jerome Brunet

author reviewer
#0 lore raw

v2 cover reset: meson: add g12a SoC support

This patchset adds new dt-bindings for the reset lines of amlogic g12a SoC and the related compatible in the driver.

Changes since v1 [0]:
* Correct patch 2 commit message.

[0]: https://lkml.kernel.org/r/[email protected]

Jerome Brunet (2):
dt-bindings: reset: meson: add g12a bindings
reset: meson: add g12a compatible string

 .../bindings/reset/amlogic,meson-reset.txt    |   7 +-
 drivers/reset/reset-meson.c                   |   1 +
 .../reset/amlogic,meson-g12a-reset.h          | 134 ++++++++++++++++++
 3 files changed, 140 insertions(+), 2 deletions(-)
 create mode 100644 include/dt-bindings/reset/amlogic,meson-g12a-reset.h
Signature · 1 line
2.20.1
author reviewer
#1 lore raw

PATCH v2 1/2 dt-bindings: reset: meson: add g12a bindings

Add device tree bindings for the reset controller of g12a SoC family.

---
 .../bindings/reset/amlogic,meson-reset.txt    |   7 +-
 .../reset/amlogic,meson-g12a-reset.h          | 134 ++++++++++++++++++
 2 files changed, 139 insertions(+), 2 deletions(-)
 create mode 100644 include/dt-bindings/reset/amlogic,meson-g12a-reset.h
Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt +5 -2
index 28ef6c295c76..053cb1322ee3 100644
@@ -5,8 +5,11 @@ Please also refer to reset.txt in this directory for common reset
 controller binding usage.
 
 Required properties:
-- compatible: Should be "amlogic,meson8b-reset", "amlogic,meson-gxbb-reset" or
-	"amlogic,meson-axg-reset".
+- compatible: Should be
+ * "amlogic,meson8b-reset" or
+ * "amlogic,meson-gxbb-reset" or
+ * "amlogic,meson-axg-reset" or
+ * "amlogic,meson-g12a-reset"
 - reg: should contain the register address base
 - #reset-cells: 1, see below
 
include/dt-bindings/reset/amlogic,meson-g12a-reset.h new file +134 -0

134 lines not on this page · raw message

Signature · 1 line
2.20.1
author reviewer
#2 lore raw

PATCH v2 2/2 reset: meson: add g12a compatible string

In reply to Jerome Brunet

Add a compatible for the new g12a SoC family.

---
 drivers/reset/reset-meson.c | 1 +
 1 file changed, 1 insertion(+)
drivers/reset/reset-meson.c +1 -0
index 5242e0679df7..a8f6549b3af4 100644
@@ -134,6 +134,7 @@ static const struct of_device_id meson_reset_dt_ids[] = {
 	 { .compatible = "amlogic,meson8b-reset" },
 	 { .compatible = "amlogic,meson-gxbb-reset" },
 	 { .compatible = "amlogic,meson-axg-reset" },
+	 { .compatible = "amlogic,meson-g12a-reset" },
 	 { /* sentinel */ },
 };
 
Signature · 1 line
2.20.1
maintainer
#3 lore raw

Re: [PATCH v2 2/2] reset: meson: add g12a compatible string

Quoted 13 lines · Jerome Brunet

Add a compatible for the new g12a SoC family.

---
 drivers/reset/reset-meson.c | 1 +
 1 file changed, 1 insertion(+)
drivers/reset/reset-meson.c +0 -0
index 5242e0679df7..a8f6549b3af4 100644

drivers/reset/reset-meson.c static const struct of_device_id meson_reset_dt_ids[] = { · line 138

Quoted 5 lines
drivers/reset/reset-meson.c +1 -0
@@ -134,6 +134,7 @@ static const struct of_device_id meson_reset_dt_ids[] = {
 	 { .compatible = "amlogic,meson8b-reset" },
 	 { .compatible = "amlogic,meson-gxbb-reset" },
 	 { .compatible = "amlogic,meson-axg-reset" },
+	 { .compatible = "amlogic,meson-g12a-reset" },
 	 { /* sentinel */ },

Looks like this new compatiable isn't used for anything new in the driver. Let's not add a new compatible unless it's needed fo rnew behavior.

Kevin