Skip to contentSkip to conversation

liquidio: fix the validation of rx checksum status from NIC hardware

PATCH Applied Felix Manlunas 2 participants 2 messages Jan 28, 2019 – Jan 29, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 liquidio: fix the validation of rx checksum status from NIC hardware

From: Veerasenareddy Burru <[email protected]>

Fixed the code that was incorrectly interpreting the rx checksum validation status from hardware, and updating kernel that the packet arrived with correct checksum though the packet arrived with incorrect checksum and hardware also indicated checksum is not correct.

---
 drivers/net/ethernet/cavium/liquidio/lio_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/net/ethernet/cavium/liquidio/lio_core.c
index 825a28e..e21bf37 100644

drivers/net/ethernet/cavium/liquidio/lio_core.c +2 -1
@@ -661,7 +661,8 @@ static int octeon_setup_droq(struct octeon_device *oct, int q_no, int num_descs,
 		    (((rh->r_dh.encap_on) &&
 		      (rh->r_dh.csum_verified & CNNIC_TUN_CSUM_VERIFIED)) ||
 		     (!(rh->r_dh.encap_on) &&
-		      (rh->r_dh.csum_verified & CNNIC_CSUM_VERIFIED))))
+		      ((rh->r_dh.csum_verified & CNNIC_CSUM_VERIFIED) ==
+			CNNIC_CSUM_VERIFIED))))
 			/* checksum has already been verified */
 			skb->ip_summed = CHECKSUM_UNNECESSARY;
 		else
Signature · 1 line
1.8.3.1
maintainer Applied
#1 lore raw

From: Felix Manlunas <[email protected]>
Date: Mon, 28 Jan 2019 19:38:31 +0000

Quoted 10 lines

From: Veerasenareddy Burru <[email protected]>

Fixed the code that was incorrectly interpreting the rx checksum validation status from hardware, and updating kernel that the packet arrived with correct checksum though the packet arrived with incorrect checksum and hardware also indicated checksum is not correct.

Applied, thanks.