pinctrl: mediatek: fix dependencies for PINCTRL_MT76XX
Subsystems (4)
PATCH 1/1 pinctrl: mediatek: fix dependencies for PINCTRL_MT76XX
How to reproduce the problem:
$ make tinyconfig $ make menuconfig then enable: CONFIG_COMPILE_TEST=y CONFIG_PINCTRL=y and any of these: CONFIG_PINCTRL_MT7622=y CONFIG_PINCTRL_MT7629=y CONFIG_PINCTRL_MT7623=y
This combination causes build failure.
Fix the problem by making PINCTRL_MT76XX to depend on CONFIG_OF=y.
--- drivers/pinctrl/mediatek/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
drivers/pinctrl/mediatek/Kconfig +3 -0
@@ -45,12 +45,14 @@ config PINCTRL_MT2701 config PINCTRL_MT7623 bool "Mediatek MT7623 pin control with generic binding" depends on MACH_MT7623 || COMPILE_TEST + depends on OF default MACH_MT7623 select PINCTRL_MTK_MOORE config PINCTRL_MT7629 bool "Mediatek MT7629 pin control" depends on MACH_MT7629 || COMPILE_TEST + depends on OF default MACH_MT7629 select PINCTRL_MTK_MOORE
@@ -92,6 +94,7 @@ config PINCTRL_MT6797 config PINCTRL_MT7622 bool "MediaTek MT7622 pin control" + depends on OF depends on ARM64 || COMPILE_TEST default ARM64 && ARCH_MEDIATEK select PINCTRL_MTK_MOORE
Signature · 1 line
2.20.1
Sean Wang
maintainerQuoted 49 lines · Dmitry Voytik
How to reproduce the problem:
$ make tinyconfig $ make menuconfig then enable: CONFIG_COMPILE_TEST=y CONFIG_PINCTRL=y and any of these: CONFIG_PINCTRL_MT7622=y CONFIG_PINCTRL_MT7629=y CONFIG_PINCTRL_MT7623=yThis combination causes build failure.
Fix the problem by making
PINCTRL_MT76XXto depend onCONFIG_OF=y.Signed-off-by Dmitry Voytik <[email protected]>--- drivers/pinctrl/mediatek/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/pinctrl/mediatek/Kconfig +3
-1@@ -45,12 +45,14 @@ config PINCTRL_MT2701 config PINCTRL_MT7623 bool "Mediatek MT7623 pin control with generic binding" depends on MACH_MT7623 || COMPILE_TEST + depends on OF default MACH_MT7623 select PINCTRL_MTK_MOORE config PINCTRL_MT7629 bool "Mediatek MT7629 pin control" depends on MACH_MT7629 || COMPILE_TEST + depends on OF default MACH_MT7629 select PINCTRL_MTK_MOORE@@ -92,6 +94,7 @@ config PINCTRL_MT6797 config PINCTRL_MT7622 bool "MediaTek MT7622 pin control" + depends on OF depends on ARM64 || COMPILE_TEST default ARM64 && ARCH_MEDIATEK select PINCTRL_MTK_MOORE --
Quoted 2 lines
2.20.1
It seems the commit 2d2d478576d71000b29c52668c5712c825ee9af8 already fixed the problem or is there something I'm missing?
Quoted 43 lines · Sean Wang
Quoted 42 lines · Dmitry Voytik
How to reproduce the problem:
$ make tinyconfig $ make menuconfig then enable: CONFIG_COMPILE_TEST=y CONFIG_PINCTRL=y and any of these: CONFIG_PINCTRL_MT7622=y CONFIG_PINCTRL_MT7629=y CONFIG_PINCTRL_MT7623=yThis combination causes build failure.
Fix the problem by making
PINCTRL_MT76XXto depend onCONFIG_OF=y.Signed-off-by Dmitry Voytik <[email protected]>--- drivers/pinctrl/mediatek/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/pinctrl/mediatek/Kconfig +2
-0@@ -45,12 +45,14 @@ config PINCTRL_MT2701 config PINCTRL_MT7623 bool "Mediatek MT7623 pin control with generic binding" depends on MACH_MT7623 || COMPILE_TEST + depends on OF default MACH_MT7623 select PINCTRL_MTK_MOORE config PINCTRL_MT7629 bool "Mediatek MT7629 pin control" depends on MACH_MT7629 || COMPILE_TEST + depends on OF default MACH_MT7629 select PINCTRL_MTK_MOORE@@ -92,6 +94,7 @@ config PINCTRL_MT6797
Quoted 13 lines
Quoted 9 lines
drivers/pinctrl/mediatek/Kconfig +1
-1config PINCTRL_MT7622 bool "MediaTek MT7622 pin control" + depends on OF depends on ARM64 || COMPILE_TEST default ARM64 && ARCH_MEDIATEK select PINCTRL_MTK_MOORE --2.20.1
It seems the commit
2d2d478576d71000b29c52668c5712c825ee9af8already fixed the problem or is there something I'm missing?
Opps, sorry. Should have checked linux-pinctrl.git. Sorry for spamming.
BR,
Dmitry.