Skip to contentSkip to conversation

drm: drop drm_bus from todo

PATCH In review Sam Ravnborg 4 participants 7 messages Jan 26, 2019 – Apr 27, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: drop drm_bus from todo

David Herrmann removed the last bits of drm_bus in:
c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!")

Remove the todo item.

Cc David Herrmann <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
---
 Documentation/gpu/todo.rst | 19 -------------------
 1 file changed, 19 deletions(-)
Documentation/gpu/todo.rst +0 -19
index 38360ede1221..d9515b17d36f 100644
@@ -10,25 +10,6 @@ graphics subsystem useful as newbie projects. Or for slow rainy days.
 Subsystem-wide refactorings
 ===========================
 
-De-midlayer drivers
--------------------
-
-With the recent ``drm_bus`` cleanup patches for 3.17 it is no longer required
-to have a ``drm_bus`` structure set up. Drivers can directly set up the
-``drm_device`` structure instead of relying on bus methods in ``drm_usb.c``
-and ``drm_pci.c``. The goal is to get rid of the driver's ``->load`` /
-``->unload`` callbacks and open-code the load/unload sequence properly, using
-the new two-stage ``drm_device`` setup/teardown.
-
-Once all existing drivers are converted we can also remove those bus support
-files for USB and platform devices.
-
-All you need is a GPU for a non-converted driver (currently almost all of
-them, but also all the virtual ones used by KVM, so everyone qualifies).
-
-Contact: Daniel Vetter, Thierry Reding, respective driver maintainers
-
-
 Remove custom dumb_map_offset implementations
 ---------------------------------------------
 
Signature · 6 lines
2.12.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

Hey

Quoted 12 lines · Sam Ravnborg

David Herrmann removed the last bits of drm_bus in:
c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!")

Remove the todo item.

Cc David Herrmann <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
Quoted 3 lines
---
 Documentation/gpu/todo.rst | 19 -------------------
 1 file changed, 19 deletions(-)

I miss drm_bus!

Thanks
David

Quoted 31 lines
Documentation/gpu/todo.rst +0 -20
index 38360ede1221..d9515b17d36f 100644
@@ -10,25 +10,6 @@ graphics subsystem useful as newbie projects. Or for slow rainy days.
 Subsystem-wide refactorings
 ===========================
 
-De-midlayer drivers
--------------------
-
-With the recent ``drm_bus`` cleanup patches for 3.17 it is no longer required
-to have a ``drm_bus`` structure set up. Drivers can directly set up the
-``drm_device`` structure instead of relying on bus methods in ``drm_usb.c``
-and ``drm_pci.c``. The goal is to get rid of the driver's ``->load`` /
-``->unload`` callbacks and open-code the load/unload sequence properly, using
-the new two-stage ``drm_device`` setup/teardown.
-
-Once all existing drivers are converted we can also remove those bus support
-files for USB and platform devices.
-
-All you need is a GPU for a non-converted driver (currently almost all of
-them, but also all the virtual ones used by KVM, so everyone qualifies).
-
-Contact: Daniel Vetter, Thierry Reding, respective driver maintainers
-
-
 Remove custom dumb_map_offset implementations
 ---------------------------------------------
 
--
Quoted 2 lines

2.12.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 19 lines · David Herrmann

Hey

Quoted 12 lines · Sam Ravnborg

David Herrmann removed the last bits of drm_bus in:
c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!")

Remove the todo item.

Cc David Herrmann <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
Quoted 3 lines
---
 Documentation/gpu/todo.rst | 19 -------------------
 1 file changed, 19 deletions(-)
Quoted 3 lines

I miss drm_bus!

Sam, want drm-misc commit rights to start merging your own stuff? Assuming you plan to stick around ofc ... I'll also ask the drm-misc maintainers whether that's ok.

Thanks, Daniel

Quoted 37 lines

Thanks
David

Quoted 33 lines
Documentation/gpu/todo.rst +0 -20
index 38360ede1221..d9515b17d36f 100644
@@ -10,25 +10,6 @@ graphics subsystem useful as newbie projects. Or for slow rainy days.
 Subsystem-wide refactorings
 ===========================
 
-De-midlayer drivers
--------------------
-
-With the recent ``drm_bus`` cleanup patches for 3.17 it is no longer required
-to have a ``drm_bus`` structure set up. Drivers can directly set up the
-``drm_device`` structure instead of relying on bus methods in ``drm_usb.c``
-and ``drm_pci.c``. The goal is to get rid of the driver's ``->load`` /
-``->unload`` callbacks and open-code the load/unload sequence properly, using
-the new two-stage ``drm_device`` setup/teardown.
-
-Once all existing drivers are converted we can also remove those bus support
-files for USB and platform devices.
-
-All you need is a GPU for a non-converted driver (currently almost all of
-them, but also all the virtual ones used by KVM, so everyone qualifies).
-
-Contact: Daniel Vetter, Thierry Reding, respective driver maintainers
-
-
 Remove custom dumb_map_offset implementations
 ---------------------------------------------
 
--

2.12.0

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw

Hi Daniel.

Quoted 4 lines

Sam, want drm-misc commit rights to start merging your own stuff? Assuming you plan to stick around ofc ... I'll also ask the drm-misc maintainers whether that's ok.

The plan is to re-submit the Atmel LCDC DRM driver when I find enough time to finish it. All coding is done and it builds, I 'only' need to make it work.

When I submit the driver the plan is to share the maintainer role for both Atmel based DRM drivers (hlcdc + lcdc).
So it would make sense to gain drm-misc commit rights at least then.

Last time I looked at it I was stucked in the keys required and the tools I needed to learn. This was not really where I had energy to spend the effort.

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 10 lines · Sam Ravnborg

Hi Daniel.

Quoted 4 lines

Sam, want drm-misc commit rights to start merging your own stuff? Assuming you plan to stick around ofc ... I'll also ask the drm-misc maintainers whether that's ok.

The plan is to re-submit the Atmel LCDC DRM driver when I find enough time to finish it. All coding is done and it builds, I 'only' need to make it work.

Quoted 6 lines

When I submit the driver the plan is to share the maintainer role for both Atmel based DRM drivers (hlcdc + lcdc).
So it would make sense to gain drm-misc commit rights at least then.

Last time I looked at it I was stucked in the keys required and the tools I needed to learn. This was not really where I had energy to spend the effort.

Can I motivate you some more? I'm happy to ramp up people for a bit, but I can't do patch review&applying for everyone. Wouldn't scale. Expect me to become increasingly annoying about this :-)
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by
#5 lore raw
In reply to Daniel Vetter
Quoted 21 lines · Daniel Vetter
Quoted 19 lines · David Herrmann

Hey

Quoted 15 lines · Sam Ravnborg

David Herrmann removed the last bits of drm_bus in:
c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!")

Remove the todo item.

Cc David Herrmann <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
---
 Documentation/gpu/todo.rst | 19 -------------------
 1 file changed, 19 deletions(-)
Quoted 8 lines
Quoted 3 lines

I miss drm_bus!

Sam, want drm-misc commit rights to start merging your own stuff? Assuming you plan to stick around ofc ... I'll also ask the drm-misc maintainers whether that's ok.

Quoted 36 lines

Thanks, Daniel

Quoted 34 lines

Thanks
David

Quoted 30 lines
Documentation/gpu/todo.rst +0 -19
index 38360ede1221..d9515b17d36f 100644
@@ -10,25 +10,6 @@ graphics subsystem useful as newbie projects. Or for slow rainy days.
 Subsystem-wide refactorings
 ===========================
 
-De-midlayer drivers
--------------------
-
-With the recent ``drm_bus`` cleanup patches for 3.17 it is no longer required
-to have a ``drm_bus`` structure set up. Drivers can directly set up the
-``drm_device`` structure instead of relying on bus methods in ``drm_usb.c``
-and ``drm_pci.c``. The goal is to get rid of the driver's ``->load`` /
-``->unload`` callbacks and open-code the load/unload sequence properly, using
-the new two-stage ``drm_device`` setup/teardown.
-
-Once all existing drivers are converted we can also remove those bus support
-files for USB and platform devices.
-
-All you need is a GPU for a non-converted driver (currently almost all of
-them, but also all the virtual ones used by KVM, so everyone qualifies).
-
-Contact: Daniel Vetter, Thierry Reding, respective driver maintainers
-
-
 Remove custom dumb_map_offset implementations
 ---------------------------------------------
 
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

--
2.12.0

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw
In reply to David Herrmann
Quoted 19 lines · David Herrmann

Hey

Quoted 12 lines · Sam Ravnborg

David Herrmann removed the last bits of drm_bus in:
c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!")

Remove the todo item.

Cc David Herrmann <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
Quoted 3 lines
---
 Documentation/gpu/todo.rst | 19 -------------------
 1 file changed, 19 deletions(-)
Quoted 3 lines

I miss drm_bus!

Applied and pushed to drm-misc-next

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel