Skip to contentSkip to conversation

dt-bindings: aspeed-lpc: Make parameter optional

PATCH Superseded Vijay Khemka 2 participants 3 messages Jan 18, 2019 – Jan 29, 2019

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: aspeed-lpc: Make parameter optional

Memory-region and flash phandle is not a required parameter, it is optional to describe in device tree and needed only use basis.

---
 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +3 -0
index 34dd89087cff..d28c4e117611 100644
@@ -135,6 +135,9 @@ Required properties:
 - clocks:	contains a phandle to the syscon node describing the clocks.
 		There should then be one cell representing the clock to use
 
+Optional properties:
+These below properties are optional to define.
+
 - memory-region: A phandle to a reserved_memory region to be used for the LPC
 		to AHB mapping
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Vijay Khemka

Memory-region and flash phandle is not a required parameter, it is optional to describe in device tree and needed only use basis.

---
 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +0 -0
index 34dd89087cff..d28c4e117611 100644

Documentation/devicetree/bindings/mfd/aspeed-lpc.txt Required properties: · line 139

Quoted 5 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +2 -0
@@ -135,6 +135,9 @@ Required properties:
 - clocks:	contains a phandle to the syscon node describing the clocks.
 		There should then be one cell representing the clock to use
 
+Optional properties:
+These below properties are optional to define.

This line is superfluous. Please remove it.

Quoted 4 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +1 -0
+
 - memory-region: A phandle to a reserved_memory region to be used for the LPC
 		to AHB mapping
 
Signature · 4 lines
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw

Thanks Lee,

?On 1/29/19, 4:30 AM, "Lee Jones" <[email protected]> wrote:

On Fri, 18 Jan 2019, Vijay Khemka wrote:

> Memory-region and flash phandle is not a required parameter, it is
> optional to describe in device tree and needed only use basis.
>
> Signed-off-by: Vijay Khemka <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt > index 34dd89087cff..d28c4e117611 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> @@ -135,6 +135,9 @@ Required properties:
> - clocks: contains a phandle to the syscon node describing the clocks.
> There should then be one cell representing the clock to use
>
> +Optional properties:
> +These below properties are optional to define.

This line is superfluous. Please remove it.
I will remove it. I am assuming only 1 line to remove.

Documentation/devicetree/bindings/mfd/aspeed-lpc.txt Required properties: · line 142

Quoted 4 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt +1 -0
+
 - memory-region: A phandle to a reserved_memory region to be used for the LPC
 		to AHB mapping

--
Lee Jones [???]
Linaro Services Technical Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog