Skip to contentSkip to conversation

mtd: rawnand: meson:: make several functions static

PATCH In review Colin King 3 participants 4 messages Jan 29, 2019 – Feb 5, 2019

Subsystems (5)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 mtd: rawnand: meson:: make several functions static

From: Colin Ian King <[email protected]>

There are several functions that are local to the source and do not need to be in global scope, so make them static.

Cleans up sparse warnings.

---
 drivers/mtd/nand/raw/meson_nand.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/mtd/nand/raw/meson_nand.c +5 -5
index b9c543d1054c..9557bd94dcd2 100644
@@ -829,14 +829,14 @@ static int meson_nfc_read_oob(struct nand_chip *nand, int page)
 	return meson_nfc_read_page_hwecc(nand, NULL, 1, page);
 }
 
-bool meson_nfc_is_buffer_dma_safe(const void *buffer)
+static bool meson_nfc_is_buffer_dma_safe(const void *buffer)
 {
 	if (virt_addr_valid(buffer) && (!object_is_on_stack(buffer)))
 		return true;
 	return false;
 }
 
-void *
+static void *
 meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
 {
 	if (WARN_ON(instr->type != NAND_OP_DATA_IN_INSTR))
@@ -848,7 +848,7 @@ meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
 	return kzalloc(instr->ctx.data.len, GFP_KERNEL);
 }
 
-void
+static void
 meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
 				     void *buf)
 {
@@ -863,7 +863,7 @@ meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
 	kfree(buf);
 }
 
-void *
+static void *
 meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
 {
 	if (WARN_ON(instr->type != NAND_OP_DATA_OUT_INSTR))
@@ -876,7 +876,7 @@ meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
 		       instr->ctx.data.len, GFP_KERNEL);
 }
 
-void
+static void
 meson_nand_op_put_dma_safe_output_buf(const struct nand_op_instr *instr,
 				      const void *buf)
 {
Signature · 1 line
2.19.1
maintainer
#1 lore raw

Hello Colin,

Quoted 7 lines · Colin King

From: Colin Ian King <[email protected]>

There are several functions that are local to the source and do not need to be in global scope, so make them static.

Cleans up sparse warnings.

ok. thanks

Quoted 46 lines
---
  drivers/mtd/nand/raw/meson_nand.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
drivers/mtd/nand/raw/meson_nand.c +4 -4
index b9c543d1054c..9557bd94dcd2 100644
@@ -829,14 +829,14 @@ static int meson_nfc_read_oob(struct nand_chip *nand, int page)
  	return meson_nfc_read_page_hwecc(nand, NULL, 1, page);
  }
 
-bool meson_nfc_is_buffer_dma_safe(const void *buffer)
+static bool meson_nfc_is_buffer_dma_safe(const void *buffer)
  {
  	if (virt_addr_valid(buffer) && (!object_is_on_stack(buffer)))
  		return true;
  	return false;
  }
 
-void *
+static void *
  meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
  {
  	if (WARN_ON(instr->type != NAND_OP_DATA_IN_INSTR))
@@ -848,7 +848,7 @@ meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
  	return kzalloc(instr->ctx.data.len, GFP_KERNEL);
  }
 
-void
+static void
  meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
  				     void *buf)
  {
@@ -863,7 +863,7 @@ meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
  	kfree(buf);
  }
 
-void *
+static void *
  meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
  {
  	if (WARN_ON(instr->type != NAND_OP_DATA_OUT_INSTR))

drivers/mtd/nand/raw/meson_nand.c meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr) · line 882

Quoted 8 lines
drivers/mtd/nand/raw/meson_nand.c +1 -1
@@ -876,7 +876,7 @@ meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
  		       instr->ctx.data.len, GFP_KERNEL);
  }
 
-void
+static void
  meson_nand_op_put_dma_safe_output_buf(const struct nand_op_instr *instr,
  				      const void *buf)
  {

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Colin King

Hi Colin,

Quoted 53 lines · Colin King

From: Colin Ian King <[email protected]>

There are several functions that are local to the source and do not need to be in global scope, so make them static.

Cleans up sparse warnings.

---
  drivers/mtd/nand/raw/meson_nand.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
drivers/mtd/nand/raw/meson_nand.c +4 -4
index b9c543d1054c..9557bd94dcd2 100644
@@ -829,14 +829,14 @@ static int meson_nfc_read_oob(struct nand_chip *nand, int page)
  	return meson_nfc_read_page_hwecc(nand, NULL, 1, page);
  }
 
-bool meson_nfc_is_buffer_dma_safe(const void *buffer)
+static bool meson_nfc_is_buffer_dma_safe(const void *buffer)
  {
  	if (virt_addr_valid(buffer) && (!object_is_on_stack(buffer)))
  		return true;
  	return false;
  }
 
-void *
+static void *
  meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
  {
  	if (WARN_ON(instr->type != NAND_OP_DATA_IN_INSTR))
@@ -848,7 +848,7 @@ meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
  	return kzalloc(instr->ctx.data.len, GFP_KERNEL);
  }
 
-void
+static void
  meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
  				     void *buf)
  {
@@ -863,7 +863,7 @@ meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
  	kfree(buf);
  }
 
-void *
+static void *
  meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
  {
  	if (WARN_ON(instr->type != NAND_OP_DATA_OUT_INSTR))

drivers/mtd/nand/raw/meson_nand.c meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr) · line 882

Quoted 8 lines
drivers/mtd/nand/raw/meson_nand.c +1 -1
@@ -876,7 +876,7 @@ meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
  		       instr->ctx.data.len, GFP_KERNEL);
  }
 
-void
+static void
  meson_nand_op_put_dma_safe_output_buf(const struct nand_op_instr *instr,
  				      const void *buf)
  {

Looks good to me: