drm/nouveau: mark expected switch fall-through
Subsystems (3)
PATCH 1/1 drm/nouveau: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/gpu/drm/nouveau/nouveau_bo.c:1434:53: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
--- drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_bo.c +1 -1
@@ -1434,7 +1434,7 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg)if (drm->client.mem->oclass <NVIF_CLASS_MEM_NV50 || !mem->kind)/* untiled */ break ; -/* fallthrough, tiled memory */ +/* fall through - tiled memory */ case TTM_PL_VRAM : reg->bus.offset = reg->start <<PAGE_SHIFT ; reg->bus.base = device->func->resource_addr (device,1 );
Signature · 1 line
2.20.1
Got it, thanks.
Quoted 38 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/gpu/drm/nouveau/nouveau_bo.c:1434:53: warning: this statement may fall through [-Wimplicit-fallthrough=]Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nouveau_bo.c +1
-2@@ -1434,7 +1434,7 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg)if (drm->client.mem->oclass <NVIF_CLASS_MEM_NV50 || !mem->kind)/* untiled */ break ; -/* fallthrough, tiled memory */ +/* fall through - tiled memory */ case TTM_PL_VRAM : reg->bus.offset = reg->start <<PAGE_SHIFT ; reg->bus.base = device->func->resource_addr (device,1 ); --2.20.1
_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau
Ben,
I wonder if you can take this too:
https://lore.kernel.org/patchwork/patch/1001180/
Thanks
--
Gustavo
Quoted 42 lines · Ben Skeggs
Got it, thanks.
Quoted 38 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/gpu/drm/nouveau/nouveau_bo.c:1434:53: warning: this statement may fall through [-Wimplicit-fallthrough=]Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nouveau_bo.c +1
-2@@ -1434,7 +1434,7 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg)if (drm->client.mem->oclass <NVIF_CLASS_MEM_NV50 || !mem->kind)/* untiled */ break ; -/* fallthrough, tiled memory */ +/* fall through - tiled memory */ case TTM_PL_VRAM : reg->bus.offset = reg->start <<PAGE_SHIFT ; reg->bus.base = device->func->resource_addr (device,1 ); --2.20.1
_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau