i386, acpi: cleanup build_facs by removing second unused argument
PATCH 1/1 i386, acpi: cleanup build_facs by removing second unused argument
The second argument of build_facs() is not used, just remove it.
Signed-off-by Wei Yang <[email protected]>
--- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
hw/i386/acpi-build.c +2 -2
@@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)/* FACS */ static void -build_facs (GArray *table_data,BIOSLinker *linker) +build_facs (GArray *table_data) {AcpiFacsDescriptorRev1 *facs =acpi_data_push (table_data,sizeof *facs);memcpy (&facs->signature,"FACS" ,4 );
@@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)* requirements. */ facs = tables_blob->len; -build_facs (tables_blob, tables->linker); +build_facs (tables_blob);/* DSDT is pointed to by FADT */ dsdt = tables_blob->len;
Signature · 1 line
2.19.1
Quoted 3 lines · On Wed, 30 Jan 2019 11:02:07 +0800 Wei Yang <[email protected]>…
The second argument of
build_facs()is not used, just remove it.Signed-off-by Wei Yang <[email protected]>
Reviewed-by Igor Mammedov <[email protected]>
Quoted 26 lines
--- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/i386/acpi-build.c +2
-2@@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)/* FACS */ static void -build_facs (GArray *table_data,BIOSLinker *linker) +build_facs (GArray *table_data) {AcpiFacsDescriptorRev1 *facs =acpi_data_push (table_data,sizeof *facs);memcpy (&facs->signature,"FACS" ,4 );@@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)* requirements. */ facs = tables_blob->len; -build_facs (tables_blob, tables->linker); +build_facs (tables_blob);/* DSDT is pointed to by FADT */ dsdt = tables_blob->len;
Quoted 8 lines · Igor Mammedov
Quoted 3 lines · On Wed, 30 Jan 2019 11:02:07 +0800 Wei Yang <[email protected]>…
The second argument of
build_facs()is not used, just remove it.Signed-off-by Wei Yang <[email protected]>Reviewed-by Igor Mammedov <[email protected]>
Thanks :-)
Quoted 27 lines
Quoted 27 lines
--- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/i386/acpi-build.c +2
-2@@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)/* FACS */ static void -build_facs (GArray *table_data,BIOSLinker *linker) +build_facs (GArray *table_data) {AcpiFacsDescriptorRev1 *facs =acpi_data_push (table_data,sizeof *facs);memcpy (&facs->signature,"FACS" ,4 );@@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)* requirements. */ facs = tables_blob->len; -build_facs (tables_blob, tables->linker); +build_facs (tables_blob);/* DSDT is pointed to by FADT */ dsdt = tables_blob->len;
Signature · 2 lines
Wei Yang Help you, Help me
Quoted 3 lines · Wei Yang
The second argument of
build_facs()is not used, just remove it.Signed-off-by Wei Yang <[email protected]>
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 27 lines
--- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/i386/acpi-build.c +2
-2@@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)/* FACS */ static void -build_facs (GArray *table_data,BIOSLinker *linker) +build_facs (GArray *table_data) {AcpiFacsDescriptorRev1 *facs =acpi_data_push (table_data,sizeof *facs);memcpy (&facs->signature,"FACS" ,4 );@@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)* requirements. */ facs = tables_blob->len; -build_facs (tables_blob, tables->linker); +build_facs (tables_blob);/* DSDT is pointed to by FADT */ dsdt = tables_blob->len;
Quoted 7 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Wei Yang
The second argument of
build_facs()is not used, just remove it.Signed-off-by Wei Yang <[email protected]>Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Thanks :-)
Quoted 28 lines
Quoted 28 lines
--- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/i386/acpi-build.c +2
-2@@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)/* FACS */ static void -build_facs (GArray *table_data,BIOSLinker *linker) +build_facs (GArray *table_data) {AcpiFacsDescriptorRev1 *facs =acpi_data_push (table_data,sizeof *facs);memcpy (&facs->signature,"FACS" ,4 );@@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)* requirements. */ facs = tables_blob->len; -build_facs (tables_blob, tables->linker); +build_facs (tables_blob);/* DSDT is pointed to by FADT */ dsdt = tables_blob->len;
Signature · 2 lines
Wei Yang Help you, Help me