Skip to contentSkip to conversation

target/s390x: Fix LGPL version in the file header comments

PATCH Applied Thomas Huth 7 participants 8 messages Jan 29, 2019 – Jan 31, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/s390x: Fix LGPL version in the file header comments

It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

---
 target/s390x/cc_helper.c   | 2 +-
 target/s390x/excp_helper.c | 2 +-
 target/s390x/fpu_helper.c  | 2 +-
 target/s390x/gdbstub.c     | 2 +-
 target/s390x/helper.c      | 2 +-
 target/s390x/int_helper.c  | 2 +-
 target/s390x/mem_helper.c  | 2 +-
 target/s390x/misc_helper.c | 2 +-
 target/s390x/translate.c   | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)
target/s390x/cc_helper.c +1 -1
index 5d91e45..307ad61 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/excp_helper.c +1 -1
index 2a33222..a758649 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/fpu_helper.c +1 -1
index 1b662d2..e921172 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/gdbstub.c +1 -1
index b8c81da..df14759 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/helper.c +1 -1
index 2546316..3d74836 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/int_helper.c +1 -1
index abf77a9..abbbc20 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/mem_helper.c +1 -1
index 490c43e..a506d9e 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/misc_helper.c +1 -1
index 3f91579..52262f6 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/translate.c +1 -1
index b5bd56b..6249c70 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Tue, 29 Jan 2019 14:37:47 +0100 Thomas Huth <[email protected]> wrote:

It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

I think we can assume that.

Given that there have been several of these cases (and that there's a lot of boilerplate in general): Should we adopt SPDX license identifiers for QEMU, as the Linux kernel did? They also discovered and fixed some problems/oddities while at it.

Quoted 13 lines
---
 target/s390x/cc_helper.c   | 2 +-
 target/s390x/excp_helper.c | 2 +-
 target/s390x/fpu_helper.c  | 2 +-
 target/s390x/gdbstub.c     | 2 +-
 target/s390x/helper.c      | 2 +-
 target/s390x/int_helper.c  | 2 +-
 target/s390x/mem_helper.c  | 2 +-
 target/s390x/misc_helper.c | 2 +-
 target/s390x/translate.c   | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

Is this going through the trivial tree? If so,

I can also take this through the s390x tree.

#2 lore raw
Quoted 8 lines · Cornelia Huck
Quoted 4 lines · On Tue, 29 Jan 2019 14:37:47 +0100 Thomas Huth <[email protected]> wrote:

It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

Quoted 6 lines

I think we can assume that.

Given that there have been several of these cases (and that there's a lot of boilerplate in general): Should we adopt SPDX license identifiers for QEMU, as the Linux kernel did? They also discovered and fixed some problems/oddities while at it.

This might be cheaper than adding checkpatch rules to parse current licenses to avoid miswritten one coming back...

Quoted 20 lines
Quoted 13 lines
---
 target/s390x/cc_helper.c   | 2 +-
 target/s390x/excp_helper.c | 2 +-
 target/s390x/fpu_helper.c  | 2 +-
 target/s390x/gdbstub.c     | 2 +-
 target/s390x/helper.c      | 2 +-
 target/s390x/int_helper.c  | 2 +-
 target/s390x/mem_helper.c  | 2 +-
 target/s390x/misc_helper.c | 2 +-
 target/s390x/translate.c   | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

Is this going through the trivial tree? If so,

I can also take this through the s390x tree.

#3 lore raw
In reply to Cornelia Huck
Quoted 8 lines · Cornelia Huck
Quoted 4 lines · On Tue, 29 Jan 2019 14:37:47 +0100 Thomas Huth <[email protected]> wrote:

It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

Quoted 6 lines

I think we can assume that.

Given that there have been several of these cases (and that there's a lot of boilerplate in general): Should we adopt SPDX license identifiers for QEMU, as the Linux kernel did? They also discovered and fixed some problems/oddities while at it.

I'm also in favor of SPDX license identifiers - their brevity and machine-parsability favors more accurate usage and fewer copy/paste mistake propagation.

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
#4 lore raw
Quoted 11 lines · Eric Blake
Quoted 10 lines · Cornelia Huck
Quoted 4 lines · On Tue, 29 Jan 2019 14:37:47 +0100 Thomas Huth <[email protected]> wrote:

It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

I think we can assume that.

Quoted 8 lines
Quoted 4 lines

Given that there have been several of these cases (and that there's a lot of boilerplate in general): Should we adopt SPDX license identifiers for QEMU, as the Linux kernel did? They also discovered and fixed some problems/oddities while at it.

I'm also in favor of SPDX license identifiers - their brevity and machine-parsability favors more accurate usage and fewer copy/paste mistake propagation.

I'm curious if the kernel developers actually ended up removing the current boilerplate license text from files they added SPDX tags to ?

The original work only added SPDX tags to files which lacked any pre-existing license text

https://lwn.net/Articles/739183/

Although its from 2017, the LWN article indicates there was some uncertainty about whether they'd actually go through with removing license text, especially for files where the person removing the text is not the exclusive copyright holder:

"An additional goal is to eventually get rid of the other license
texts; the consensus seems to be that the SPDX identifier is a sufficient declaration of the license on its own. But removing license text from source files must be done with a great deal of care, so it may be a long time before anybody works up the courage to attempt that on any files that they do not themselves own the copyright for. "

I can understand the sentiment that SPDX identifier alone should be sufficient, but I think I'd want to see an explicit legal opinion from a lawyer who works with open source before removing any license text.

Any one know if anything changed in this respect since that 2017 lwn article ?

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#5 lore raw
Quoted 44 lines · On Wed, 30 Jan 2019 15:18:29 +0000 Daniel P. Berrangé <[email protected]>…
Quoted 11 lines · Eric Blake
Quoted 10 lines · Cornelia Huck
Quoted 4 lines · On Tue, 29 Jan 2019 14:37:47 +0100 Thomas Huth <[email protected]> wrote:

It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

I think we can assume that.

Quoted 8 lines
Quoted 4 lines

Given that there have been several of these cases (and that there's a lot of boilerplate in general): Should we adopt SPDX license identifiers for QEMU, as the Linux kernel did? They also discovered and fixed some problems/oddities while at it.

I'm also in favor of SPDX license identifiers - their brevity and machine-parsability favors more accurate usage and fewer copy/paste mistake propagation.

I'm curious if the kernel developers actually ended up removing the current boilerplate license text from files they added SPDX tags to ?

The original work only added SPDX tags to files which lacked any pre-existing license text

https://lwn.net/Articles/739183/

Although its from 2017, the LWN article indicates there was some uncertainty about whether they'd actually go through with removing license text, especially for files where the person removing the text is not the exclusive copyright holder:

"An additional goal is to eventually get rid of the other license
texts; the consensus seems to be that the SPDX identifier is a sufficient declaration of the license on its own. But removing license text from source files must be done with a great deal of care, so it may be a long time before anybody works up the courage to attempt that on any files that they do not themselves own the copyright for. "

Quoted 6 lines

I can understand the sentiment that SPDX identifier alone should be sufficient, but I think I'd want to see an explicit legal opinion from a lawyer who works with open source before removing any license text.

Any one know if anything changed in this respect since that 2017 lwn article ?

The boilerplate texts have been removed; see e.g. 13d1d559f04a ("s390:
drivers: Remove redundant license text").

The commit messages for this and other patches also suggest that SPDX identifiers are legally binding, so this has probably been vetted by a couple of lawyers already.

#6 lore raw
In reply to Eric Blake
Quoted 9 lines · Eric Blake
Quoted 4 lines · Cornelia Huck

Given that there have been several of these cases (and that there's a lot of boilerplate in general): Should we adopt SPDX license identifiers for QEMU, as the Linux kernel did? They also discovered and fixed some problems/oddities while at it.

I'm also in favor of SPDX license identifiers - their brevity and machine-parsability favors more accurate usage and fewer copy/paste mistake propagation.

+1.

r~

#7 lore raw
In reply to Thomas Huth
Quoted 128 lines · Thomas Huth

It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

---
 target/s390x/cc_helper.c   | 2 +-
 target/s390x/excp_helper.c | 2 +-
 target/s390x/fpu_helper.c  | 2 +-
 target/s390x/gdbstub.c     | 2 +-
 target/s390x/helper.c      | 2 +-
 target/s390x/int_helper.c  | 2 +-
 target/s390x/mem_helper.c  | 2 +-
 target/s390x/misc_helper.c | 2 +-
 target/s390x/translate.c   | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)
target/s390x/cc_helper.c +1 -1
index 5d91e45..307ad61 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/excp_helper.c +1 -1
index 2a33222..a758649 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/fpu_helper.c +1 -1
index 1b662d2..e921172 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/gdbstub.c +1 -1
index b8c81da..df14759 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/helper.c +1 -1
index 2546316..3d74836 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/int_helper.c +1 -1
index abf77a9..abbbc20 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/mem_helper.c +1 -1
index 490c43e..a506d9e 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/misc_helper.c +1 -1
index 3f91579..52262f6 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
target/s390x/translate.c +0 -0
index b5bd56b..6249c70 100644

target/s390x/translate.c line 13

Quoted 8 lines
target/s390x/translate.c +1 -1
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of

Applied to my trivial-patches branch.

Thanks,
Laurent