Skip to contentSkip to conversation

clk: imx8mq: Fix the CLKO2 source select list

PATCH Applied Fabio Estevam 2 participants 6 messages Jan 30, 2019 – Feb 21, 2019

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 clk: imx8mq: Fix the CLKO2 source select list

The CLKO2 clock source select list is the following as per the i.MX8M Reference Manual:

000 - 25M_REF_CLK
001 - SYSTEM_PLL2_DIV5
010 - SYSTEM_PLL1_DIV2
011 - SYSTEM_PLL2_DIV6
100 - SYSTEM_PLL3_CLK
101 - AUDIO_PLL1_CLK
110 - VIDEO_PLL1_CLK
111 - 32K_REF_CLK

However, in imx8mq_clko2_sels[] only the first four entries are correct.

Fix it by adding the missing "sys3_pll2_out" entry in order to match the description from the manual.

Fixes b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM")
---
 drivers/clk/imx/clk-imx8mq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/imx/clk-imx8mq.c +2 -2
index 398ab0bcd9de..63001bc891d4 100644
@@ -264,8 +264,8 @@ static const char * const imx8mq_ecspi3_sels[] = {"osc_25m", "sys2_pll_200m", "s
 					   "sys1_pll_800m", "sys3_pll2_out", "sys2_pll_250m", "audio_pll2_out", };
 static const char * const imx8mq_dram_core_sels[] = {"dram_pll_out", "dram_alt_root", };
 
-static const char * const imx8mq_clko2_sels[] = {"osc_25m", "sys2_pll_200m", "sys1_pll_400m", "sys2_pll_166m", "audio_pll1_out",
-					 "video_pll1_out", "ckil", };
+static const char * const imx8mq_clko2_sels[] = {"osc_25m", "sys2_pll_200m", "sys1_pll_400m", "sys2_pll_166m",
+					  "sys3_pll2_out", "audio_pll1_out", "video_pll1_out", "ckil", };
 
 static struct clk_onecell_data clk_data;
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw

Quoting Fabio Estevam (2019-01-30 11:21:02)

Quoted 14 lines

The CLKO2 clock source select list is the following as per the i.MX8M Reference Manual:

000 - 25M_REF_CLK
001 - SYSTEM_PLL2_DIV5
010 - SYSTEM_PLL1_DIV2
011 - SYSTEM_PLL2_DIV6
100 - SYSTEM_PLL3_CLK
101 - AUDIO_PLL1_CLK
110 - VIDEO_PLL1_CLK
111 - 32K_REF_CLK

However, in imx8mq_clko2_sels[] only the first four entries are correct.

Quoted 7 lines

Fix it by adding the missing "sys3_pll2_out" entry in order to match the description from the manual.

Fixes b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM")

---

Do I need to fast track this into v5.0 final? Or this is a non-critical fix for something that isn't used right now?

author reviewer
#2 lore raw

Hi Stephen,

Quoted 2 lines · Stephen Boyd

Do I need to fast track this into v5.0 final? Or this is a non-critical fix for something that isn't used right now?

This is a non-critical fix and it can wait until v5.1.

Thanks

maintainer
#3 lore raw

Quoting Fabio Estevam (2019-02-05 14:35:49)

Quoted 9 lines

Hi Stephen,

Quoted 2 lines · Stephen Boyd

Do I need to fast track this into v5.0 final? Or this is a non-critical fix for something that isn't used right now?

This is a non-critical fix and it can wait until v5.1.

Alright, thanks!

author reviewer
#4 lore raw

Hi Stephen,

Quoted 6 lines · Stephen Boyd

Quoting Fabio Estevam (2019-02-05 14:35:49)

Quoted 4 lines

Hi Stephen,

On Tue, Feb 5, 2019 at 8:29 PM Stephen Boyd <[email protected]> wrote:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Do I need to fast track this into v5.0 final? Or this is a non-critical fix for something that isn't used right now?

This is a non-critical fix and it can wait until v5.1.

Alright, thanks!

Can this go to clk-next?

maintainer Applied
#5 lore raw
In reply to Fabio Estevam

Quoting Fabio Estevam (2019-01-30 11:21:02)

Quoted 14 lines

The CLKO2 clock source select list is the following as per the i.MX8M Reference Manual:

000 - 25M_REF_CLK
001 - SYSTEM_PLL2_DIV5
010 - SYSTEM_PLL1_DIV2
011 - SYSTEM_PLL2_DIV6
100 - SYSTEM_PLL3_CLK
101 - AUDIO_PLL1_CLK
110 - VIDEO_PLL1_CLK
111 - 32K_REF_CLK

However, in imx8mq_clko2_sels[] only the first four entries are correct.

Quoted 7 lines

Fix it by adding the missing "sys3_pll2_out" entry in order to match the description from the manual.

Fixes b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM")

---

Applied to clk-next