Skip to contentSkip to conversation

support/scripts/graph-build-time: add download times

PATCH New Thomas De Schampheleire 3 participants 6 messages Jan 30, 2019 – Feb 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 support/scripts/graph-build-time: add download times

From: Mathias De Mare <[email protected]>

Total build time also involves download. Getting a visibility on the impact of that step can be important for users/admins, e.g. to evaluate different methods of BR2_PRIMARY_SITE.

Colors used are some kind of purple (primary scheme) and light orange (alternate scheme).

[ThomasDS: rebase and update colors to avoid confusion]
---
 support/scripts/graph-build-time | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
support/scripts/graph-build-time +3 -3
index 892e08bf07..2fdb6a476d 100755
@@ -69,14 +69,14 @@ import matplotlib.font_manager as fm  # noqa: E402
 import csv                            # noqa: E402
 import argparse                       # noqa: E402
 
-steps = ['extract', 'patch', 'configure', 'build',
+steps = ['download', 'extract', 'patch', 'configure', 'build',
          'install-target', 'install-staging', 'install-images',
          'install-host']
 
-default_colors = ['#e60004', '#009836', '#2e1d86', '#ffed00',
+default_colors = ['#8d02ff', '#e60004', '#009836', '#2e1d86', '#ffed00',
                   '#0068b5', '#f28e00', '#940084', '#97c000']
 
-alternate_colors = ['#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
+alternate_colors = ['#ffbe0a', '#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
                     '#0080ff', '#c000ff', '#00eeee', '#e0e000']
 
 
Signature · 1 line
2.19.2
#1 lore raw

PATCH 2/2 support/scripts/graph-build-time: replace confusing colors

From: Thomas De Schampheleire <[email protected]>

The color for 'extract' is very similar to the one for 'install-images'. Both are cyan-like.

Replace the former by a pale blue to make all colors sufficiently distinct.

---
 support/scripts/graph-build-time | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/scripts/graph-build-time +1 -1
index 2fdb6a476d..ba3cdad85b 100755
@@ -76,7 +76,7 @@ steps = ['download', 'extract', 'patch', 'configure', 'build',
 default_colors = ['#8d02ff', '#e60004', '#009836', '#2e1d86', '#ffed00',
                   '#0068b5', '#f28e00', '#940084', '#97c000']
 
-alternate_colors = ['#ffbe0a', '#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
+alternate_colors = ['#ffbe0a', '#96bdff', '#3f7f7f', '#ff0000', '#00c000',
                     '#0080ff', '#c000ff', '#00eeee', '#e0e000']
 
 
Signature · 1 line
2.19.2
#2 lore raw

PATCH 2/2 support/scripts/graph-build-time: replace confusing colors

Thomas De,

Quoted 9 lines · Thomas De Schampheleire

From: Thomas De Schampheleire <[email protected]>

The color for 'extract' is very similar to the one for 'install-images'. Both are cyan-like.

Replace the former by a pale blue to make all colors sufficiently distinct.

A bit trickier to test and get a install images with enough time to visually see it :-)

#3 lore raw

PATCH 2/2 support/scripts/graph-build-time: replace confusing colors

El lun., 4 feb. 2019 a las 12:07, Matthew Weber
(<[email protected]>) escribi?:

Quoted 11 lines

Thomas De,

Quoted 6 lines · Thomas De Schampheleire

From: Thomas De Schampheleire <[email protected]>

The color for 'extract' is very similar to the one for 'install-images'. Both are cyan-like.

Quoted 6 lines
Quoted 3 lines

Replace the former by a pale blue to make all colors sufficiently distinct.

A bit trickier to test and get a install images with enough time to visually see it :-)

I spoofed the build-time.log file when testing :-)

/Thomas

#4 lore raw

PATCH 1/2 support/scripts/graph-build-time: add download times

In reply to Thomas De Schampheleire

Thomas De,

Quoted 7 lines · Thomas De Schampheleire

From: Mathias De Mare <[email protected]>

Total build time also involves download. Getting a visibility on the impact of that step can be important for users/admins, e.g. to evaluate different methods of BR2_PRIMARY_SITE.

Quoted 6 lines

Colors used are some kind of purple (primary scheme) and light orange (alternate scheme).

[ThomasDS: rebase and update colors to avoid confusion]

Cool stat :-) This will be interesting to run and see what is not hitting my caching server vs raw Internet.

#5 lore raw

PATCH 1/2 support/scripts/graph-build-time: add download times

In reply to Thomas De Schampheleire
Quoted 6 lines · Thomas De Schampheleire

From: Mathias De Mare <[email protected]>

Total build time also involves download. Getting a visibility on the impact of that step can be important for users/admins, e.g. to evaluate different methods of BR2_PRIMARY_SITE.

Quoted 6 lines

Colors used are some kind of purple (primary scheme) and light orange (alternate scheme).

[ThomasDS: rebase and update colors to avoid confusion]

Both applied to master, thanks.

Regards,
Arnout

Quoted 27 lines
---
 support/scripts/graph-build-time | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
support/scripts/graph-build-time +3 -3
index 892e08bf07..2fdb6a476d 100755
@@ -69,14 +69,14 @@ import matplotlib.font_manager as fm  # noqa: E402
 import csv                            # noqa: E402
 import argparse                       # noqa: E402
 
-steps = ['extract', 'patch', 'configure', 'build',
+steps = ['download', 'extract', 'patch', 'configure', 'build',
          'install-target', 'install-staging', 'install-images',
          'install-host']
 
-default_colors = ['#e60004', '#009836', '#2e1d86', '#ffed00',
+default_colors = ['#8d02ff', '#e60004', '#009836', '#2e1d86', '#ffed00',
                   '#0068b5', '#f28e00', '#940084', '#97c000']
 
-alternate_colors = ['#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
+alternate_colors = ['#ffbe0a', '#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
                     '#0080ff', '#c000ff', '#00eeee', '#e0e000']