CRTC background color
Subsystems (4)
cover CRTC background color
Previous patch series was here:
https://lists.freedesktop.org/archives/dri-devel/2018-December/201949.html
I'm told the ChromeOS userspace code to make use of the background color has been reviewed and is ready for use:
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
So I think ABI-wise we've met the userspace consumer requirements to upstream this; we just need to get reviews on the two i915-specific patches and a clean CI report.
v4.1 is identical to v4 aside from a rebase onto the latest drm-tip.
Matt Roper (3):
drm/i915: Force background color to black for gen9+ (v2)
drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4)
drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 +++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 +++++ drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 6 +++++ drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++++++++++++++++++++++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 +++++++++++++++++++++++ 10 files changed, 138 insertions(+), 3 deletions(-)
Signature · 6 lines
2.14.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/3 drm/i915: Force background color to black for gen9+ (v2)
We don't yet allow userspace to control the CRTC background color, but we should manually program the color to black to ensure the BIOS didn't leave us with some other color. We should also set the pipe gamma and pipe CSC bits so that the background color goes through the same color management transformations that a plane with black pixels would.
v2: Rename register to SKL_BOTTOM_COLOR to more closely follow
bspec naming. (Ville)
--- drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ 2 files changed, 25 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +6 -0
@@ -5710,6 +5710,12 @@ enum {#define PIPEMISC_DITHER_TYPE_SP (0 << 2)#define PIPEMISC (pipe) _MMIO_PIPE2(pipe, _PIPE_MISC_A) +/* Skylake+ pipe bottom (background) color */ +#define _SKL_BOTTOM_COLOR_A 0x70034 +#define SKL_BOTTOM_COLOR_GAMMA_ENABLE (1 << 31) +#define SKL_BOTTOM_COLOR_CSC_ENABLE (1 << 30) +#define SKL_BOTTOM_COLOR (pipe) _MMIO_PIPE2(pipe, _SKL_BOTTOM_COLOR_A) +#define VLV_DPFLIPSTAT _MMIO(VLV_DISPLAY_BASE + 0x70028)#define PIPEB_LINE_COMPARE_INT_EN (1 << 29)#define PIPEB_HLINE_INT_EN (1 << 28)
drivers/gpu/drm/i915/intel_display.c +19 -0
@@ -3930,6 +3930,16 @@ static void intel_update_pipe_config(const struct intel_crtc_state *old_crtc_staelse if (old_crtc_state->pch_pfit.enabled)ironlake_pfit_disable (old_crtc_state); } + +/* +* We don't (yet) allow userspace to control the pipe background color, +* so force it to black, but apply pipe gamma and CSC so that its +* handling will match how we program our planes. +*/ +if (INTEL_GEN (dev_priv) >=9 ) +I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), +SKL_BOTTOM_COLOR_GAMMA_ENABLE | +SKL_BOTTOM_COLOR_CSC_ENABLE ); }static void intel_fdi_normal_train (struct intel_crtc *crtc)
@@ -15488,6 +15498,15 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc, plane->base.type != DRM_PLANE_TYPE_PRIMARY)intel_plane_disable_noatomic (crtc, plane); } + +/* +* Disable any background color set by the BIOS, but enable the +* gamma and CSC to match how we program our planes. +*/ +if (INTEL_GEN (dev_priv) >=9 ) +I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), +SKL_BOTTOM_COLOR_GAMMA_ENABLE | +SKL_BOTTOM_COLOR_CSC_ENABLE ); }/* Adjust the state of the output pipe according to whether we
Signature · 6 lines
2.14.5 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4.1 1/3] drm/i915: Force background color to black for gen9+ (v2)
Quoted 11 lines · Matt Roper
We don't yet allow userspace to control the CRTC background color, but we should manually program the color to black to ensure the BIOS didn't leave us with some other color. We should also set the pipe gamma and pipe CSC bits so that the background color goes through the same color management transformations that a plane with black pixels would.
v2: Rename register to
SKL_BOTTOM_COLORto more closely follow
bspec naming. (Ville)Cc Ville Syrjälä <[email protected]>Signed-off-by Matt Roper <[email protected]>
Quoted 61 lines
--- drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ 2 files changed, 25 insertions(+)drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -5710,6 +5710,12 @@ enum {#define PIPEMISC_DITHER_TYPE_SP (0 << 2)#define PIPEMISC (pipe) _MMIO_PIPE2(pipe, _PIPE_MISC_A) +/* Skylake+ pipe bottom (background) color */ +#define _SKL_BOTTOM_COLOR_A 0x70034 +#define SKL_BOTTOM_COLOR_GAMMA_ENABLE (1 << 31) +#define SKL_BOTTOM_COLOR_CSC_ENABLE (1 << 30) +#define SKL_BOTTOM_COLOR (pipe) _MMIO_PIPE2(pipe, _SKL_BOTTOM_COLOR_A) +#define VLV_DPFLIPSTAT _MMIO(VLV_DISPLAY_BASE + 0x70028)#define PIPEB_LINE_COMPARE_INT_EN (1 << 29)#define PIPEB_HLINE_INT_EN (1 << 28)drivers/gpu/drm/i915/intel_display.c +19
-0@@ -3930,6 +3930,16 @@ static void intel_update_pipe_config(const struct intel_crtc_state *old_crtc_staelse if (old_crtc_state->pch_pfit.enabled)ironlake_pfit_disable (old_crtc_state); } + +/* +* We don't (yet) allow userspace to control the pipe background color, +* so force it to black, but apply pipe gamma and CSC so that its +* handling will match how we program our planes. +*/ +if (INTEL_GEN (dev_priv) >=9 ) +I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), +SKL_BOTTOM_COLOR_GAMMA_ENABLE | +SKL_BOTTOM_COLOR_CSC_ENABLE ); }static void intel_fdi_normal_train (struct intel_crtc *crtc)@@ -15488,6 +15498,15 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc, plane->base.type != DRM_PLANE_TYPE_PRIMARY)intel_plane_disable_noatomic (crtc, plane); } + +/* +* Disable any background color set by the BIOS, but enable the +* gamma and CSC to match how we program our planes. +*/ +if (INTEL_GEN (dev_priv) >=9 ) +I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), +SKL_BOTTOM_COLOR_GAMMA_ENABLE | +SKL_BOTTOM_COLOR_CSC_ENABLE ); }/* Adjust the state of the output pipe according to whether we Signature · 1 line
2.14.5
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v4.1 1/3] drm/i915: Force background color to black for gen9+ (v2)
Quoted 7 lines · Ville Syrjälä
Quoted 6 lines · Matt Roper
We don't yet allow userspace to control the CRTC background color, but we should manually program the color to black to ensure the BIOS didn't leave us with some other color. We should also set the pipe gamma and pipe CSC bits so that the background color goes through the same color management transformations that a plane with black pixels would.
Quoted 7 lines
Quoted 5 lines
v2: Rename register to
SKL_BOTTOM_COLORto more closely follow
bspec naming. (Ville)Cc Ville Syrjälä <[email protected]>Signed-off-by Matt Roper <[email protected]>Reviewed-by Ville Syrjälä <[email protected]>
Applied just this first patch to dinq since it's a bugfix and doesn't impact the ABI that comes in the later patches. Thanks for the review.
Matt
Quoted 66 lines
Quoted 62 lines
--- drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ 2 files changed, 25 insertions(+)drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -5710,6 +5710,12 @@ enum {#define PIPEMISC_DITHER_TYPE_SP (0 << 2)#define PIPEMISC (pipe) _MMIO_PIPE2(pipe, _PIPE_MISC_A) +/* Skylake+ pipe bottom (background) color */ +#define _SKL_BOTTOM_COLOR_A 0x70034 +#define SKL_BOTTOM_COLOR_GAMMA_ENABLE (1 << 31) +#define SKL_BOTTOM_COLOR_CSC_ENABLE (1 << 30) +#define SKL_BOTTOM_COLOR (pipe) _MMIO_PIPE2(pipe, _SKL_BOTTOM_COLOR_A) +#define VLV_DPFLIPSTAT _MMIO(VLV_DISPLAY_BASE + 0x70028)#define PIPEB_LINE_COMPARE_INT_EN (1 << 29)#define PIPEB_HLINE_INT_EN (1 << 28)drivers/gpu/drm/i915/intel_display.c +19
-0@@ -3930,6 +3930,16 @@ static void intel_update_pipe_config(const struct intel_crtc_state *old_crtc_staelse if (old_crtc_state->pch_pfit.enabled)ironlake_pfit_disable (old_crtc_state); } + +/* +* We don't (yet) allow userspace to control the pipe background color, +* so force it to black, but apply pipe gamma and CSC so that its +* handling will match how we program our planes. +*/ +if (INTEL_GEN (dev_priv) >=9 ) +I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), +SKL_BOTTOM_COLOR_GAMMA_ENABLE | +SKL_BOTTOM_COLOR_CSC_ENABLE ); }static void intel_fdi_normal_train (struct intel_crtc *crtc)@@ -15488,6 +15498,15 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc, plane->base.type != DRM_PLANE_TYPE_PRIMARY)intel_plane_disable_noatomic (crtc, plane); } + +/* +* Disable any background color set by the BIOS, but enable the +* gamma and CSC to match how we program our planes. +*/ +if (INTEL_GEN (dev_priv) >=9 ) +I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), +SKL_BOTTOM_COLOR_GAMMA_ENABLE | +SKL_BOTTOM_COLOR_CSC_ENABLE ); }/* Adjust the state of the output pipe according to whether we Signature · 1 line
2.14.5Signature · 2 lines
Ville Syrjälä Intel
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 drm: Add CRTC background color property (v4)
In reply to Matt RoperSome display controllers can be programmed to present non-black colors for pixels not covered by any plane (or pixels covered by the transparent regions of higher planes). Compositors that want a UI with a solid color background can potentially save memory bandwidth by setting the CRTC background property and using smaller planes to display the rest of the content.
To avoid confusion between different ways of encoding RGB data, we define a standard 64-bit format that should be used for this property's value. Helper functions and macros are provided to generate and dissect values in this standard format with varying component precision values.
v2:
- Swap internal representation's blue and red bits to make it easier to read if printed out. (Ville)
- Document bgcolor property in drm_blend.c. (Sean Paul)
- s/background_color/bgcolor/ for consistency between property name and value storage field. (Sean Paul)
- Add a convenience function to attach property to a given crtc.
v3:
- Restructure ARGB component extraction macros to be easier to understand and enclose the parameters in () to avoid calculations if expressions are passed. (Sean Paul)
- s/rgba/argb/ in helper function/macro names. Even though the idea is to not worry about the internal representation of the u64, it can still be confusing to look at code that uses 'rgba' terminology, but stores values with argb ordering. (Ville)
v4:
- Drop the bgcolor_changed flag. (Ville, Brian Starkey)
- Clarify in kerneldoc that background color is expected to undergo the same pipe-level degamma/csc/gamma transformations that planes do. (Brian Starkey)
- Update kerneldoc to indicate non-opaque colors are allowed, but are generally only useful in special cases such as when writeback connectors are used (Brian Starkey / Eric Anholt)
Reviewed-by(v2): Sean Paul <[email protected]>
--- drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 ++++++++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 ++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 ++++++++++++++++++++++++++++ 7 files changed, 80 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_atomic_uapi.c +4 -0
@@ -469,6 +469,8 @@ static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,return -EFAULT ;set_out_fence_for_crtc (state->state, crtc, fence_ptr); + }else if (property == config->bgcolor_property) { + state->bgcolor = val; }else if (crtc->funcs->atomic_set_property) {return crtc->funcs->atomic_set_property (crtc, state, property, val); }else {
@@ -503,6 +505,8 @@ drm_atomic_crtc_get_property(struct drm_crtc *crtc, *val = (state->gamma_lut) ? state->gamma_lut->base.id :0 ; else if (property == config->prop_out_fence_ptr) *val = 0; + else if (property == config->bgcolor_property) + *val = state->bgcolor; else if (crtc->funcs->atomic_get_property) return crtc->funcs->atomic_get_property(crtc, state, property, val); else
drivers/gpu/drm/drm_blend.c +24 -3
@@ -175,9 +175,22 @@* plane does not expose the "alpha" property, then this is * assumed to be 1.0 * -* Note that all the property extensions described here apply either to the -* plane or the CRTC (e.g. for the background color, which currently is not -* exposed and assumed to be black). +* The property extensions described above all apply to the plane. Drivers +* may also expose the following crtc property extension: +* +* BACKGROUND_COLOR: +* Background color is setup with drm_crtc_add_bgcolor_property(). It +* controls the ARGB color of a full-screen layer that exists below all +* planes. This color will be used for pixels not covered by any plane +* and may also be blended with plane contents as allowed by a plane's +* alpha values. The background color defaults to black, and is assumed +* to be black for drivers that do not expose this property. Although +* background color isn't a plane, it is assumed that the color provided +* here undergoes the same pipe-level degamma/CSC/gamma transformations +* that planes undergo. Note that the color value provided here includes +* an alpha channel...non-opaque background color values are allowed, +* but are generally only honored in special cases (e.g., when a memory +* writeback connector is in use). */ /**
@@ -593,3 +606,11 @@ int drm_plane_create_blend_mode_property(struct drm_plane *plane,return 0 ; }EXPORT_SYMBOL (drm_plane_create_blend_mode_property); + +void drm_crtc_add_bgcolor_property (struct drm_crtc *crtc) +{ +drm_object_attach_property (&crtc->base, + crtc->dev->mode_config.bgcolor_property, +drm_argb (16 ,0xffff ,0 ,0 ,0 )); +} +EXPORT_SYMBOL (drm_crtc_add_bgcolor_property);
drivers/gpu/drm/drm_mode_config.c +6 -0
@@ -364,6 +364,12 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)return -ENOMEM ; dev->mode_config.modifiers_property = prop; + prop =drm_property_create_range (dev,0 ,"BACKGROUND_COLOR" , +0 ,GENMASK_ULL (63 ,0 )); +if (!prop) +return -ENOMEM ; + dev->mode_config.bgcolor_property = prop; +return 0 ; }
include/drm/drm_blend.h +1 -0
@@ -58,4 +58,5 @@ int drm_atomic_normalize_zpos(struct drm_device *dev, struct drm_atomic_state *state);int drm_plane_create_blend_mode_property (struct drm_plane *plane,unsigned int supported_modes); +void drm_crtc_add_bgcolor_property (struct drm_crtc *crtc);#endif
include/drm/drm_crtc.h +12 -0
@@ -274,6 +274,18 @@ struct drm_crtc_state {*/ struct drm_property_blob *gamma_lut; +/** +* @bgcolor: +* +* RGB value representing the pipe's background color. The background +* color (aka "canvas color") of a pipe is the color that will be used +* for pixels not covered by a plane, or covered by transparent pixels +* of a plane. The value here should be built via drm_argb(); +* individual color components can be extracted with desired precision +* via the DRM_ARGB_*() macros. +*/ +u64 bgcolor; +/** * @target_vblank: *
include/drm/drm_mode_config.h +5 -0
@@ -836,6 +836,11 @@ struct drm_mode_config {*/ struct drm_property *writeback_out_fence_ptr_property; +/** +* @bgcolor_property: RGB background color for CRTC. +*/ +struct drm_property *bgcolor_property; +/* dumb ioctl parameters */ uint32_t preferred_depth, prefer_shadow;
include/uapi/drm/drm_mode.h +28 -0
@@ -907,6 +907,34 @@ struct drm_mode_rect {__s32 y2; }; +/* +* Put ARGB values into a standard 64-bit representation that can be used +* for ioctl parameters, inter-driver commmunication, etc. If the component +* values being provided contain less than 16 bits of precision, they'll +* be shifted into the most significant bits. +*/ +static inline __u64 +drm_argb (__u8 bpc,__u16 alpha,__u16 red,__u16 green,__u16 blue) +{ +int msb_shift =16 - bpc; + +return (__u64 )alpha << msb_shift <<48 | + (__u64 )red << msb_shift <<32 | + (__u64 )green << msb_shift <<16 | + (__u64 )blue << msb_shift; +} + +/* +* Extract the specified number of bits of a specific color component from a +* standard 64-bit ARGB value. +*/ +#define DRM_ARGB_COMP (c, shift, numbits) \ + (__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits))) +#define DRM_ARGB_BLUE (c, numbits) DRM_ARGB_COMP(c, 0, numbits) +#define DRM_ARGB_GREEN (c, numbits) DRM_ARGB_COMP(c, 16, numbits) +#define DRM_ARGB_RED (c, numbits) DRM_ARGB_COMP(c, 32, numbits) +#define DRM_ARGB_ALPHA (c, numbits) DRM_ARGB_COMP(c, 48, numbits) +#if defined(__cplusplus) }#endif
Signature · 6 lines
2.14.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v4.1 2/3] drm: Add CRTC background color property (v4)
Quoted 99 lines · Matt Roper
Some display controllers can be programmed to present non-black colors for pixels not covered by any plane (or pixels covered by the transparent regions of higher planes). Compositors that want a UI with a solid color background can potentially save memory bandwidth by setting the CRTC background property and using smaller planes to display the rest of the content.
To avoid confusion between different ways of encoding RGB data, we define a standard 64-bit format that should be used for this property's value. Helper functions and macros are provided to generate and dissect values in this standard format with varying component precision values.
v2:
- Swap internal representation's blue and red bits to make it easier to read if printed out. (Ville)
- Document bgcolor property indrm_blend.c. (Sean Paul)
- s/background_color/bgcolor/ for consistency between property name and value storage field. (Sean Paul)
- Add a convenience function to attach property to a given crtc.v3:
- Restructure ARGB component extraction macros to be easier to understand and enclose the parameters in () to avoid calculations if expressions are passed. (Sean Paul)
- s/rgba/argb/ in helper function/macro names. Even though the idea is to not worry about the internal representation of the u64, it can still be confusing to look at code that uses 'rgba' terminology, but stores values with argb ordering. (Ville)v4:
- Drop thebgcolor_changedflag. (Ville, Brian Starkey)
- Clarify in kerneldoc that background color is expected to undergo the same pipe-level degamma/csc/gamma transformations that planes do. (Brian Starkey)
- Update kerneldoc to indicate non-opaque colors are allowed, but are generally only useful in special cases such as when writeback connectors are used (Brian Starkey / Eric Anholt)Cc Ville Syrjälä <[email protected]>Cc Sean Paul <[email protected]>Cc Brian Starkey <[email protected]>Cc Eric Anholt <[email protected]>Cc Stéphane Marchesin <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Matt Roper <[email protected]>Reviewed-by(v2): Sean Paul <[email protected]>
Reviewed-by Brian Starkey <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 ++++++++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 ++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 ++++++++++++++++++++++++++++ 7 files changed, 80 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_atomic_uapi.c +4
-0@@ -469,6 +469,8 @@ static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,return -EFAULT ;set_out_fence_for_crtc (state->state, crtc, fence_ptr); + }else if (property == config->bgcolor_property) { + state->bgcolor = val; }else if (crtc->funcs->atomic_set_property) {return crtc->funcs->atomic_set_property (crtc, state, property, val); }else {@@ -503,6 +505,8 @@ drm_atomic_crtc_get_property(struct drm_crtc *crtc, *val = (state->gamma_lut) ? state->gamma_lut->base.id :0 ; else if (property == config->prop_out_fence_ptr) *val = 0; + else if (property == config->bgcolor_property) + *val = state->bgcolor; else if (crtc->funcs->atomic_get_property) return crtc->funcs->atomic_get_property(crtc, state, property, val); elsedrivers/gpu/drm/drm_blend.c +6
-3@@ -175,9 +175,22 @@* plane does not expose the "alpha" property, then this is * assumed to be 1.0 * -* Note that all the property extensions described here apply either to the -* plane or the CRTC (e.g. for the background color, which currently is not -* exposed and assumed to be black). +* The property extensions described above all apply to the plane. Drivers +* may also expose the following crtc property extension: +* +* BACKGROUND_COLOR: +* Background color is setup with drm_crtc_add_bgcolor_property(). It +* controls the ARGB color of a full-screen layer that exists below all
drivers/gpu/drm/drm_blend.c line 193
Quoted 10 lines
drivers/gpu/drm/drm_blend.c +10
-0+* planes. This color will be used for pixels not covered by any plane +* and may also be blended with plane contents as allowed by a plane's +* alpha values. The background color defaults to black, and is assumed +* to be black for drivers that do not expose this property. Although +* background color isn't a plane, it is assumed that the color provided +* here undergoes the same pipe-level degamma/CSC/gamma transformations +* that planes undergo. Note that the color value provided here includes +* an alpha channel...non-opaque background color values are allowed, +* but are generally only honored in special cases (e.g., when a memory +* writeback connector is in use).
What would the alpha<1.0 do in that case? Blend the writeback output with what's already there?
drivers/gpu/drm/drm_blend.c int drm_plane_create_blend_mode_property(struct drm_plane *plane, · line 614
Quoted 13 lines
drivers/gpu/drm/drm_blend.c +6
-0*/ /** @@ -593,3 +606,11 @@ int drm_plane_create_blend_mode_property(struct drm_plane *plane,return 0 ; }EXPORT_SYMBOL (drm_plane_create_blend_mode_property); + +void drm_crtc_add_bgcolor_property (struct drm_crtc *crtc) +{ +drm_object_attach_property (&crtc->base, + crtc->dev->mode_config.bgcolor_property, +drm_argb (16 ,0xffff ,0 ,0 ,0 ));
if (crtc->state)
crtc->state->bg = default value; ?
Quoted 109 lines
drivers/gpu/drm/drm_blend.c +2
-0+} +EXPORT_SYMBOL (drm_crtc_add_bgcolor_property);drivers/gpu/drm/drm_mode_config.c +6
-0@@ -364,6 +364,12 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)return -ENOMEM ; dev->mode_config.modifiers_property = prop; + prop =drm_property_create_range (dev,0 ,"BACKGROUND_COLOR" , +0 ,GENMASK_ULL (63 ,0 )); +if (!prop) +return -ENOMEM ; + dev->mode_config.bgcolor_property = prop; +return 0 ; }include/drm/drm_blend.h +1
-0@@ -58,4 +58,5 @@ int drm_atomic_normalize_zpos(struct drm_device *dev, struct drm_atomic_state *state);int drm_plane_create_blend_mode_property (struct drm_plane *plane,unsigned int supported_modes); +void drm_crtc_add_bgcolor_property (struct drm_crtc *crtc);#endif include/drm/drm_crtc.h +12
-0@@ -274,6 +274,18 @@ struct drm_crtc_state {*/ struct drm_property_blob *gamma_lut; +/** +* @bgcolor: +* +* RGB value representing the pipe's background color. The background +* color (aka "canvas color") of a pipe is the color that will be used +* for pixels not covered by a plane, or covered by transparent pixels +* of a plane. The value here should be built via drm_argb(); +* individual color components can be extracted with desired precision +* via the DRM_ARGB_*() macros. +*/ +u64 bgcolor; +/** * @target_vblank: * include/drm/drm_mode_config.h +5
-0@@ -836,6 +836,11 @@ struct drm_mode_config {*/ struct drm_property *writeback_out_fence_ptr_property; +/** +* @bgcolor_property: RGB background color for CRTC. +*/ +struct drm_property *bgcolor_property; +/* dumb ioctl parameters */ uint32_t preferred_depth, prefer_shadow;include/uapi/drm/drm_mode.h +28
-0@@ -907,6 +907,34 @@ struct drm_mode_rect {__s32 y2; }; +/* +* Put ARGB values into a standard 64-bit representation that can be used +* for ioctl parameters, inter-driver commmunication, etc. If the component +* values being provided contain less than 16 bits of precision, they'll +* be shifted into the most significant bits. +*/ +static inline __u64 +drm_argb (__u8 bpc,__u16 alpha,__u16 red,__u16 green,__u16 blue) +{ +int msb_shift =16 - bpc; + +return (__u64 )alpha << msb_shift <<48 | + (__u64 )red << msb_shift <<32 | + (__u64 )green << msb_shift <<16 | + (__u64 )blue << msb_shift; +} + +/* +* Extract the specified number of bits of a specific color component from a +* standard 64-bit ARGB value. +*/ +#define DRM_ARGB_COMP (c, shift, numbits) \ + (__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits))) +#define DRM_ARGB_BLUE (c, numbits) DRM_ARGB_COMP(c, 0, numbits) +#define DRM_ARGB_GREEN (c, numbits) DRM_ARGB_COMP(c, 16, numbits) +#define DRM_ARGB_RED (c, numbits) DRM_ARGB_COMP(c, 32, numbits) +#define DRM_ARGB_ALPHA (c, numbits) DRM_ARGB_COMP(c, 48, numbits) +#if defined(__cplusplus) }#endif Signature · 1 line
2.14.5
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4.1 2/3] drm: Add CRTC background color property (v4)
Quoted 105 lines · Ville Syrjälä
Quoted 104 lines · Matt Roper
Some display controllers can be programmed to present non-black colors for pixels not covered by any plane (or pixels covered by the transparent regions of higher planes). Compositors that want a UI with a solid color background can potentially save memory bandwidth by setting the CRTC background property and using smaller planes to display the rest of the content.
To avoid confusion between different ways of encoding RGB data, we define a standard 64-bit format that should be used for this property's value. Helper functions and macros are provided to generate and dissect values in this standard format with varying component precision values.
v2:
- Swap internal representation's blue and red bits to make it easier to read if printed out. (Ville)
- Document bgcolor property indrm_blend.c. (Sean Paul)
- s/background_color/bgcolor/ for consistency between property name and value storage field. (Sean Paul)
- Add a convenience function to attach property to a given crtc.v3:
- Restructure ARGB component extraction macros to be easier to understand and enclose the parameters in () to avoid calculations if expressions are passed. (Sean Paul)
- s/rgba/argb/ in helper function/macro names. Even though the idea is to not worry about the internal representation of the u64, it can still be confusing to look at code that uses 'rgba' terminology, but stores values with argb ordering. (Ville)v4:
- Drop thebgcolor_changedflag. (Ville, Brian Starkey)
- Clarify in kerneldoc that background color is expected to undergo the same pipe-level degamma/csc/gamma transformations that planes do. (Brian Starkey)
- Update kerneldoc to indicate non-opaque colors are allowed, but are generally only useful in special cases such as when writeback connectors are used (Brian Starkey / Eric Anholt)Cc Ville Syrjälä <[email protected]>Cc Sean Paul <[email protected]>Cc Brian Starkey <[email protected]>Cc Eric Anholt <[email protected]>Cc Stéphane Marchesin <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Matt Roper <[email protected]>Reviewed-by(v2): Sean Paul <[email protected]>
Reviewed-by Brian Starkey <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 ++++++++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 ++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 ++++++++++++++++++++++++++++ 7 files changed, 80 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_atomic_uapi.c +4
-0@@ -469,6 +469,8 @@ static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,return -EFAULT ;set_out_fence_for_crtc (state->state, crtc, fence_ptr); + }else if (property == config->bgcolor_property) { + state->bgcolor = val; }else if (crtc->funcs->atomic_set_property) {return crtc->funcs->atomic_set_property (crtc, state, property, val); }else {@@ -503,6 +505,8 @@ drm_atomic_crtc_get_property(struct drm_crtc *crtc, *val = (state->gamma_lut) ? state->gamma_lut->base.id :0 ; else if (property == config->prop_out_fence_ptr) *val = 0; + else if (property == config->bgcolor_property) + *val = state->bgcolor; else if (crtc->funcs->atomic_get_property) return crtc->funcs->atomic_get_property(crtc, state, property, val); elsedrivers/gpu/drm/drm_blend.c +11
-3@@ -175,9 +175,22 @@* plane does not expose the "alpha" property, then this is * assumed to be 1.0 * -* Note that all the property extensions described here apply either to the -* plane or the CRTC (e.g. for the background color, which currently is not -* exposed and assumed to be black). +* The property extensions described above all apply to the plane. Drivers +* may also expose the following crtc property extension: +* +* BACKGROUND_COLOR: +* Background color is setup with drm_crtc_add_bgcolor_property(). It +* controls the ARGB color of a full-screen layer that exists below all +* planes. This color will be used for pixels not covered by any plane +* and may also be blended with plane contents as allowed by a plane's +* alpha values. The background color defaults to black, and is assumed +* to be black for drivers that do not expose this property. Although +* background color isn't a plane, it is assumed that the color provided
Quoted 8 lines
drivers/gpu/drm/drm_blend.c line 193
Quoted 5 lines
drivers/gpu/drm/drm_blend.c +5
-0+* here undergoes the same pipe-level degamma/CSC/gamma transformations +* that planes undergo. Note that the color value provided here includes +* an alpha channel...non-opaque background color values are allowed, +* but are generally only honored in special cases (e.g., when a memory +* writeback connector is in use). What would the alpha<1.0 do in that case? Blend the writeback output with what's already there?
I think it's more for cases where your hardware's pipe writes back actual ARGB data to memory, including an alpha component, rather than just RGB or XRGB. You could then take that ARGB writeback buffer and pass it through some other form of useful compositing if the bgcolor pixels have a non-opaque alpha.
Matt
Quoted 131 lines
Quoted 5 lines
drivers/gpu/drm/drm_blend.c +0
-0*/ /** drivers/gpu/drm/drm_blend.c int drm_plane_create_blend_mode_property(struct drm_plane *plane, · line 614
Quoted 9 lines
drivers/gpu/drm/drm_blend.c +6
-0@@ -593,3 +606,11 @@ int drm_plane_create_blend_mode_property(struct drm_plane *plane,return 0 ; }EXPORT_SYMBOL (drm_plane_create_blend_mode_property); + +void drm_crtc_add_bgcolor_property (struct drm_crtc *crtc) +{ +drm_object_attach_property (&crtc->base, + crtc->dev->mode_config.bgcolor_property, +drm_argb (16 ,0xffff ,0 ,0 ,0 ));if (
crtc->state)
crtc->state->bg= default value; ?Quoted 109 lines
drivers/gpu/drm/drm_blend.c +2
-0+} +EXPORT_SYMBOL (drm_crtc_add_bgcolor_property);drivers/gpu/drm/drm_mode_config.c +6
-0@@ -364,6 +364,12 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)return -ENOMEM ; dev->mode_config.modifiers_property = prop; + prop =drm_property_create_range (dev,0 ,"BACKGROUND_COLOR" , +0 ,GENMASK_ULL (63 ,0 )); +if (!prop) +return -ENOMEM ; + dev->mode_config.bgcolor_property = prop; +return 0 ; }include/drm/drm_blend.h +1
-0@@ -58,4 +58,5 @@ int drm_atomic_normalize_zpos(struct drm_device *dev, struct drm_atomic_state *state);int drm_plane_create_blend_mode_property (struct drm_plane *plane,unsigned int supported_modes); +void drm_crtc_add_bgcolor_property (struct drm_crtc *crtc);#endif include/drm/drm_crtc.h +12
-0@@ -274,6 +274,18 @@ struct drm_crtc_state {*/ struct drm_property_blob *gamma_lut; +/** +* @bgcolor: +* +* RGB value representing the pipe's background color. The background +* color (aka "canvas color") of a pipe is the color that will be used +* for pixels not covered by a plane, or covered by transparent pixels +* of a plane. The value here should be built via drm_argb(); +* individual color components can be extracted with desired precision +* via the DRM_ARGB_*() macros. +*/ +u64 bgcolor; +/** * @target_vblank: * include/drm/drm_mode_config.h +5
-0@@ -836,6 +836,11 @@ struct drm_mode_config {*/ struct drm_property *writeback_out_fence_ptr_property; +/** +* @bgcolor_property: RGB background color for CRTC. +*/ +struct drm_property *bgcolor_property; +/* dumb ioctl parameters */ uint32_t preferred_depth, prefer_shadow;include/uapi/drm/drm_mode.h +28
-0@@ -907,6 +907,34 @@ struct drm_mode_rect {__s32 y2; }; +/* +* Put ARGB values into a standard 64-bit representation that can be used +* for ioctl parameters, inter-driver commmunication, etc. If the component +* values being provided contain less than 16 bits of precision, they'll +* be shifted into the most significant bits. +*/ +static inline __u64 +drm_argb (__u8 bpc,__u16 alpha,__u16 red,__u16 green,__u16 blue) +{ +int msb_shift =16 - bpc; + +return (__u64 )alpha << msb_shift <<48 | + (__u64 )red << msb_shift <<32 | + (__u64 )green << msb_shift <<16 | + (__u64 )blue << msb_shift; +} + +/* +* Extract the specified number of bits of a specific color component from a +* standard 64-bit ARGB value. +*/ +#define DRM_ARGB_COMP (c, shift, numbits) \ + (__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits))) +#define DRM_ARGB_BLUE (c, numbits) DRM_ARGB_COMP(c, 0, numbits) +#define DRM_ARGB_GREEN (c, numbits) DRM_ARGB_COMP(c, 16, numbits) +#define DRM_ARGB_RED (c, numbits) DRM_ARGB_COMP(c, 32, numbits) +#define DRM_ARGB_ALPHA (c, numbits) DRM_ARGB_COMP(c, 48, numbits) +#if defined(__cplusplus) }#endif Signature · 1 line
2.14.5Signature · 2 lines
Ville Syrjälä Intel
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v4.1 2/3] drm: Add CRTC background color property (v4)
Quoted 115 lines · Matt Roper
Quoted 105 lines · Ville Syrjälä
Quoted 104 lines · Matt Roper
Some display controllers can be programmed to present non-black colors for pixels not covered by any plane (or pixels covered by the transparent regions of higher planes). Compositors that want a UI with a solid color background can potentially save memory bandwidth by setting the CRTC background property and using smaller planes to display the rest of the content.
To avoid confusion between different ways of encoding RGB data, we define a standard 64-bit format that should be used for this property's value. Helper functions and macros are provided to generate and dissect values in this standard format with varying component precision values.
v2:
- Swap internal representation's blue and red bits to make it easier to read if printed out. (Ville)
- Document bgcolor property indrm_blend.c. (Sean Paul)
- s/background_color/bgcolor/ for consistency between property name and value storage field. (Sean Paul)
- Add a convenience function to attach property to a given crtc.v3:
- Restructure ARGB component extraction macros to be easier to understand and enclose the parameters in () to avoid calculations if expressions are passed. (Sean Paul)
- s/rgba/argb/ in helper function/macro names. Even though the idea is to not worry about the internal representation of the u64, it can still be confusing to look at code that uses 'rgba' terminology, but stores values with argb ordering. (Ville)v4:
- Drop thebgcolor_changedflag. (Ville, Brian Starkey)
- Clarify in kerneldoc that background color is expected to undergo the same pipe-level degamma/csc/gamma transformations that planes do. (Brian Starkey)
- Update kerneldoc to indicate non-opaque colors are allowed, but are generally only useful in special cases such as when writeback connectors are used (Brian Starkey / Eric Anholt)Cc Ville Syrjälä <[email protected]>Cc Sean Paul <[email protected]>Cc Brian Starkey <[email protected]>Cc Eric Anholt <[email protected]>Cc Stéphane Marchesin <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Matt Roper <[email protected]>Reviewed-by(v2): Sean Paul <[email protected]>
Reviewed-by Brian Starkey <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 ++++++++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 ++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 ++++++++++++++++++++++++++++ 7 files changed, 80 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_atomic_uapi.c +4
-0@@ -469,6 +469,8 @@ static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,return -EFAULT ;set_out_fence_for_crtc (state->state, crtc, fence_ptr); + }else if (property == config->bgcolor_property) { + state->bgcolor = val; }else if (crtc->funcs->atomic_set_property) {return crtc->funcs->atomic_set_property (crtc, state, property, val); }else {@@ -503,6 +505,8 @@ drm_atomic_crtc_get_property(struct drm_crtc *crtc, *val = (state->gamma_lut) ? state->gamma_lut->base.id :0 ; else if (property == config->prop_out_fence_ptr) *val = 0; + else if (property == config->bgcolor_property) + *val = state->bgcolor; else if (crtc->funcs->atomic_get_property) return crtc->funcs->atomic_get_property(crtc, state, property, val); elsedrivers/gpu/drm/drm_blend.c +11
-3@@ -175,9 +175,22 @@* plane does not expose the "alpha" property, then this is * assumed to be 1.0 * -* Note that all the property extensions described here apply either to the -* plane or the CRTC (e.g. for the background color, which currently is not -* exposed and assumed to be black). +* The property extensions described above all apply to the plane. Drivers +* may also expose the following crtc property extension: +* +* BACKGROUND_COLOR: +* Background color is setup with drm_crtc_add_bgcolor_property(). It +* controls the ARGB color of a full-screen layer that exists below all +* planes. This color will be used for pixels not covered by any plane +* and may also be blended with plane contents as allowed by a plane's +* alpha values. The background color defaults to black, and is assumed +* to be black for drivers that do not expose this property. Although +* background color isn't a plane, it is assumed that the color provided Quoted 8 lines
drivers/gpu/drm/drm_blend.c line 193
Quoted 5 lines
drivers/gpu/drm/drm_blend.c +5
-0+* here undergoes the same pipe-level degamma/CSC/gamma transformations +* that planes undergo. Note that the color value provided here includes +* an alpha channel...non-opaque background color values are allowed, +* but are generally only honored in special cases (e.g., when a memory +* writeback connector is in use). What would the alpha<1.0 do in that case? Blend the writeback output with what's already there?
Quoted 5 lines
I think it's more for cases where your hardware's pipe writes back actual ARGB data to memory, including an alpha component, rather than just RGB or XRGB. You could then take that ARGB writeback buffer and pass it through some other form of useful compositing if the bgcolor pixels have a non-opaque alpha.
I guess someone should specify the blend equation for the alpha channel as well. I presume it should just be 'da = sa + (1-sa)*da' regardless of the plane pre-multiply setting?
Quoted 142 lines
Matt
Quoted 131 lines
Quoted 5 lines
drivers/gpu/drm/drm_blend.c +0
-0*/ /** drivers/gpu/drm/drm_blend.c int drm_plane_create_blend_mode_property(struct drm_plane *plane, · line 614
Quoted 9 lines
drivers/gpu/drm/drm_blend.c +6
-0@@ -593,3 +606,11 @@ int drm_plane_create_blend_mode_property(struct drm_plane *plane,return 0 ; }EXPORT_SYMBOL (drm_plane_create_blend_mode_property); + +void drm_crtc_add_bgcolor_property (struct drm_crtc *crtc) +{ +drm_object_attach_property (&crtc->base, + crtc->dev->mode_config.bgcolor_property, +drm_argb (16 ,0xffff ,0 ,0 ,0 ));if (
crtc->state)
crtc->state->bg= default value; ?Quoted 109 lines
drivers/gpu/drm/drm_blend.c +2
-0+} +EXPORT_SYMBOL (drm_crtc_add_bgcolor_property);drivers/gpu/drm/drm_mode_config.c +6
-0@@ -364,6 +364,12 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)return -ENOMEM ; dev->mode_config.modifiers_property = prop; + prop =drm_property_create_range (dev,0 ,"BACKGROUND_COLOR" , +0 ,GENMASK_ULL (63 ,0 )); +if (!prop) +return -ENOMEM ; + dev->mode_config.bgcolor_property = prop; +return 0 ; }include/drm/drm_blend.h +1
-0@@ -58,4 +58,5 @@ int drm_atomic_normalize_zpos(struct drm_device *dev, struct drm_atomic_state *state);int drm_plane_create_blend_mode_property (struct drm_plane *plane,unsigned int supported_modes); +void drm_crtc_add_bgcolor_property (struct drm_crtc *crtc);#endif include/drm/drm_crtc.h +12
-0@@ -274,6 +274,18 @@ struct drm_crtc_state {*/ struct drm_property_blob *gamma_lut; +/** +* @bgcolor: +* +* RGB value representing the pipe's background color. The background +* color (aka "canvas color") of a pipe is the color that will be used +* for pixels not covered by a plane, or covered by transparent pixels +* of a plane. The value here should be built via drm_argb(); +* individual color components can be extracted with desired precision +* via the DRM_ARGB_*() macros. +*/ +u64 bgcolor; +/** * @target_vblank: * include/drm/drm_mode_config.h +5
-0@@ -836,6 +836,11 @@ struct drm_mode_config {*/ struct drm_property *writeback_out_fence_ptr_property; +/** +* @bgcolor_property: RGB background color for CRTC. +*/ +struct drm_property *bgcolor_property; +/* dumb ioctl parameters */ uint32_t preferred_depth, prefer_shadow;include/uapi/drm/drm_mode.h +28
-0@@ -907,6 +907,34 @@ struct drm_mode_rect {__s32 y2; }; +/* +* Put ARGB values into a standard 64-bit representation that can be used +* for ioctl parameters, inter-driver commmunication, etc. If the component +* values being provided contain less than 16 bits of precision, they'll +* be shifted into the most significant bits. +*/ +static inline __u64 +drm_argb (__u8 bpc,__u16 alpha,__u16 red,__u16 green,__u16 blue) +{ +int msb_shift =16 - bpc; + +return (__u64 )alpha << msb_shift <<48 | + (__u64 )red << msb_shift <<32 | + (__u64 )green << msb_shift <<16 | + (__u64 )blue << msb_shift; +} + +/* +* Extract the specified number of bits of a specific color component from a +* standard 64-bit ARGB value. +*/ +#define DRM_ARGB_COMP (c, shift, numbits) \ + (__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits))) +#define DRM_ARGB_BLUE (c, numbits) DRM_ARGB_COMP(c, 0, numbits) +#define DRM_ARGB_GREEN (c, numbits) DRM_ARGB_COMP(c, 16, numbits) +#define DRM_ARGB_RED (c, numbits) DRM_ARGB_COMP(c, 32, numbits) +#define DRM_ARGB_ALPHA (c, numbits) DRM_ARGB_COMP(c, 48, numbits) +#if defined(__cplusplus) }#endif Signature · 1 line
2.14.5Signature · 2 lines
Ville Syrjälä IntelSignature · 5 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 3/3 drm/i915/gen9+: Add support for pipe background color (v4)
In reply to Matt RoperGen9+ platforms allow CRTC's to be programmed with a background/canvas color below the programmable planes. Let's expose this for use by compositors.
v2:
- Split out bgcolor sanitization and programming of csc/gamma bits to a separate patch that we can land before the ABI changes are ready to go in. (Ville)
- Change a temporary variable name to be more consistent with other similar functions. (Ville)
- Change register name to SKL_CANVAS for consistency with the CHV_CANVAS register.
v3:
- Switch register name back to SKL_BOTTOM_COLOR. (Ville)
- Use non-_FW register write. (Ville)
- Minor parameter rename for consistency. (Ville)
v4:
- Removed use of bgcolor_changed flag.
--- drivers/gpu/drm/i915/i915_debugfs.c | 9 +++++++ drivers/gpu/drm/i915/intel_display.c | 46 +++++++++++++++++++++++++++--------- 2 files changed, 44 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +9 -0
@@ -3092,6 +3092,15 @@ static int i915_display_info(struct seq_file *m, void *unused)intel_plane_info (m, crtc); } +if (INTEL_GEN (dev_priv) >=9 && pipe_config->base.active) { +uint64_t background = pipe_config->base.bgcolor; + +seq_printf (m,"\tbackground color (10bpc): r=%x g=%x b=%x\n" , +DRM_ARGB_RED (background,10 ), +DRM_ARGB_GREEN (background,10 ), +DRM_ARGB_BLUE (background,10 )); + } +seq_printf (m,"\tunderrun reporting: cpu=%s pch=%s \n" ,yesno (!crtc->cpu_fifo_underrun_disabled),yesno (!crtc->pch_fifo_underrun_disabled));
drivers/gpu/drm/i915/intel_display.c +35 -11
89 lines not on this page · raw message
Signature · 6 lines
2.14.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v4.1 3/3] drm/i915/gen9+: Add support for pipe background color (v4)
Quoted 70 lines · Matt Roper
Gen9+ platforms allow CRTC's to be programmed with a background/canvas color below the programmable planes. Let's expose this for use by compositors.
v2:
- Split out bgcolor sanitization and programming of csc/gamma bits to a separate patch that we can land before the ABI changes are ready to go in. (Ville)
- Change a temporary variable name to be more consistent with other similar functions. (Ville)
- Change register name toSKL_CANVASfor consistency with theCHV_CANVASregister.v3:
- Switch register name back toSKL_BOTTOM_COLOR. (Ville)
- Use non-_FW register write. (Ville)
- Minor parameter rename for consistency. (Ville)v4:
- Removed use ofbgcolor_changedflag.Cc Ville Syrjälä <[email protected]>Signed-off-by Matt Roper <[email protected]>--- drivers/gpu/drm/i915/i915_debugfs.c | 9 +++++++ drivers/gpu/drm/i915/intel_display.c | 46 +++++++++++++++++++++++++++--------- 2 files changed, 44 insertions(+), 11 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +9
-0@@ -3092,6 +3092,15 @@ static int i915_display_info(struct seq_file *m, void *unused)intel_plane_info (m, crtc); } +if (INTEL_GEN (dev_priv) >=9 && pipe_config->base.active) { +uint64_t background = pipe_config->base.bgcolor; + +seq_printf (m,"\tbackground color (10bpc): r=%x g=%x b=%x\n" , +DRM_ARGB_RED (background,10 ), +DRM_ARGB_GREEN (background,10 ), +DRM_ARGB_BLUE (background,10 )); + } +seq_printf (m,"\tunderrun reporting: cpu=%s pch=%s \n" ,yesno (!crtc->cpu_fifo_underrun_disabled),yesno (!crtc->pch_fifo_underrun_disabled));drivers/gpu/drm/i915/intel_display.c +11
-0@@ -3896,6 +3896,28 @@ void intel_finish_reset(struct drm_i915_private *dev_priv)clear_bit (I915_RESET_MODESET , &dev_priv->gpu_error.flags); } +static void +skl_update_background_color (const struct intel_crtc_state *crtc_state) +{ +struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +uint64_t propval = crtc_state->base.bgcolor; +uint32_t tmp; + +/* Hardware is programmed with 10 bits of precision */ + tmp =DRM_ARGB_RED (propval,10 ) <<20 + |DRM_ARGB_GREEN (propval,10 ) <<10
drivers/gpu/drm/i915/intel_display.c void intel_finish_reset(struct drm_i915_private *dev_priv) · line 3919
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +10
-0+ | DRM_ARGB_BLUE(propval, 10); + +/* +* Set CSC and gamma for bottom color to ensure background pixels +* receive the same color transformations as plane content. +*/ + tmp |=SKL_BOTTOM_COLOR_CSC_ENABLE |SKL_BOTTOM_COLOR_GAMMA_ENABLE ; + +I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), tmp); +}
Readout + state check would be nice too.
Anyways
Quoted 73 lines
drivers/gpu/drm/i915/intel_display.c +14
-11+static void intel_update_pipe_config (const struct intel_crtc_state *old_crtc_state,const struct intel_crtc_state *new_crtc_state) {@@ -3931,15 +3953,8 @@ static void intel_update_pipe_config(const struct intel_crtc_state *old_crtc_staironlake_pfit_disable (old_crtc_state); } -/* -* We don't (yet) allow userspace to control the pipe background color, -* so force it to black, but apply pipe gamma and CSC so that its -* handling will match how we program our planes. -*/ if (INTEL_GEN (dev_priv) >=9 ) -I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), -SKL_BOTTOM_COLOR_GAMMA_ENABLE | -SKL_BOTTOM_COLOR_CSC_ENABLE ); +skl_update_background_color (new_crtc_state); }static void intel_fdi_normal_train (struct intel_crtc *crtc)@@ -11042,6 +11057,8 @@ static int intel_crtc_atomic_check(struct drm_crtc *crtc,struct intel_crtc *intel_crtc =to_intel_crtc (crtc);struct intel_crtc_state *pipe_config =to_intel_crtc_state (crtc_state); +struct drm_crtc_state *old_crtc_state = +drm_atomic_get_old_crtc_state (crtc_state->state, crtc);int ret;bool mode_changed =needs_modeset (crtc_state);@@ -11069,6 +11086,9 @@ static int intel_crtc_atomic_check(struct drm_crtc *crtc, crtc_state->planes_changed = true; } +if (crtc_state->bgcolor != old_crtc_state->bgcolor) + pipe_config->update_pipe = true; + ret =0 ;if (dev_priv->display.compute_pipe_wm) { ret = dev_priv->display.compute_pipe_wm (pipe_config);@@ -14238,6 +14258,9 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)WARN_ON (drm_crtc_index (&intel_crtc->base) != intel_crtc->pipe); +if (INTEL_GEN (dev_priv) >=9 ) +drm_crtc_add_bgcolor_property (&intel_crtc->base); +return 0 ; fail:@@ -15478,6 +15501,9 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc,struct intel_crtc_state *crtc_state =to_intel_crtc_state (crtc->base.state);enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; +/* Always force bgcolor to solid black */ + crtc_state->base.bgcolor =drm_argb (16 ,0xFFFF ,0 ,0 ,0 ); +/* Clear any frame start delays used for debugging left by the BIOS */ if (crtc->active && !transcoder_is_dsi (cpu_transcoder)) {i915_reg_t reg =PIPECONF (cpu_transcoder);@@ -15504,9 +15530,7 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc,* gamma and CSC to match how we program our planes. */ if (INTEL_GEN (dev_priv) >=9 ) -I915_WRITE (SKL_BOTTOM_COLOR (crtc->pipe), -SKL_BOTTOM_COLOR_GAMMA_ENABLE | -SKL_BOTTOM_COLOR_CSC_ENABLE ); +skl_update_background_color (crtc_state); }/* Adjust the state of the output pipe according to whether we Signature · 1 line
2.14.5
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Matt Roper
Previous patch series was here:
https://lists.freedesktop.org/archives/dri-devel/2018-December/201949.htmlI'm told the ChromeOS userspace code to make use of the background color has been reviewed and is ready for use:
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
Woops, the second link here should have been to
https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1241436
which I believe is some unit tests to go along with the main userspace code.
Matt
Quoted 28 lines
So I think ABI-wise we've met the userspace consumer requirements to upstream this; we just need to get reviews on the two i915-specific patches and a clean CI report.
v4.1 is identical to v4 aside from a rebase onto the latest drm-tip.
Matt Roper (3):
drm/i915: Force background color to black for gen9+ (v2)
drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4)drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 +++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 +++++ drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 6 +++++ drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++++++++++++++++++++++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 +++++++++++++++++++++++ 10 files changed, 138 insertions(+), 3 deletions(-)Signature · 1 line
2.14.5
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Matt Roper
Quoted 7 lines · Matt Roper
Previous patch series was here:
https://lists.freedesktop.org/archives/dri-devel/2018-December/201949.htmlI'm told the ChromeOS userspace code to make use of the background color has been reviewed and is ready for use:
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
Quoted 6 lines
Woops, the second link here should have been to
https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1241436
which I believe is some unit tests to go along with the main userspace code.
Do we have this as igts too?
-Daniel
Quoted 43 lines
Matt
Quoted 28 lines
So I think ABI-wise we've met the userspace consumer requirements to upstream this; we just need to get reviews on the two i915-specific patches and a clean CI report.
v4.1 is identical to v4 aside from a rebase onto the latest drm-tip.
Matt Roper (3):
drm/i915: Force background color to black for gen9+ (v2)
drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4)drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 +++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 +++++ drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 6 +++++ drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++++++++++++++++++++++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 +++++++++++++++++++++++ 10 files changed, 138 insertions(+), 3 deletions(-)Signature · 1 line
2.14.5Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · Matt Roper
Quoted 7 lines · Matt Roper
Previous patch series was here:
https://lists.freedesktop.org/archives/dri-devel/2018-December/201949.htmlI'm told the ChromeOS userspace code to make use of the background color has been reviewed and is ready for use:
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858Woops, the second link here should have been to
Quoted 7 lines
Quoted 4 lines
https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1241436
which I believe is some unit tests to go along with the main userspace code.
Do we have this as igts too?
-Daniel
Yeah, I posted it along with some of the earlier revisions of the series, but haven't reposted the latest copy lately. I'll check and see if it needs a rebase and then post it shortly.
Unfortunately the IGT isn't as useful as I'd like it to be since the CRC's for a plane filled with a solid color never come up the same as a pure background color (at least on the APL platform I'm using). I can run the IGT in interactive mode and the colors seem identical to visual inspection, but the CRC values never agree, so I've disabled the CRC comparison in the test for now. I'm not sure if this is related to the other blending quirks of gen9; it will be interesting to see if the CRC's match on an Icelake or something.
FWIW, I've mmap'd the Cairo-generated plane framebuffer and verified that it contains exactly the pixel values we'd expect (so it's not a matter of bad roundoff in Cairo), and I've tried flipping both 8bpc and 10bpc pixel formats (to match the background color's 10 bits per component), but nothing seems to make the CRC's match. :-(
Matt
Quoted 49 lines
Quoted 44 lines
Matt
Quoted 28 lines
So I think ABI-wise we've met the userspace consumer requirements to upstream this; we just need to get reviews on the two i915-specific patches and a clean CI report.
v4.1 is identical to v4 aside from a rebase onto the latest drm-tip.
Matt Roper (3):
drm/i915: Force background color to black for gen9+ (v2)
drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4)drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 +++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 +++++ drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 6 +++++ drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++++++++++++++++++++++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 +++++++++++++++++++++++ 10 files changed, 138 insertions(+), 3 deletions(-)Signature · 1 line
2.14.5Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 1/1 tests/kms_crtc_background_color: overhaul to match upstream ABI (v4)
CRTC background color kernel patches were written about 2.5 years ago and floated on the upstream mailing list, but since no opensource userspace materialized, we never actually merged them. However the corresponding IGT test did get merged and has basically been dead code ever since.
A couple years later we finally have an open source userspace (ChromeOS), so lets update the IGT test to match the ABI that's actually going upstream and to remove some of the cruft from the original test that wouldn't actually work.
It's worth noting that we don't seem to be able to test this feature with CRC's, at least on Intel gen9. Originally we wanted to draw a color into a plane's FB (with Cairo) and then compare the CRC to turning off all planes and just setting the CRTC background to the same color. However the precision and rounding of the color components causes the CRC's to come out differently, even though the end result is visually identical. So at the moment this test is mainly useful for visual inspection in interactive mode.
v2:
- Swap red and blue ordering in property value to reflect change in v2 of kernel series.
v3:
- Minor updates to proposed uapi helpers (s/rgba/argb/).
v4:
- General restructuring into pipe/color subtests.
- Use RGB2101010 framebuffers for comparison so that we match the bits of precision that Intel hardware background color accepts
--- lib/igt_kms.c | 2 +- tests/kms_crtc_background_color.c | 262 ++++++++++++++++++-------------------- 2 files changed, 126 insertions(+), 138 deletions(-)
lib/igt_kms.c +1 -1
@@ -180,7 +180,7 @@ const char * const igt_plane_prop_names[IGT_NUM_PLANE_PROPS] = { };const char *const igt_crtc_prop_names[IGT_NUM_CRTC_PROPS ] = { - [IGT_CRTC_BACKGROUND ] ="background_color" , + [IGT_CRTC_BACKGROUND ] ="BACKGROUND_COLOR" , [IGT_CRTC_CTM ] ="CTM" , [IGT_CRTC_GAMMA_LUT ] ="GAMMA_LUT" , [IGT_CRTC_GAMMA_LUT_SIZE ] ="GAMMA_LUT_SIZE" ,
tests/kms_crtc_background_color.c +125 -137
289 lines not on this page · raw message
Signature · 6 lines
2.14.5 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [Intel-gfx] [i-g-t] tests/kms_crtc_background_color: overhaul to match upstream ABI (v4)
Am Donnerstag, 31. Januar 2019, 01:00:34 CET schrieb Matt Roper:
Quoted 34 lines
CRTC background color kernel patches were written about 2.5 years ago and floated on the upstream mailing list, but since no opensource userspace materialized, we never actually merged them. However the corresponding IGT test did get merged and has basically been dead code ever since.
A couple years later we finally have an open source userspace (ChromeOS), so lets update the IGT test to match the ABI that's actually going upstream and to remove some of the cruft from the original test that wouldn't actually work.
It's worth noting that we don't seem to be able to test this feature with CRC's, at least on Intel gen9. Originally we wanted to draw a color into a plane's FB (with Cairo) and then compare the CRC to turning off all planes and just setting the CRTC background to the same color. However the precision and rounding of the color components causes the CRC's to come out differently, even though the end result is visually identical. So at the moment this test is mainly useful for visual inspection in interactive mode.
v2:
- Swap red and blue ordering in property value to reflect change in v2 of kernel series.v3:
- Minor updates to proposed uapi helpers (s/rgba/argb/).v4:
- General restructuring into pipe/color subtests.
- Use RGB2101010 framebuffers for comparison so that we match the bits of precision that Intel hardware background color acceptsSigned-off-by Matt Roper <[email protected]>
[...]
Quoted 27 lines
tests/kms_crtc_background_color.c +4
-20+igt_main { -igt_display_t *display = &data->display; +data_t data = {};igt_output_t *output; +drmModeModeInfo *mode; +int w, h;enum pipe pipe; -int valid_tests =0 ; - -for_each_pipe_with_valid_output (display, pipe, output) { -igt_plane_t *plane; - -igt_output_set_pipe (output, pipe); - - plane =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); -igt_require (igt_pipe_has_prop (display, pipe,IGT_CRTC_BACKGROUND )); - -prepare_crtc (data, output, pipe, plane,1 ,PURPLE ,BLACK64 ); - -/* Now set background without using a plane, i.e., -* Disable the plane to let hw background color win blend. */ -igt_plane_set_fb (plane,NULL ); -igt_pipe_set_prop_value (display, pipe,IGT_CRTC_BACKGROUND ,PURPLE64 ); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); - -/* Try few other background colors */
tests/kms_crtc_background_color.c line 114
Quoted 10 lines
tests/kms_crtc_background_color.c +2
-7-igt_pipe_set_prop_value (display, pipe,IGT_CRTC_BACKGROUND ,CYAN64 ); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); - -igt_pipe_set_prop_value (display, pipe,IGT_CRTC_BACKGROUND ,YELLOW64 ); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_set_prop_value (display, pipe,IGT_CRTC_BACKGROUND ,RED64 ); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); + igt_fixture { + data.gfx_fd =drm_open_driver_master (DRIVER_INTEL );
DRIVER_ANY perhaps like in other tests?
I'm currently looking into implementing your new background-property in the Rockchip kms driver and I guess this test shouldn't contain any intel-specifics?
Heiko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_crtc_background_color: overhaul to match upstream ABI (v4)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: tests/kms_crtc_background_color: overhaul to match upstream ABI (v4)
URL : https://patchwork.freedesktop.org/series/56012/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5514 -> IGTPW_2324
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56012/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2324 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
#### Possible fixes ####
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_flip@basic-flip-vs-modeset:
- fi-skl-6700hq: DMESG-WARN [fdo#105998] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
Participating hosts (44 -> 41)
------------------------------
Missing (3): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4801 -> IGTPW_2324
CI_DRM_5514: 8a7e6109652e58be9c43e2a7a4d318a7c5b34fef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2324: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2324/
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_crtc_background_color@background-color-pipe-a-black +igt@kms_crtc_background_color@background-color-pipe-a-blue +igt@kms_crtc_background_color@background-color-pipe-a-green +igt@kms_crtc_background_color@background-color-pipe-a-red +igt@kms_crtc_background_color@background-color-pipe-a-white +igt@kms_crtc_background_color@background-color-pipe-b-black +igt@kms_crtc_background_color@background-color-pipe-b-blue +igt@kms_crtc_background_color@background-color-pipe-b-green +igt@kms_crtc_background_color@background-color-pipe-b-red +igt@kms_crtc_background_color@background-color-pipe-b-white +igt@kms_crtc_background_color@background-color-pipe-c-black +igt@kms_crtc_background_color@background-color-pipe-c-blue +igt@kms_crtc_background_color@background-color-pipe-c-green +igt@kms_crtc_background_color@background-color-pipe-c-red +igt@kms_crtc_background_color@background-color-pipe-c-white +igt@kms_crtc_background_color@background-color-pipe-d-black +igt@kms_crtc_background_color@background-color-pipe-d-blue +igt@kms_crtc_background_color@background-color-pipe-d-green +igt@kms_crtc_background_color@background-color-pipe-d-red +igt@kms_crtc_background_color@background-color-pipe-d-white +igt@kms_crtc_background_color@background-color-pipe-e-black +igt@kms_crtc_background_color@background-color-pipe-e-blue +igt@kms_crtc_background_color@background-color-pipe-e-green +igt@kms_crtc_background_color@background-color-pipe-e-red +igt@kms_crtc_background_color@background-color-pipe-e-white +igt@kms_crtc_background_color@background-color-pipe-f-black +igt@kms_crtc_background_color@background-color-pipe-f-blue +igt@kms_crtc_background_color@background-color-pipe-f-green +igt@kms_crtc_background_color@background-color-pipe-f-red +igt@kms_crtc_background_color@background-color-pipe-f-white -igt@kms_crtc_background_color
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2324/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_crtc_background_color: overhaul to match upstream ABI (v4)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: tests/kms_crtc_background_color: overhaul to match upstream ABI (v4)
URL : https://patchwork.freedesktop.org/series/56012/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5514_full -> IGTPW_2324_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2324_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_2324_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56012/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2324_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
- shard-hsw: PASS -> FAIL
Known issues
------------
Here are the changes found in IGTPW_2324_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-kbl: PASS -> FAIL [fdo#103232]
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled:
- shard-glk: PASS -> FAIL [fdo#107791]
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane@plane-position-hole-pipe-a-planes:
- shard-hsw: PASS -> DMESG-WARN [fdo#102614]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-glk: PASS -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
#### Possible fixes ####
* igt@gem_workarounds@suspend-resume:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS
- shard-glk: FAIL [fdo#106641] -> PASS
- shard-kbl: FAIL [fdo#106641] -> PASS * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#106510] / [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +6
- shard-kbl: FAIL [fdo#103166] -> PASS +2
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
#### Warnings ####
* igt@gem_exec_schedule@promotion-bsd2:
- shard-apl: {SKIP} [fdo#109271] -> INCOMPLETE [fdo#103927]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107791]: https://bugs.freedesktop.org/show_bug.cgi?id=107791
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 4)
------------------------------
Missing (3): shard-snb shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4801 -> IGTPW_2324
* Piglit: piglit_4509 -> None
CI_DRM_5514: 8a7e6109652e58be9c43e2a7a4d318a7c5b34fef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2324: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2324/
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2324/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 25 lines · Matt Roper
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · Matt Roper
Quoted 7 lines · Matt Roper
Previous patch series was here:
https://lists.freedesktop.org/archives/dri-devel/2018-December/201949.htmlI'm told the ChromeOS userspace code to make use of the background color has been reviewed and is ready for use:
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858Woops, the second link here should have been to
Quoted 7 lines
Quoted 4 lines
https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1241436
which I believe is some unit tests to go along with the main userspace code.
Do we have this as igts too?
-DanielYeah, I posted it along with some of the earlier revisions of the series, but haven't reposted the latest copy lately. I'll check and see if it needs a rebase and then post it shortly.
Quoted 8 lines
Unfortunately the IGT isn't as useful as I'd like it to be since the CRC's for a plane filled with a solid color never come up the same as a pure background color (at least on the APL platform I'm using). I can run the IGT in interactive mode and the colors seem identical to visual inspection, but the CRC values never agree, so I've disabled the CRC comparison in the test for now. I'm not sure if this is related to the other blending quirks of gen9; it will be interesting to see if the CRC's match on an Icelake or something.
Please don't do that, we need to know when stuff doesn't work. Also, igt (at least for more generic stuff like this) shouldn't be bent to exactly match intel hw bugs.
And yes if the blending is generally broken on gen9 then I'd be surprised if they managed to not screw it up for the background color. Usually backgroun color works as if it's a separate additional plane that you blend the others with.
-Daniel
Quoted 65 lines
FWIW, I've mmap'd the Cairo-generated plane framebuffer and verified that it contains exactly the pixel values we'd expect (so it's not a matter of bad roundoff in Cairo), and I've tried flipping both 8bpc and 10bpc pixel formats (to match the background color's 10 bits per component), but nothing seems to make the CRC's match. :-(
Matt
Quoted 49 lines
Quoted 44 lines
Matt
Quoted 28 lines
So I think ABI-wise we've met the userspace consumer requirements to upstream this; we just need to get reviews on the two i915-specific patches and a clean CI report.
v4.1 is identical to v4 aside from a rebase onto the latest drm-tip.
Matt Roper (3):
drm/i915: Force background color to black for gen9+ (v2)
drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4)drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 +++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 +++++ drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 6 +++++ drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++++++++++++++++++++++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 +++++++++++++++++++++++ 10 files changed, 138 insertions(+), 3 deletions(-)Signature · 1 line
2.14.5Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.chSignature · 5 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 39 lines · Daniel Vetter
Quoted 25 lines · Matt Roper
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · Matt Roper
Quoted 7 lines · Matt Roper
Previous patch series was here:
https://lists.freedesktop.org/archives/dri-devel/2018-December/201949.htmlI'm told the ChromeOS userspace code to make use of the background color has been reviewed and is ready for use:
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858
* https://chromium-review.googlesource.com/c/chromium/src/+/1278858Woops, the second link here should have been to
Quoted 7 lines
Quoted 4 lines
https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1241436
which I believe is some unit tests to go along with the main userspace code.
Do we have this as igts too?
-DanielYeah, I posted it along with some of the earlier revisions of the series, but haven't reposted the latest copy lately. I'll check and see if it needs a rebase and then post it shortly.
Quoted 8 lines
Unfortunately the IGT isn't as useful as I'd like it to be since the CRC's for a plane filled with a solid color never come up the same as a pure background color (at least on the APL platform I'm using). I can run the IGT in interactive mode and the colors seem identical to visual inspection, but the CRC values never agree, so I've disabled the CRC comparison in the test for now. I'm not sure if this is related to the other blending quirks of gen9; it will be interesting to see if the CRC's match on an Icelake or something.
Please don't do that, we need to know when stuff doesn't work. Also, igt (at least for more generic stuff like this) shouldn't be bent to exactly match intel hw bugs.
Quoted 5 lines
And yes if the blending is generally broken on gen9 then I'd be surprised if they managed to not screw it up for the background color. Usually backgroun color works as if it's a separate additional plane that you blend the others with.
-Daniel
+igt-dev list
So looking at the bspec closer, it sounds like it might not actually be valid for us to take a DMUX (pipe) CRC of just the background color. The bspec for gen9+ states
"The DMUX CRC should only be enabled when the pipe, and one or more planes in the pipe are enabled."
which implies that just using the background color (which is always on) isn't sufficient.
I'll uncomment the CRC check when we actually push the test so that it can still be used on non-Intel platforms that don't have this restriction. Should we just make the test skip on the relevant i915 platforms, or should we do something else to mark the test as an expected failure due to hardware?
Matt
Quoted 71 lines
Quoted 66 lines
FWIW, I've mmap'd the Cairo-generated plane framebuffer and verified that it contains exactly the pixel values we'd expect (so it's not a matter of bad roundoff in Cairo), and I've tried flipping both 8bpc and 10bpc pixel formats (to match the background color's 10 bits per component), but nothing seems to make the CRC's match. :-(
Matt
Quoted 49 lines
Quoted 44 lines
Matt
Quoted 28 lines
So I think ABI-wise we've met the userspace consumer requirements to upstream this; we just need to get reviews on the two i915-specific patches and a clean CI report.
v4.1 is identical to v4 aside from a rebase onto the latest drm-tip.
Matt Roper (3):
drm/i915: Force background color to black for gen9+ (v2)
drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4)drivers/gpu/drm/drm_atomic_uapi.c | 4 ++++ drivers/gpu/drm/drm_blend.c | 27 +++++++++++++++++++--- drivers/gpu/drm/drm_mode_config.c | 6 +++++ drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 6 +++++ drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++++++++++++++++++++++++++ include/drm/drm_blend.h | 1 + include/drm/drm_crtc.h | 12 ++++++++++ include/drm/drm_mode_config.h | 5 +++++ include/uapi/drm/drm_mode.h | 28 +++++++++++++++++++++++ 10 files changed, 138 insertions(+), 3 deletions(-)Signature · 1 line
2.14.5Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.chSignature · 5 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for CRTC background color (rev5)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: CRTC background color (rev5)
URL : https://patchwork.freedesktop.org/series/50834/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip a9fc702b09d5 drm/i915: Force background color to black for gen9+ (v2) 3f404502f7a1 drm: Add CRTC background color property (v4) -:219: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'shift' - possible side-effects? #219: FILE: include/uapi/drm/drm_mode.h:931: +#define DRM_ARGB_COMP(c, shift, numbits) \ + (__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits)))
total: 0 errors, 0 warnings, 1 checks, 132 lines checked f96a4d9be129 drm/i915/gen9+: Add support for pipe background color (v4) -:45: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t' #45: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3096:
+ uint64_t background = pipe_config->base.bgcolor;
-:69: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t' #69: FILE: drivers/gpu/drm/i915/intel_display.c:3904:
+ uint64_t propval = crtc_state->base.bgcolor;
-:70: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #70: FILE: drivers/gpu/drm/i915/intel_display.c:3905:
+ uint32_t tmp;
total: 0 errors, 0 warnings, 3 checks, 104 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for CRTC background color (rev5)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: CRTC background color (rev5)
URL : https://patchwork.freedesktop.org/series/50834/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5512 -> Patchwork_12096
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50834/revisions/5/mbox/
Known issues
------------
Here are the changes found in Patchwork_12096 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182]
* igt@kms_flip@basic-flip-vs-modeset:
- fi-skl-6700hq: PASS -> DMESG-WARN [fdo#105998]
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614]
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- {fi-icl-u2}: FAIL [fdo#103167] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (42 -> 41)
------------------------------
Additional (3): fi-hsw-peppy fi-gdg-551 fi-pnv-d510
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* Linux: CI_DRM_5512 -> Patchwork_12096
CI_DRM_5512: bf1da2552de642ebce4ea3f91a3259ef819b13ce @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12096: f96a4d9be129b2de9bab006d01adb14dbd80000f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f96a4d9be129 drm/i915/gen9+: Add support for pipe background color (v4) 3f404502f7a1 drm: Add CRTC background color property (v4) a9fc702b09d5 drm/i915: Force background color to black for gen9+ (v2)
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12096/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for CRTC background color (rev5)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: CRTC background color (rev5)
URL : https://patchwork.freedesktop.org/series/50834/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5512_full -> Patchwork_12096_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12096_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@runner@aborted}:
- shard-snb: NOTRUN -> FAIL
Known issues
------------
Here are the changes found in Patchwork_12096_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#105454] / [fdo#106509]
* igt@kms_flip@flip-vs-blocking-wf-vblank:
- shard-snb: PASS -> DMESG-WARN [fdo#107469]
#### Possible fixes ####
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_flip@2x-flip-vs-modeset:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-kbl: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@pm_rc6_residency@rc6-accuracy:
- shard-kbl: {SKIP} [fdo#109271] -> PASS
- shard-snb: {SKIP} [fdo#109271] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-kbl: DMESG-WARN [fdo#109244] -> INCOMPLETE [fdo#103665] / [fdo#106886]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* Linux: CI_DRM_5512 -> Patchwork_12096
CI_DRM_5512: bf1da2552de642ebce4ea3f91a3259ef819b13ce @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12096: f96a4d9be129b2de9bab006d01adb14dbd80000f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12096/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx