drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr
Subsystems (2)
PATCH 1/1 drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr
amdgpu_vm_get_task_info is called from interrupt handler and sched timeout workqueue, so it is needed to use irq version spin_lock to avoid deadlock.
Change-Id: Ifedd4b97535bf0b5d3936edd2d9688957020efd4
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +3 -2
@@ -3386,14 +3386,15 @@ void amdgpu_vm_get_task_info(struct amdgpu_device *adev, unsigned int pasid, struct amdgpu_task_info *task_info) {struct amdgpu_vm *vm; +unsigned long flags; -spin_lock (&adev->vm_manager.pasid_lock); +spin_lock_irqsave (&adev->vm_manager.pasid_lock, flags); vm =idr_find (&adev->vm_manager.pasid_idr, pasid);if (vm) *task_info = vm->task_info; -spin_unlock (&adev->vm_manager.pasid_lock); +spin_unlock_irqrestore (&adev->vm_manager.pasid_lock, flags); }/**
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Am 31.01.19 um 15:25 schrieb Yang, Philip:
Quoted 4 lines
amdgpu_vm_get_task_infois called from interrupt handler and sched timeout workqueue, so it is needed to use irq versionspin_lockto avoid deadlock.Change-Id: Ifedd4b97535bf0b5d3936edd2d9688957020efd4
Good catch, but your signed-of-by line is missing.
With that fixed the patch is Reviewed-by: Christian König <[email protected]>
Regards,
Christian.
Quoted 16 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +2
-1@@ -3386,14 +3386,15 @@ void amdgpu_vm_get_task_info(struct amdgpu_device *adev, unsigned int pasid, struct amdgpu_task_info *task_info) {struct amdgpu_vm *vm; +unsigned long flags; -spin_lock (&adev->vm_manager.pasid_lock); +spin_lock_irqsave (&adev->vm_manager.pasid_lock, flags);
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c void amdgpu_vm_get_task_info(struct amdgpu_device *adev, unsigned int pasid, · line 3400
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +1
-1vm =idr_find (&adev->vm_manager.pasid_idr, pasid);if (vm) *task_info = vm->task_info; -spin_unlock (&adev->vm_manager.pasid_lock); +spin_unlock_irqrestore (&adev->vm_manager.pasid_lock, flags); }/**
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Zeng, Oak
Reviewed-by Oak ZengThanks,
Oak
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Yang, Philip
Sent: Thursday, January 31, 2019 9:26 AM
To: [email protected]
Cc: Yang, Philip <[email protected]>
Subject: [PATCH] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr
amdgpu_vm_get_task_info is called from interrupt handler and sched timeout workqueue, so it is needed to use irq version spin_lock to avoid deadlock.
Change-Id: Ifedd4b97535bf0b5d3936edd2d9688957020efd4
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +3 -3
@@ -3386,14 +3386,15 @@ void amdgpu_vm_get_task_info(struct amdgpu_device *adev, unsigned int pasid, struct amdgpu_task_info *task_info) {struct amdgpu_vm *vm; +unsigned long flags; -spin_lock (&adev->vm_manager.pasid_lock); +spin_lock_irqsave (&adev->vm_manager.pasid_lock, flags); vm =idr_find (&adev->vm_manager.pasid_idr, pasid);if (vm) *task_info = vm->task_info; -spin_unlock (&adev->vm_manager.pasid_lock); +spin_unlock_irqrestore (&adev->vm_manager.pasid_lock, flags); }/** --
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx