Skip to contentSkip to conversation

x86: put CONFIG_{HVM, PV} under EXPERT

RFC PATCH In review Wei Liu 3 participants 4 messages Feb 1, 2019

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

RFC PATCH 1/1 x86: put CONFIG_{HVM, PV} under EXPERT

Enabling and disabling one of the two isn't tested in OSSTest yet.

---
We need to sort this out for 4.12 release.

On the one hand, exposing them seems risky.

On the other hand, if there are bugs which cause xen to wander into a path which hits BUG or ASSERT, they are problems with older releases as well. And we definitely want to make each of the two security supported in the long run.

---
 xen/arch/x86/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
xen/arch/x86/Kconfig +3 -2
index 5c2d1070b6..3e020dc629 100644
@@ -37,7 +37,8 @@ source "arch/Kconfig"
 
 config PV
 	def_bool y
-	prompt "PV support"
+	prompt "PV support" if EXPERT = "y"
+	default y
 	---help---
 	  Interfaces to support PV domains. These require guest kernel support
 	  to run as a PV guest, but don't require any specific hardware support.
@@ -68,7 +69,7 @@ config PV_LINEAR_PT
 
 config HVM
 	def_bool !PV_SHIM_EXCLUSIVE
-	prompt "HVM support"
+	prompt "HVM support" if EXPERT = "y"
 	---help---
 	  Interfaces to support HVM domains.  HVM domains require hardware
 	  virtualisation extensions (e.g. Intel VT-x, AMD SVM), but can boot
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw
Quoted 2 lines
Quoted 1 line
Quoted 1 line · On 01.02.19 at 16:43, <[email protected]> wrote:

Enabling and disabling one of the two isn't tested in OSSTest yet.

While I'm not opposed to the addition, I intentionally didn't ask for doing so when the options got introduced, not the least because of ...

xen/arch/x86/Kconfig config PV_LINEAR_PT · line 71

Quoted 4 lines
xen/arch/x86/Kconfig +0 -0
@@ -68,7 +69,7 @@ config PV_LINEAR_PT
 
 config HVM
 	def_bool !PV_SHIM_EXCLUSIVE

... this, i.e. us already wanting a supported configuration to be built and run in that mode. IOW personally I think no change is needed, and disabling either (but not both) ought to be security supported right away.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author
#2 lore raw
Quoted 9 lines · Jan Beulich
Quoted 2 lines
Quoted 1 line
Quoted 1 line · On 01.02.19 at 16:43, <[email protected]> wrote:

Enabling and disabling one of the two isn't tested in OSSTest yet.

While I'm not opposed to the addition, I intentionally didn't ask for doing so when the options got introduced, not the least because of ...

Quoted 2 lines
(quoted diff) +0 -0
@@ -68,7 +69,7 @@ config PV_LINEAR_PT
 
Quoted 7 lines

xen/arch/x86/Kconfig config PV_LINEAR_PT · line 71

Quoted 2 lines
xen/arch/x86/Kconfig +0 -0
 config HVM
 	def_bool !PV_SHIM_EXCLUSIVE

... this, i.e. us already wanting a supported configuration to be built and run in that mode. IOW personally I think no change is needed, and disabling either (but not both) ought to be security supported right away.

This is fine. Andrew also said more or less the same thing on IRC.

I just want to be sure this gets properly discussed.

This patch can be dropped now.

Wei.

Quoted 4 lines

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 15 lines · Wei Liu
Quoted 6 lines · Jan Beulich
Quoted 2 lines
Quoted 1 line
Quoted 1 line · On 01.02.19 at 16:43, <[email protected]> wrote:

Enabling and disabling one of the two isn't tested in OSSTest yet.

While I'm not opposed to the addition, I intentionally didn't ask for doing so when the options got introduced, not the least because of ...

Quoted 8 lines

xen/arch/x86/Kconfig config PV_LINEAR_PT · line 71

Quoted 4 lines
xen/arch/x86/Kconfig +0 -0
@@ -68,7 +69,7 @@ config PV_LINEAR_PT
 
 config HVM
 	def_bool !PV_SHIM_EXCLUSIVE

... this, i.e. us already wanting a supported configuration to be built and run in that mode. IOW personally I think no change is needed, and disabling either (but not both) ought to be security supported right away.

Quoted 3 lines

This is fine. Andrew also said more or less the same thing on IRC.

I just want to be sure this gets properly discussed.

I think the risk of there being an XSA hidden in here which is only applicable to Xen 4.12+ is very slim.  I expect that any breakage from this would be around domaincreate and therefore a control-plain operation.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel