Input: gpio-keys - Add shutdown callback
Subsystems (2)
PATCH 1/1 Input: gpio-keys - Add shutdown callback
On some platforms (e.g.: ARCH_BRCMSTB) it is possible to enter "poweroff" while leaving some wake-up sources enabled such as key presses in order to allow for the system to wake-up.
Wire up a .shutdown() callback which calls into the existing gpio_keys_suspend() since the logic is essentially the same.
--- drivers/input/keyboard/gpio_keys.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/input/keyboard/gpio_keys.c +10 -0
@@ -1015,8 +1015,18 @@ static int __maybe_unused gpio_keys_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(gpio_keys_pm_ops, gpio_keys_suspend, gpio_keys_resume); +static void gpio_keys_shutdown (struct platform_device *pdev) +{ +int ret; + + ret =gpio_keys_suspend (&pdev->dev); +if (ret) +dev_err (&pdev->dev,"failed to shutdown\n" ); +} +static struct platform_driver gpio_keys_device_driver = { .probe = gpio_keys_probe, + .shutdown = gpio_keys_shutdown, .driver = { .name ="gpio-keys" , .pm = &gpio_keys_pm_ops,
Signature · 1 line
2.17.1
Quoted 11 lines · Florian Fainelli
On some platforms (e.g.:
ARCH_BRCMSTB) it is possible to enter "poweroff" while leaving some wake-up sources enabled such as key presses in order to allow for the system to wake-up.Wire up a .shutdown() callback which calls into the existing
gpio_keys_suspend()since the logic is essentially the same.Signed-off-by Florian Fainelli <[email protected]>--- drivers/input/keyboard/gpio_keys.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
Any feedback on this?
Quoted 25 lines
drivers/input/keyboard/gpio_keys.c +10
-0@@ -1015,8 +1015,18 @@ static int __maybe_unused gpio_keys_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(gpio_keys_pm_ops, gpio_keys_suspend, gpio_keys_resume); +static void gpio_keys_shutdown (struct platform_device *pdev) +{ +int ret; + + ret =gpio_keys_suspend (&pdev->dev); +if (ret) +dev_err (&pdev->dev,"failed to shutdown\n" ); +} +static struct platform_driver gpio_keys_device_driver = { .probe = gpio_keys_probe, + .shutdown = gpio_keys_shutdown, .driver = { .name ="gpio-keys" , .pm = &gpio_keys_pm_ops,
Signature · 1 line
Florian
Dmitry Torokhov
maintainerQuoted 8 lines · Florian Fainelli
Quoted 7 lines · Florian Fainelli
On some platforms (e.g.:
ARCH_BRCMSTB) it is possible to enter "poweroff" while leaving some wake-up sources enabled such as key presses in order to allow for the system to wake-up.Wire up a .shutdown() callback which calls into the existing
gpio_keys_suspend()since the logic is essentially the same.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Florian Fainelli <[email protected]>--- drivers/input/keyboard/gpio_keys.c | 10 ++++++++++ 1 file changed, 10 insertions(+)Any feedback on this?
OK, I'll take it. Hopefully it won't affect existing systems as the change is unconditional.
Thanks.
Signature · 1 line
Dmitry