Skip to contentSkip to conversation

mm: migrate: make buffer_migrate_page_norefs() actually succeed

PATCH New [email protected] 1 participant 1 message Feb 1, 2019

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 7/24 mm: migrate: make buffer_migrate_page_norefs() actually succeed

From: Jan Kara <[email protected]>
Subject: mm: migrate: make buffer_migrate_page_norefs() actually succeed

Currently, buffer_migrate_page_norefs() was constantly failing because buffer_migrate_lock_buffers() grabbed reference on each buffer. In fact, there's no reason for buffer_migrate_lock_buffers() to grab any buffer references as the page is locked during all our operation and thus nobody can reclaim buffers from the page. So remove grabbing of buffer references which also makes buffer_migrate_page_norefs() succeed.

Fixes 89cb0888ca14 "mm: migrate: provide buffer_migrate_page_norefs()"
Cc Sergey Senozhatsky <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc David Rientjes <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Zi Yan <[email protected]>
Cc Johannes Weiner <[email protected]>

---

 mm/migrate.c |    5 -----
 1 file changed, 5 deletions(-)
mm/migrate.c renamed from mm/migrate.c~mm-migrate-make-buffer_migrate_page_norefs-actually-succeed +0 -5
@@ -709,7 +709,6 @@ static bool buffer_migrate_lock_buffers(
 	/* Simple case, sync compaction */
 	if (mode != MIGRATE_ASYNC) {
 		do {
-			get_bh(bh);
 			lock_buffer(bh);
 			bh = bh->b_this_page;
 
@@ -720,18 +719,15 @@ static bool buffer_migrate_lock_buffers(
 
 	/* async case, we cannot block on lock_buffer so use trylock_buffer */
 	do {
-		get_bh(bh);
 		if (!trylock_buffer(bh)) {
 			/*
 			 * We failed to lock the buffer and cannot stall in
 			 * async migration. Release the taken locks
 			 */
 			struct buffer_head *failed_bh = bh;
-			put_bh(failed_bh);
 			bh = head;
 			while (bh != failed_bh) {
 				unlock_buffer(bh);
-				put_bh(bh);
 				bh = bh->b_this_page;
 			}
 			return false;
@@ -818,7 +814,6 @@ unlock_buffers:
 	bh = head;
 	do {
 		unlock_buffer(bh);
-		put_bh(bh);
 		bh = bh->b_this_page;
 
 	} while (bh != head);

_