Skip to contentSkip to conversation

libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD

PATCH Applied Hans de Goede 2 participants 4 messages Feb 3, 2019 – Feb 6, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD

We've received a bugreport that using LPM with a SAMSUNG MZ7TE512HMHP-000L1 SSD leads to system instability, we already have a quirk for the MZ7TD256HAFV-000L9, which is also a Samsun EVO 840 / PM851 OEM model, so it seems some of these models have a LPM issue.

This commits adds a NOLPM quirk for the model string from the new bugeport, to avoid the reported stability issues.

---
 drivers/ata/libata-core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +1 -0
index b8c3f9e6af89..adf28788cab5 100644
@@ -4554,6 +4554,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
 	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
 	{ "SAMSUNG MZ7TD256HAFV-000L9", NULL,       ATA_HORKAGE_NOLPM, },
+	{ "SAMSUNG MZ7TE512HMHP-000L1", "EXT06L0Q", ATA_HORKAGE_NOLPM, },
 
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500IT_*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |
Signature · 1 line
2.20.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi,

Quoted 9 lines · Sasha Levin

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v4.20.6, v4.19.19, v4.14.97, v4.9.154, v4.4.172, v3.18.133.

Quoted 7 lines

v4.20.6: Build OK!
v4.19.19: Build OK!
v4.14.97: Failed to apply! Possible dependencies:

     410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
     76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
     a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
     b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")

The code to enable LPM support by default on mobile chipsets was merged in the 4.16 kernel, so 4.14 (and older) don't need these blacklist patches since they don't enable LPM by default (the user needs to write to a sysfs attribute to enable it).

So it is fine to leave this patch out of 4.14.z and older.

Regards,

Hans

Quoted 26 lines

v4.9.154: Failed to apply! Possible dependencies:

     410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
     76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
     a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
     b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")

v4.4.172: Failed to apply! Possible dependencies:

     410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
     76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
     a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
     b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")

v3.18.133: Failed to apply! Possible dependencies:

     410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
     76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
     a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
     b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")

How should we proceed with this patch?

--
Thanks,
Sasha

#3 lore raw
In reply to a message not in the archive

Hi,

Quoted 9 lines · Sasha Levin

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v4.20.6, v4.19.19, v4.14.97, v4.9.154, v4.4.172, v3.18.133.

Quoted 7 lines

v4.20.6: Build OK!
v4.19.19: Build OK!
v4.14.97: Failed to apply! Possible dependencies:

     410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
     76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
     a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
     b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")

The code to enable LPM support by default on mobile chipsets was merged in the 4.16 kernel, so 4.14 (and older) don't need these blacklist patches since they don't enable LPM by default (the user needs to write to a sysfs attribute to enable it).

So it is fine to leave this patch out of 4.14.z and older.

Regards,

Hans

Quoted 26 lines

v4.9.154: Failed to apply! Possible dependencies:

     410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
     76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
     a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
     b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")

v4.4.172: Failed to apply! Possible dependencies:

     410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
     76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
     a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
     b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")

v3.18.133: Failed to apply! Possible dependencies:

     410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
     76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
     a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
     b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")

How should we proceed with this patch?

--
Thanks,
Sasha

Applied
#4 lore raw
In reply to Hans de Goede
Quoted 7 lines · Hans de Goede

We've received a bugreport that using LPM with a SAMSUNG MZ7TE512HMHP-000L1 SSD leads to system instability, we already have a quirk for the MZ7TD256HAFV-000L9, which is also a Samsun EVO 840 / PM851 OEM model, so it seems some of these models have a LPM issue.

This commits adds a NOLPM quirk for the model string from the new bugeport, to avoid the reported stability issues.

Applied, thanks.

Signature · 1 line
Jens Axboe