Skip to contentSkip to conversation

tools: drop obsolete xen-ringwatch

PATCH In review Wei Liu 3 participants 4 messages Feb 4, 2019

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

PATCH 1/1 tools: drop obsolete xen-ringwatch

This utility can't possibly work with modern Xen setup: none of the sysfs path used (under /sys/devices/xen-backend) is documented as stable ABI in upstream Linux kernel.

Archaeology shows that the path used could have been part of the xenolinux fork which never got upstreamed.

It's utility is zero nowadays. Drop it.

---
 tools/misc/Makefile      |   2 -
 tools/misc/xen-ringwatch | 617 -----------------------------------------------
 2 files changed, 619 deletions(-)
 delete mode 100644 tools/misc/xen-ringwatch
tools/misc/Makefile +0 -2
index fd91202950..51adb6f1a6 100644
@@ -22,7 +22,6 @@ INSTALL_SBIN-$(CONFIG_X86)     += xen-hvmcrash
 INSTALL_SBIN-$(CONFIG_X86)     += xen-hvmctx
 INSTALL_SBIN-$(CONFIG_X86)     += xen-lowmemd
 INSTALL_SBIN-$(CONFIG_X86)     += xen-mfndump
-INSTALL_SBIN                   += xen-ringwatch
 INSTALL_SBIN                   += xen-tmem-list-parse
 INSTALL_SBIN                   += xencov
 INSTALL_SBIN                   += xenlockprof
@@ -40,7 +39,6 @@ INSTALL_PRIVBIN                += xenpvnetboot
 TARGETS_ALL := $(INSTALL_BIN) $(INSTALL_SBIN) $(INSTALL_PRIVBIN)
 
 # Everything which only needs copying to install
-TARGETS_COPY += xen-ringwatch
 TARGETS_COPY += xencons
 TARGETS_COPY += xencov_split
 TARGETS_COPY += xenpvnetboot
tools/misc/xen-ringwatch deleted +0 -617

617 lines not on this page · raw message

Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw
Quoted 10 lines · Wei Liu

This utility can't possibly work with modern Xen setup: none of the sysfs path used (under /sys/devices/xen-backend) is documented as stable ABI in upstream Linux kernel.

Archaeology shows that the path used could have been part of the xenolinux fork which never got upstreamed.

It's utility is zero nowadays. Drop it.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author
#2 lore raw
In reply to Wei Liu
Quoted 8 lines · Wei Liu

This utility can't possibly work with modern Xen setup: none of the sysfs path used (under /sys/devices/xen-backend) is documented as stable ABI in upstream Linux kernel.

Archaeology shows that the path used could have been part of the xenolinux fork which never got upstreamed.

It's utility is zero nowadays. Drop it.

"It's" should have been "Its", of course. :-)

Wei.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reviewed-by on v1 1/1
#3 lore raw
In reply to Wei Liu
Quoted 10 lines · Wei Liu

This utility can't possibly work with modern Xen setup: none of the sysfs path used (under /sys/devices/xen-backend) is documented as stable ABI in upstream Linux kernel.

Archaeology shows that the path used could have been part of the xenolinux fork which never got upstreamed.

It's utility is zero nowadays. Drop it.

It definitely used to "work" with the classic-xen kernels.

However, its utility was worse than zero.  When it did end up poking the back drivers, it ended up masking bugs.

XenServer got rather more stable when I dropped this locally, as we actually found and fixed the missing interrupt bug.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel