Skip to contentSkip to conversation

Support 32-bit code generation for Armv8 targets

PATCH New kostap at marvell.com 2 participants 5 messages Feb 4, 2019

lore
Share & tools
lore
#0 lore raw

cover Support 32-bit code generation for Armv8 targets

From: Konstantin Porotchkin <[email protected]>

This patch set adds support for building images for SoC that make usage of Armv8 application CPUs and Cortex-M/Cortex-R service CPUs. The application CPU cross-toolchain is unable to generate 32-bit THUMB code, therefore usage of secondary toolchain is needed.
The required pre-built toolchain is taken from ARM developers site and installed in host filesystem only.
The patch set makes use of dual toolchain for adding support for Marvell Armada 3700 SoC that uses both Cortex-A53 and Cortex-M3 CPUs for running system firmware.

Konstantin Porotchkin (3):
package: arm-gnu-rm-toolchain: Add ARM-RM toolchain
boot: a3700-utils-marvell: Add Armada-3700 utilities
boot: arm-trusted-firmware: add support for Marvell Armada 3700

 boot/Config.in                                |  1 +
 boot/a3700-utils-marvell/Config.in            | 46 +++++++++++++++++++
 .../a3700-utils-marvell.hash                  |  2 +
 .../a3700-utils-marvell.mk                    | 28 +++++++++++
 .../arm-trusted-firmware.mk                   |  7 +++
 package/Config.in.host                        |  1 +
 package/arm-gnu-rm-toolchain/Config.in.host   | 13 ++++++
 .../arm-gnu-rm-toolchain.hash                 |  2 +
 .../arm-gnu-rm-toolchain.mk                   | 22 +++++++++
 9 files changed, 122 insertions(+)
 create mode 100644 boot/a3700-utils-marvell/Config.in
 create mode 100644 boot/a3700-utils-marvell/a3700-utils-marvell.hash
 create mode 100644 boot/a3700-utils-marvell/a3700-utils-marvell.mk
 create mode 100644 package/arm-gnu-rm-toolchain/Config.in.host
 create mode 100644 package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.hash
 create mode 100644 package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 package: arm-gnu-rm-toolchain: Add ARM-RM toolchain

From: Konstantin Porotchkin <[email protected]>

Add host-only ARM RM toolchain for supporting firmware builds for Armv8-based SoCs utilizing Cortex-M/Cortex-R service CPUs.
The cross-toolchain used for building Armv8 application CPU code cannot be used for Cortex-M/Cortex-R 32-bit THUMB code generation.
This patch installs pre-build bate metal ARM GNU-RM toolchain into the host file system folder /opt/gcc-arm for covering the above mentioned cases.

---
 package/Config.in.host                        |  1 +
 package/arm-gnu-rm-toolchain/Config.in.host   | 13 +++++++++++
 .../arm-gnu-rm-toolchain.hash                 |  2 ++
 .../arm-gnu-rm-toolchain.mk                   | 22 +++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/arm-gnu-rm-toolchain/Config.in.host
 create mode 100644 package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.hash
 create mode 100644 package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk
package/Config.in.host +1 -0
index 16b474fc9d..41dfd76785 100644
@@ -67,5 +67,6 @@ menu "Host utilities"
 	source "package/xorriso/Config.in.host"
 	source "package/zip/Config.in.host"
 	source "package/zstd/Config.in.host"
+	source "package/arm-gnu-rm-toolchain/Config.in.host"
 
 endmenu
package/arm-gnu-rm-toolchain/Config.in.host new file +13 -0
new file mode 100644
index 0000000000..3341760acd
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_HOST_ARM_GNU_RM_TOOLCHAIN
+	bool "host arm-gnu-rm-toolchain"
+	depends on BR2_HOSTARCH = "x86_64"
+	select BR2_HOSTARCH_NEEDS_IA32_LIBS
+	help
+	  The GNU Embedded Toolchain for Arm is an open-source pre-built
+	  suite of tools for C, C++ and Assembly programming targeting
+	  Arm Cortex-M and Cortex-R family of processors.
+	  It includes the GNU Compiler (GCC) and is available free of charge
+	  directly from Arm for embedded software development.
+
+
+	  https://developer.arm.com/open-source/gnu-toolchain/gnu-rm/downloads
\ No newline at end of file
package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.hash new file +2 -0
new file mode 100644
index 0000000000..a08e8e6208
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 bb17109f0ee697254a5d4ae6e5e01440e3ea8f0277f2e8169bf95d07c7d5fe69 gcc-arm-none-eabi-7-2018-q2-update-linux.tar.bz2
package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk new file +22 -0
new file mode 100644
index 0000000000..be02130f28
@@ -0,0 +1,22 @@
+################################################################################
+#
+# arm-gnu-rm-toolchain
+#
+################################################################################
+
+ARM_GNU_RM_TOOLCHAIN_SITE = https://developer.arm.com/-/media/Files/downloads/gnu-rm/7-2018q2
+ARM_GNU_RM_TOOLCHAIN_VERSION = 7-2018-q2-update
+ARM_GNU_RM_TOOLCHAIN_SOURCE = gcc-arm-none-eabi-$(ARM_GNU_RM_TOOLCHAIN_VERSION)-linux.tar.bz2
+
+define HOST_ARM_GNU_RM_TOOLCHAIN_EXTRACT_CMDS
+	$(TAR) xf $(HOST_ARM_GNU_RM_TOOLCHAIN_DL_DIR)/$(ARM_GNU_RM_TOOLCHAIN_SOURCE) -C $(BUILD_DIR)
+	mv $(BUILD_DIR)/gcc-arm-none-eabi-$(ARM_GNU_RM_TOOLCHAIN_VERSION)/* $(@D)
+	rmdir $(BUILD_DIR)/gcc-arm-none-eabi-$(ARM_GNU_RM_TOOLCHAIN_VERSION)/
+endef
+
+define HOST_ARM_GNU_RM_TOOLCHAIN_INSTALL_CMDS
+	mkdir -p $(HOST_DIR)/opt/gcc-arm/
+	cp -a $(@D)/* $(HOST_DIR)/opt/gcc-arm/
+endef
+
+$(eval $(host-generic-package))
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/3 package: arm-gnu-rm-toolchain: Add ARM-RM toolchain

Hello,

Title should be:

package/arm-gnu-rm-toolchain: new package

Quoted 1 line · On Mon, 4 Feb 2019 16:31:35 +0200 <[email protected]> wrote:

Add host-only ARM RM toolchain for supporting firmware

"host-only" doesn't mean much here. It's a cross-compilation toolchain, so it's not really "host-only".

Quoted 1 line

This patch installs pre-build bate metal ARM GNU-RM toolchain

pre-build -> "a pre-built"

Quoted 2 lines

into the host file system folder /opt/gcc-arm for covering the above mentioned cases.

"into the host filesystem folder /opt/gcc-arm" ->
$(HOST_DIR)/opt/gcc-arm

package/Config.in.host menu "Host utilities" · line 70

Quoted 9 lines
package/Config.in.host +1 -0
index 16b474fc9d..41dfd76785 100644
@@ -67,5 +67,6 @@ menu "Host utilities"
 	source "package/xorriso/Config.in.host"
 	source "package/zip/Config.in.host"
 	source "package/zstd/Config.in.host"
+	source "package/arm-gnu-rm-toolchain/Config.in.host"

I don't think we need a Config.in.host option for this.

package/arm-gnu-rm-toolchain/Config.in.host line 4

Quoted 10 lines
package/arm-gnu-rm-toolchain/Config.in.host new file +4 -0
new file mode 100644
index 0000000000..3341760acd
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_HOST_ARM_GNU_RM_TOOLCHAIN
+	bool "host arm-gnu-rm-toolchain"
+	depends on BR2_HOSTARCH = "x86_64"
+	select BR2_HOSTARCH_NEEDS_IA32_LIBS

These two lines together don't make sense. If you select BR2_HOSTARCH_NEEDS_IA32_LIBS, it's because the pre-built binaries are for x86 32 bits, and therefore the 32 bit compat libraries are needed when running on a x86-64 system. If pre-built binaries are for x86 32 bits, then surely the dependency on BR2_HOSTARCH = "x86_64" is not correct.

But anyway as stated above, I don't think a Config.in.host file is needed here.

Quoted 11 lines
package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk new file +5 -0
new file mode 100644
index 0000000000..be02130f28
@@ -0,0 +1,22 @@
+################################################################################
+#
+# arm-gnu-rm-toolchain
+#
+################################################################################

package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk line 15

Quoted 10 lines
package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk new file +10 -0
+
+ARM_GNU_RM_TOOLCHAIN_SITE = https://developer.arm.com/-/media/Files/downloads/gnu-rm/7-2018q2
+ARM_GNU_RM_TOOLCHAIN_VERSION = 7-2018-q2-update
+ARM_GNU_RM_TOOLCHAIN_SOURCE = gcc-arm-none-eabi-$(ARM_GNU_RM_TOOLCHAIN_VERSION)-linux.tar.bz2
+
+define HOST_ARM_GNU_RM_TOOLCHAIN_EXTRACT_CMDS
+	$(TAR) xf $(HOST_ARM_GNU_RM_TOOLCHAIN_DL_DIR)/$(ARM_GNU_RM_TOOLCHAIN_SOURCE) -C $(BUILD_DIR)
+	mv $(BUILD_DIR)/gcc-arm-none-eabi-$(ARM_GNU_RM_TOOLCHAIN_VERSION)/* $(@D)
+	rmdir $(BUILD_DIR)/gcc-arm-none-eabi-$(ARM_GNU_RM_TOOLCHAIN_VERSION)/
+endef

Why do you need custom extract commands ? It seems to be just a regular tarball.

package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk line 19

Quoted 4 lines
package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk new file +4 -0
+
+define HOST_ARM_GNU_RM_TOOLCHAIN_INSTALL_CMDS
+	mkdir -p $(HOST_DIR)/opt/gcc-arm/
+	cp -a $(@D)/* $(HOST_DIR)/opt/gcc-arm/

Install in gcc-arm-none-eabi so that it's clear it's a bare-metal toolchain.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 2/3 boot: a3700-utils-marvell: Add Armada-3700 utilities

In reply to kostap at marvell.com

From: Konstantin Porotchkin <[email protected]>

Marvell Armada 37xx firmware code and utilities are kept in a separate repository. This code is needed as a dependency to build ATF firmware for Marvell Armada 37xx SoCs.

---
 boot/Config.in                                |  1 +
 boot/a3700-utils-marvell/Config.in            | 46 +++++++++++++++++++
 .../a3700-utils-marvell.hash                  |  2 +
 .../a3700-utils-marvell.mk                    | 28 +++++++++++
 4 files changed, 77 insertions(+)
 create mode 100644 boot/a3700-utils-marvell/Config.in
 create mode 100644 boot/a3700-utils-marvell/a3700-utils-marvell.hash
 create mode 100644 boot/a3700-utils-marvell/a3700-utils-marvell.mk
boot/Config.in +1 -0
index 8e0c8e5df4..4acde0e764 100644
@@ -19,5 +19,6 @@ source "boot/syslinux/Config.in"
 source "boot/ts4800-mbrboot/Config.in"
 source "boot/uboot/Config.in"
 source "boot/vexpress-firmware/Config.in"
+source "boot/a3700-utils-marvell/Config.in"
 
 endmenu
boot/a3700-utils-marvell/Config.in new file +46 -0

46 lines not on this page · raw message

boot/a3700-utils-marvell/a3700-utils-marvell.hash new file +2 -0
new file mode 100644
index 0000000000..b4f4cd70e9
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 5a8dd5ae9322d19a61a8ca9ca9235c0a24dee889e6a0b2f848fc8d9e1494505d a3700-utils-marvell-a0a1cb88327afa91415c59822fa9c5894d9ec3d7.tar.gz
boot/a3700-utils-marvell/a3700-utils-marvell.mk new file +28 -0
new file mode 100644
index 0000000000..c4fb29d73a
@@ -0,0 +1,28 @@
+################################################################################
+#
+# a3700-utils-marvell
+#
+################################################################################
+
+ifeq ($(BR2_TARGET_A3700_UTILS_MARVELL_CUSTOM_GIT),y)
+A3700_UTILS_MARVELL_VERSION = $(call qstrip,$(BR2_TARGET_A3700_UTILS_MARVELL_CUSTOM_REPO_VERSION))
+A3700_UTILS_MARVELL_SITE = $(call qstrip,$(BR2_TARGET_A3700_UTILS_MARVELL_CUSTOM_REPO_URL))
+A3700_UTILS_MARVELL_SITE_METHOD = git
+BR_NO_CHECK_HASH_FOR += $(A3700_UTILS_MARVELL_SOURCE)
+else
+ifeq ($(BR2_TARGET_A3700_UTILS_MARVELL_CUSTOM_TARBALL),y)
+A3700_UTILS_MARVELL_TARBALL = $(call qstrip,$(BR2_TARGET_A3700_UTILS_MARVELL_CUSTOM_TARBALL_LOCATION))
+A3700_UTILS_MARVELL_SITE = $(patsubst %/,%,$(dir $(A3700_UTILS_MARVELL_TARBALL)))
+A3700_UTILS_MARVELL_SITE_METHOD = file
+A3700_UTILS_MARVELL_SOURCE = $(notdir $(A3700_UTILS_MARVELL_TARBALL))
+BR_NO_CHECK_HASH_FOR += $(A3700_UTILS_MARVELL_SOURCE)
+else
+# This is the commit for A3700-utils-armada-18.12.0
+A3700_UTILS_MARVELL_VERSION = a0a1cb88327afa91415c59822fa9c5894d9ec3d7
+A3700_UTILS_MARVELL_SITE = $(call github,MarvellEmbeddedProcessors,A3700-utils-marvell,$(A3700_UTILS_MARVELL_VERSION))
+endif
+endif
+A3700_UTILS_MARVELL_LICENSE = GPL-2.0+ or LGPL-2.1 with freertos-exception-2.0, BSD-3-Clause, Marvell Commercial
+A3700_UTILS_MARVELL_LICENSE_FILES = wtptp/src/TBB_Linux/readme.txt
+
+$(eval $(generic-package))
Signature · 1 line
2.17.1
#4 lore raw

PATCH 3/3 boot: arm-trusted-firmware: add support for Marvell Armada 3700

In reply to kostap at marvell.com

From: Konstantin Porotchkin <[email protected]>

Add support for TF-A image builds for Marvell Armada 3700 family

---
 boot/arm-trusted-firmware/arm-trusted-firmware.mk | 7 +++++++
 1 file changed, 7 insertions(+)
boot/arm-trusted-firmware/arm-trusted-firmware.mk +7 -0
index 23f493653d..397bed64bc 100644
@@ -52,6 +52,13 @@ ARM_TRUSTED_FIRMWARE_MAKE_OPTS += MV_DDR_PATH=$(MV_DDR_MARVELL_DIR)
 ARM_TRUSTED_FIRMWARE_DEPENDENCIES += mv-ddr-marvell
 endif
 
+ifeq ($(BR2_TARGET_A3700_UTILS_MARVELL),y)
+ARM_TRUSTED_FIRMWARE_MAKE_OPTS += WTP=$(A3700_UTILS_MARVELL_DIR)
+ARM_TRUSTED_FIRMWARE_MAKE_OPTS += CROSS_CM3=$(HOST_DIR)/opt/gcc-arm/bin/arm-none-eabi-
+ARM_TRUSTED_FIRMWARE_DEPENDENCIES += a3700-utils-marvell
+ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-arm-gnu-rm-toolchain
+endif
+
 ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all
 
 ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y)
Signature · 1 line
2.17.1