Skip to contentSkip to conversation

ath10k: fix S5 power consumption issue for QCA9377

PATCH In review Yu Wang 3 participants 4 messages Jan 15, 2019 – Feb 4, 2019 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Yu Wang

author
#0 lore raw

PATCH 1/1 ath10k: fix S5 power consumption issue for QCA9377

After system entering S5 (shut down but system still providing power to QCA9377) on Ubuntu platform, power consumption of QCA9377 is 69mA, which is too high.
The root cause is pci_soft_reset is not set for QCA9377 during pci probe.
To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset', and then the power consumption drops to a normal value(10mA). Verified on Dell Ubuntu platform with firmware:
WLAN.TF.1.0-00002-QCATFSWPZ-5

---
 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/pci.c +1 -1
index 01b4edb..0a4ce98 100644
@@ -3554,7 +3554,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
 	case QCA9377_1_0_DEVICE_ID:
 		hw_rev = ATH10K_HW_QCA9377;
 		pci_ps = true;
-		pci_soft_reset = NULL;
+		pci_soft_reset = ath10k_pci_warm_reset;
 		pci_hard_reset = ath10k_pci_qca6174_chip_reset;
 		targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;
 		break;
Signature · 7 lines
1.9.1


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw

+ Karen

Thanks,
Robert

-----Original Message-----
From: ath10k <[email protected]> On Behalf Of Yu Wang
Sent: Tuesday, January 15, 2019 2:31 PM
To: [email protected]
Cc: Yu Wang <[email protected]>; [email protected]
Subject: [EXT] [PATCH] ath10k: fix S5 power consumption issue for QCA9377

After system entering S5 (shut down but system still providing power to QCA9377) on Ubuntu platform, power consumption of QCA9377 is 69mA, which is too high. The root cause is pci_soft_reset is not set for QCA9377 during pci probe.
To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset', and then the power consumption drops to a normal value(10mA). Verified on Dell Ubuntu platform with firmware:
WLAN.TF.1.0-00002-QCATFSWPZ-5

---
 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/pci.c +1 -1
index 01b4edb..0a4ce98 100644
@@ -3554,7 +3554,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
 	case QCA9377_1_0_DEVICE_ID:
 		hw_rev = ATH10K_HW_QCA9377;
 		pci_ps = true;
-		pci_soft_reset = NULL;
+		pci_soft_reset = ath10k_pci_warm_reset;
 		pci_hard_reset = ath10k_pci_qca6174_chip_reset;
 		targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;
 		break;

--
1.9.1

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

#2 lore raw
In reply to Yu Wang
Quoted 10 lines · Yu Wang

After system entering S5 (shut down but system still providing power to QCA9377) on Ubuntu platform, power consumption of QCA9377 is 69mA, which is too high.
The root cause is pci_soft_reset is not set for QCA9377 during pci probe.
To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset', and then the power consumption drops to a normal value(10mA). Verified on Dell Ubuntu platform with firmware:
WLAN.TF.1.0-00002-QCATFSWPZ-5

Quoted 3 lines

Patch applied to ath-next branch of ath.git, thanks.

1a86be476cfa ath10k: fix S5 power consumption issue for QCA9377

Signature · 9 lines
https://patchwork.kernel.org/patch/10764017/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#3 lore raw
In reply to Yu Wang
Quoted 10 lines · Yu Wang

After system entering S5 (shut down but system still providing power to QCA9377) on Ubuntu platform, power consumption of QCA9377 is 69mA, which is too high.
The root cause is pci_soft_reset is not set for QCA9377 during pci probe.
To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset', and then the power consumption drops to a normal value(10mA). Verified on Dell Ubuntu platform with firmware:
WLAN.TF.1.0-00002-QCATFSWPZ-5

Quoted 3 lines

Patch applied to ath-next branch of ath.git, thanks.

1a86be476cfa ath10k: fix S5 power consumption issue for QCA9377

Signature · 3 lines
https://patchwork.kernel.org/patch/10764017/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches