Skip to contentSkip to conversation

adding s390x tests to ltp

PATCH New Elif Aslan 4 participants 6 messages Feb 4, 2019 – Feb 18, 2019

lore
Share & tools
lore

Elif Aslan

author
#0 lore raw

PATCH 1/1 adding s390x tests to ltp

---
 runtest/s390x_tools                           |  2 +
 testcases/commands/s390x_tools/vmcp/vmcp_m.sh | 58 +++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 runtest/s390x_tools
 create mode 100644 testcases/commands/s390x_tools/vmcp/vmcp_m.sh
runtest/s390x_tools new file +2 -0
new file mode 100644
index 000000000..c88f0cac4
@@ -0,0 +1,2 @@
+#DESCRIPTION:s390x_tools tests
+vmcp vmcp_m.sh
testcases/commands/s390x_tools/vmcp/vmcp_m.sh new file +58 -0

58 lines not on this page · raw message

Signature · 1 line
2.17.2 (Apple Git-113)
#1 lore raw

PATCH 1/1 adding s390x tests to ltp

Hi Elif,

these tests are just user space tests for vmcp, LTP would not benefit from it. I guess you should try to contribute test to s390-tools, where vmcp belongs to.

LTP tests are concern about kernel related tests. There are some user space tests, but these are related to kernel (e.g. insmod, keyctl) or able to trigger kernel oops (e.g. filesystem related tools).

Kind regards,
Petr

#2 lore raw

PATCH 1/1 adding s390x tests to ltp

In reply to Elif Aslan

----- Original Message -----

Quoted 13 lines
---
 runtest/s390x_tools                           |  2 +
 testcases/commands/s390x_tools/vmcp/vmcp_m.sh | 58 +++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 runtest/s390x_tools
 create mode 100644 testcases/commands/s390x_tools/vmcp/vmcp_m.sh
runtest/s390x_tools new file +0 -0
new file mode 100644
index 000000000..c88f0cac4

runtest/s390x_tools line 2

Quoted 2 lines
runtest/s390x_tools new file +2 -0
@@ -0,0 +1,2 @@
+#DESCRIPTION:s390x_tools tests
+vmcp vmcp_m.sh

Hi,

There is already a runtest/commands, any reason for making new one?

Quoted 12 lines
testcases/commands/s390x_tools/vmcp/vmcp_m.sh new file +5 -0
new file mode 100644
index 000000000..d1f7752de
@@ -0,0 +1,58 @@
+#!/bin/sh
+#
+# Copyright (C) 2018 IBM Corp.
+#
+# Copying and distribution of this file, with or without modification,

testcases/commands/s390x_tools/vmcp/vmcp_m.sh line 15

Quoted 10 lines
testcases/commands/s390x_tools/vmcp/vmcp_m.sh new file +10 -0
+# are permitted in any medium without royalty provided the copyright
+# notice and this notice are preserved.  This file is offered as-is,
+# without any warranty.
+
+#set -x
+#
+
+TST_CNT=2
+TST_TESTFUNC=vmcp_main
+TST_USAGE=usage

Maybe also: TST_NEEDS_CMDS="vmcp" ?
Not sure if all s390x distros have this command installed.

But that should also be sufficient check to run this on any arch, if command doesn't exist it will TCONF.

Regards,
Jan

#3 lore raw

PATCH 1/1 adding s390x tests to ltp

Hi!

Quoted 1 line

There is already a runtest/commands, any reason for making new one?

If we are going to add more s390x related tests it would make sense to create a runtest file for them.

Signature · 2 lines
Cyril Hrubis
[email protected]
#4 lore raw

PATCH 1/1 adding s390x tests to ltp

In reply to Jan Stancek

Hi Jan, Cyril,

Quoted 5 lines

Maybe also: TST_NEEDS_CMDS="vmcp" ?
Not sure if all s390x distros have this command installed.

But that should also be sufficient check to run this on any arch, if command doesn't exist it will TCONF.

The reason, why I suggested to move these tests to upstream [1]
is that testing "vmcp --version" or "vmcp --help" does not really depend on anyhow on SUT. Adding it to upstream into make check (there are none check yet) would bring 1) earlier catch of potencial bugs as upstream developers can run it for each commit (CI) and distros during package build.

We had some discussion before about removing some user space packages [2]. Cyril suggested to to keep tests that are working with files (cp/df/ln) and remove at least unzip and wc.
Doing some real testing (really using vmcp.ko) would make this tests useful to run on LTP, but current code IMHO does nothing with kernel. Or do I miss something?

Anyway, it looks like you have no objection about adding it to LTP, so I changed state of this test New. In that case, I suggest to

remove debugging:

testcases/commands/s390x_tools/vmcp/vmcp_m.sh line 11

Quoted 2 lines
testcases/commands/s390x_tools/vmcp/vmcp_m.sh new file +2 -0
+#set -x
+#

use tst_res TINFO instead of echo
+ echo "verifyBasicVMCPCommands"
+ echo "verifyErrorCondition"

Kind regards,
Petr

[1] https://github.com/ibm-s390-tools/s390-tools
[2] https://patchwork.ozlabs.org/patch/905064/#1902070

#5 lore raw

PATCH 1/1 adding s390x tests to ltp

----- Original Message -----

Quoted 24 lines

Hi Jan, Cyril,

Quoted 5 lines

Maybe also: TST_NEEDS_CMDS="vmcp" ?
Not sure if all s390x distros have this command installed.

But that should also be sufficient check to run this on any arch, if command doesn't exist it will TCONF.

The reason, why I suggested to move these tests to upstream [1] is that testing "vmcp --version" or "vmcp --help" does not really depend on anyhow on SUT. Adding it to upstream into make check (there are none check yet)
would bring 1) earlier catch of potencial bugs as upstream developers can run it
for each commit (CI) and distros during package build.

We had some discussion before about removing some user space packages [2]. Cyril suggested to to keep tests that are working with files (cp/df/ln) and remove at least unzip and wc.
Doing some real testing (really using vmcp.ko) would make this tests useful to
run on LTP, but current code IMHO does nothing with kernel. Or do I miss something?

Quoted 1 line

Anyway, it looks like you have no objection about adding it to LTP

I don't. My only question was if runtest/commands would be more fitting for the test, but people seemed to prefer s390x specific runtest-file instead.

Regards,
Jan

Quoted 18 lines

, so I
changed
state of this test New. In that case, I suggest to

remove debugging:

testcases/commands/s390x_tools/vmcp/vmcp_m.sh line 11

Quoted 2 lines
testcases/commands/s390x_tools/vmcp/vmcp_m.sh new file +2 -0
+#set -x
+#

use tst_res TINFO instead of echo

testcases/commands/s390x_tools/vmcp/vmcp_m.sh new file +2 -0
+	echo "verifyBasicVMCPCommands"
+	echo "verifyErrorCondition"

Kind regards,
Petr

[1] https://github.com/ibm-s390-tools/s390-tools
[2] https://patchwork.ozlabs.org/patch/905064/#1902070