Skip to contentSkip to conversation

send-error-report: Use https instead of http protocol

PATCH In review Khem Raj 3 participants 7 messages Feb 4, 2019 – Mar 5, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 send-error-report: Use https instead of http protocol

errors.yp.org can understand https

---
 scripts/send-error-report | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/send-error-report +3 -3
index 8939f5f594..3528cf93a9 100755
@@ -62,7 +62,7 @@ def edit_content(json_file_path):
 
 def prepare_data(args):
     # attempt to get the max_log_size from the server's settings
-    max_log_size = getPayloadLimit("http://"+args.server+"/ClientPost/JSON")
+    max_log_size = getPayloadLimit("https://"+args.server+"/ClientPost/JSON")
 
     if not os.path.isfile(args.error_file):
         log.error("No data file found.")
@@ -132,9 +132,9 @@ def send_data(data, args):
     headers={'Content-type': 'application/json', 'User-Agent': "send-error-report/"+version}
 
     if args.json:
-        url = "http://"+args.server+"/ClientPost/JSON/"
+        url = "https://"+args.server+"/ClientPost/JSON/"
     else:
-        url = "http://"+args.server+"/ClientPost/"
+        url = "https://"+args.server+"/ClientPost/"
 
     req = urllib.request.Request(url, data=data, headers=headers)
     try:
Signature · 1 line
2.20.1
#1 lore raw

Hi Khem,

We have an internal error web server, this patch breaks it:

You're accessing the development server over HTTPS, but it only supports HTTP

So I tried to use runsslserver, but it doesn't work either since the host is Ubuntu 14.04 (python 2.7.6):

$ python manage.py runsslserver

[snip]
ssl_version=ssl.PROTOCOL_TLSv1_2,
AttributeError: 'module' object has no attribute 'PROTOCOL_TLSv1_2'

This is because python is old.

I think that make it default to https would make the server harder to set up, so is it possible to:

* Make it default to http, and add an option such as --https (or --ssl) for https

Or:

* Add an option such as --no-ssl to make it use http.

I prefer the first one since https server is harder to setup than http in django. I can work on it if no objections.

// Robert

Quoted 33 lines · Khem Raj

errors.yp.org can understand https

---
  scripts/send-error-report | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
scripts/send-error-report +3 -3
index 8939f5f594..3528cf93a9 100755
@@ -62,7 +62,7 @@ def edit_content(json_file_path):
 
  def prepare_data(args):
      # attempt to get the max_log_size from the server's settings
-    max_log_size = getPayloadLimit("http://"+args.server+"/ClientPost/JSON")
+    max_log_size = getPayloadLimit("https://"+args.server+"/ClientPost/JSON")
 
      if not os.path.isfile(args.error_file):
          log.error("No data file found.")
@@ -132,9 +132,9 @@ def send_data(data, args):
      headers={'Content-type': 'application/json', 'User-Agent': "send-error-report/"+version}
 
      if args.json:
-        url = "http://"+args.server+"/ClientPost/JSON/"
+        url = "https://"+args.server+"/ClientPost/JSON/"
      else:
-        url = "http://"+args.server+"/ClientPost/"
+        url = "https://"+args.server+"/ClientPost/"
 
      req = urllib.request.Request(url, data=data, headers=headers)
      try:
#2 lore raw
Quoted 26 lines · Robert Yang

Hi Khem,

We have an internal error web server, this patch breaks it:

You're accessing the development server over HTTPS, but it only supports HTTP

So I tried to use runsslserver, but it doesn't work either since the host is
Ubuntu 14.04 (python 2.7.6):

$ python manage.py runsslserver

[snip]
ssl_version=ssl.PROTOCOL_TLSv1_2,
AttributeError: 'module' object has no attribute 'PROTOCOL_TLSv1_2'

This is because python is old.

I think that make it default to https would make the server harder to set up,
so is it possible to:

* Make it default to http, and add an option such as --https (or -- ssl) for https

Quoted 6 lines

Or:

* Add an option such as --no-ssl to make it use http.

I prefer the first one since https server is harder to setup than http in django. I can work on it if no objections.

At this point the project does require python3 so python2 being old shouldn't be a reason to be changing this.

The project also needs to be seen to encourage secure practises so I think https should be the default but adding an option to use http should be ok.

Cheers,

Richard

#3 lore raw

Hi RP,

Quoted 29 lines · Richard Purdie
Quoted 28 lines · Robert Yang

Hi Khem,

We have an internal error web server, this patch breaks it:

You're accessing the development server over HTTPS, but it only supports HTTP

So I tried to use runsslserver, but it doesn't work either since the host is
Ubuntu 14.04 (python 2.7.6):

$ python manage.py runsslserver

[snip]
ssl_version=ssl.PROTOCOL_TLSv1_2,
AttributeError: 'module' object has no attribute 'PROTOCOL_TLSv1_2'

This is because python is old.

I think that make it default to https would make the server harder to set up,
so is it possible to:

* Make it default to http, and add an option such as --https (or -- ssl) for https

Or:

Quoted 7 lines
Quoted 4 lines

* Add an option such as --no-ssl to make it use http.

I prefer the first one since https server is harder to setup than http in django. I can work on it if no objections.

At this point the project does require python3 so python2 being old shouldn't be a reason to be changing this.

The python3 + error-report-web doesn't work for me:

$ python3 manage.py runserver ip:8000

And when I tried to access http://128.224.156.132:8000, it raised errors:

error-report-web/Post/views.py", line 16, in <module>
from parser import Parser
ImportError: cannot import name 'Parser'

So I use python 2 for it. I thought that it didn't support python3, or didn't test well.

Quoted 4 lines

The project also needs to be seen to encourage secure practises so I think https should be the default but adding an option to use http should be ok.

Thanks, I will send a patch for it.

// Robert

Quoted 8 lines

Cheers,

Richard

#4 lore raw
Quoted 51 lines · Robert Yang

Hi RP,

Quoted 33 lines · Richard Purdie
Quoted 32 lines · Robert Yang

Hi Khem,

We have an internal error web server, this patch breaks it:

You're accessing the development server over HTTPS, but it only supports HTTP

So I tried to use runsslserver, but it doesn't work either since the
host is
Ubuntu 14.04 (python 2.7.6):

$ python manage.py runsslserver

[snip]
ssl_version=ssl.PROTOCOL_TLSv1_2,
AttributeError: 'module' object has no attribute
'PROTOCOL_TLSv1_2'

This is because python is old.

I think that make it default to https would make the server harder to
set up,
so is it possible to:

* Make it default to http, and add an option such as --https (or --
ssl) for https

Or:

Quoted 7 lines
Quoted 4 lines

* Add an option such as --no-ssl to make it use http.

I prefer the first one since https server is harder to setup than http in django. I can work on it if no objections.

At this point the project does require python3 so python2 being old shouldn't be a reason to be changing this.

The python3 + error-report-web doesn't work for me:

$ python3 manage.py runserver ip:8000

And when I tried to access http://128.224.156.132:8000, it raised errors:

Quoted 7 lines

error-report-web/Post/views.py", line 16, in <module>
from parser import Parser
ImportError: cannot import name 'Parser'

So I use python 2 for it. I thought that it didn't support python3, or didn't
test well.

Fixing it to work with python3 would be the preferred option...

Cheers,

Richard

#5 lore raw
Quoted 56 lines · Richard Purdie
Quoted 55 lines · Robert Yang

Hi RP,

Quoted 33 lines · Richard Purdie
Quoted 32 lines · Robert Yang

Hi Khem,

We have an internal error web server, this patch breaks it:

You're accessing the development server over HTTPS, but it only supports HTTP

So I tried to use runsslserver, but it doesn't work either since the
host is
Ubuntu 14.04 (python 2.7.6):

$ python manage.py runsslserver

[snip]
ssl_version=ssl.PROTOCOL_TLSv1_2,
AttributeError: 'module' object has no attribute
'PROTOCOL_TLSv1_2'

This is because python is old.

I think that make it default to https would make the server harder to
set up,
so is it possible to:

* Make it default to http, and add an option such as --https (or --
ssl) for https

Or:

Quoted 7 lines
Quoted 4 lines

* Add an option such as --no-ssl to make it use http.

I prefer the first one since https server is harder to setup than http in django. I can work on it if no objections.

At this point the project does require python3 so python2 being old shouldn't be a reason to be changing this.

The python3 + error-report-web doesn't work for me:

$ python3 manage.py runserver ip:8000

And when I tried to access http://128.224.156.132:8000, it raised errors:

error-report-web/Post/views.py", line 16, in <module>
from parser import Parser
ImportError: cannot import name 'Parser'

Quoted 5 lines
Quoted 3 lines

So I use python 2 for it. I thought that it didn't support python3, or didn't
test well.

Fixing it to work with python3 would be the preferred option...

Sounds good, I will work on it.

// Robert

Quoted 6 lines

Cheers,

Richard

#6 lore raw

Hi RP,

I've sent a patch to fix for python3:

https://lists.yoctoproject.org/pipermail/yocto/2019-March/044387.html

And CC-ed [email protected], I assumed that he is the maintainer, but seems that the email is not valid any more.

I think that we have more work to do with error report web, e.g.:
- The 'Similar' tag on the web isn't correct, it doesn't calculate correctly

- Sometimes, there is an error like:
File "/buildarea/lyang1/error-report-web/Post/parser.py", line 101, in parse
num_similar_errors = f.get_similar_fails_count()
UnboundLocalError: local variable 'f' referenced before assignment

- We can make report-error.bbclass to catch more errors such as NoProvider errors, Parse errors, and so on.

I'd like to maintain it if it has no maintainers.

// Robert

Quoted 75 lines · Robert Yang
Quoted 56 lines · Richard Purdie
Quoted 55 lines · Robert Yang

Hi RP,

Quoted 33 lines · Richard Purdie
Quoted 32 lines · Robert Yang

Hi Khem,

We have an internal error web server, this patch breaks it:

You're accessing the development server over HTTPS, but it only supports HTTP

So I tried to use runsslserver, but it doesn't work either since the
host is
Ubuntu 14.04 (python 2.7.6):

$ python manage.py runsslserver

[snip]
       ssl_version=ssl.PROTOCOL_TLSv1_2,
AttributeError: 'module' object has no attribute
'PROTOCOL_TLSv1_2'

This is because python is old.

I think that make it default to https would make the server harder to
set up,
so is it possible to:

* Make it default to http, and add an option such as --https (or

Signature · 3 lines
ssl) for https

Or:
Quoted 7 lines
Quoted 4 lines

* Add an option such as --no-ssl to make it use http.

I prefer the first one since https server is harder to setup than http in django. I can work on it if no objections.

At this point the project does require python3 so python2 being old shouldn't be a reason to be changing this.

The python3 + error-report-web doesn't work for me:

$ python3 manage.py runserver ip:8000

And when I tried to access http://128.224.156.132:8000, it raised errors:

error-report-web/Post/views.py", line 16, in <module> from parser import Parser
ImportError: cannot import name 'Parser'

Quoted 5 lines
Quoted 3 lines

So I use python 2 for it. I thought that it didn't support python3, or didn't
test well.

Fixing it to work with python3 would be the preferred option...

Sounds good, I will work on it.

// Robert

Quoted 6 lines

Cheers,

Richard