Skip to contentSkip to conversation

Staging: rtl8723bs: remove some dead code

PATCH In review Dan Carpenter 2 participants 2 messages Feb 4, 2019 – Feb 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8723bs: remove some dead code

"psecnetwork" is the address of &psecuritypriv->sec_bss. Since ->sec_bss isn't the first member of the struct that means that "psecnetwork" can't be NULL.

We can just remove this dead code.

---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +0 -8
index ea2c187e56bd..91520ca3bbad 100644
@@ -835,14 +835,6 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
 	}
 
 	psecnetwork = (struct wlan_bssid_ex *)&psecuritypriv->sec_bss;
-	if (psecnetwork = NULL) {
-		kfree(pcmd);
-		res = _FAIL;
-
-		RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("rtw_joinbss_cmd :psecnetwork = NULL!!!\n"));
-
-		goto exit;
-	}
 
 	memset(psecnetwork, 0, t_len);
 
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 7 lines · Dan Carpenter

"psecnetwork" is the address of &psecuritypriv->sec_bss. Since ->sec_bss isn't the first member of the struct that means that "psecnetwork" can't be NULL.

We can just remove this dead code.

Thanks, LGTM:

Regards,

Hans

Quoted 24 lines
---
  drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 --------
  1 file changed, 8 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +0 -8
index ea2c187e56bd..91520ca3bbad 100644
@@ -835,14 +835,6 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
  	}
 
  	psecnetwork = (struct wlan_bssid_ex *)&psecuritypriv->sec_bss;
-	if (psecnetwork = NULL) {
-		kfree(pcmd);
-		res = _FAIL;
-
-		RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("rtw_joinbss_cmd :psecnetwork = NULL!!!\n"));
-
-		goto exit;
-	}
 
  	memset(psecnetwork, 0, t_len);