drm/bochs: fix bochs_gem_prime_mmap
Subsystems (3)
PATCH 1/1 drm/bochs: fix bochs_gem_prime_mmap
ttm_fbdev_mmap() just doesn't work. It appears to work fine, mmap() returns success, but any attempt to actually access the mapping causes a SIGBUS.
We can just use drm_gem_prime_mmap() instead. Almost. We have to copy over the start offset from the ttm_buffer_object vm_node to the drm_gem_object vm_node so the offset math in drm_gem_prime_mmap() works correctly for us even though we use ttm to manage our objects.
--- drivers/gpu/drm/bochs/bochs_mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/bochs/bochs_mm.c +2 -1
@@ -442,5 +442,6 @@ int bochs_gem_prime_mmap(struct drm_gem_object *obj, {struct bochs_bo *bo =gem_to_bochs_bo (obj); -return ttm_fbdev_mmap (vma, &bo->bo); + bo->gem.vma_node.vm_node.start = bo->bo.vma_node.vm_node.start; +return drm_gem_prime_mmap (obj, vma); }
Signature · 1 line
2.9.3
Quoted 10 lines · Gerd Hoffmann
ttm_fbdev_mmap()just doesn't work. It appears to work fine,mmap()returns success, but any attempt to actually access the mapping causes a SIGBUS.We can just use
drm_gem_prime_mmap()instead. Almost. We have to copy over the start offset from thettm_buffer_objectvm_nodeto thedrm_gem_objectvm_nodeso the offset math indrm_gem_prime_mmap()works correctly for us even though we use ttm to manage our objects.Signed-off-by Gerd Hoffmann <[email protected]>
Would be kinda neat if we could teach ttm to not have it's own vma node
...
Anyway, lgtm.
Quoted 19 lines
--- drivers/gpu/drm/bochs/bochs_mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/bochs/bochs_mm.c +2
-1@@ -442,5 +442,6 @@ int bochs_gem_prime_mmap(struct drm_gem_object *obj, {struct bochs_bo *bo =gem_to_bochs_bo (obj); -return ttm_fbdev_mmap (vma, &bo->bo); + bo->gem.vma_node.vm_node.start = bo->bo.vma_node.vm_node.start; +return drm_gem_prime_mmap (obj, vma); }Signature · 1 line
2.9.3
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 10 lines · Gerd Hoffmann
ttm_fbdev_mmap()just doesn't work. It appears to work fine,mmap()returns success, but any attempt to actually access the mapping causes a SIGBUS.We can just use
drm_gem_prime_mmap()instead. Almost. We have to copy over the start offset from thettm_buffer_objectvm_nodeto thedrm_gem_objectvm_nodeso the offset math indrm_gem_prime_mmap()works correctly for us even though we use ttm to manage our objects.Signed-off-by Gerd Hoffmann <[email protected]>
Would be kinda neat if we could teach ttm to not have it's own vma node
...
Anyway, lgtm.
Quoted 19 lines
--- drivers/gpu/drm/bochs/bochs_mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/bochs/bochs_mm.c +2
-1@@ -442,5 +442,6 @@ int bochs_gem_prime_mmap(struct drm_gem_object *obj, {struct bochs_bo *bo =gem_to_bochs_bo (obj); -return ttm_fbdev_mmap (vma, &bo->bo); + bo->gem.vma_node.vm_node.start = bo->bo.vma_node.vm_node.start; +return drm_gem_prime_mmap (obj, vma); }Signature · 1 line
2.9.3
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel