arm: mach-k3: common: Clean up ATF image startup function
Subsystems (2)
PATCH 1/1 arm: mach-k3: common: Clean up ATF image startup function
Perform some cosmetic cleanup of the ATF image startup function, namely fixing a spelling mistake, capitalization of a few words, spacing, as well aligning how errors are printed and as using panic() for cases that were using a combination of printf() + hang().
--- arch/arm/mach-k3/common.c | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-)
arch/arm/mach-k3/common.c +10 -18
@@ -45,33 +45,25 @@ void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image)/* * It is assumed that remoteproc device 1 is the corresponding -* cortex A core which runs ATF. Make sure DT reflects the same. +* Cortex-A core which runs ATF. Make sure DT reflects the same. */ ret =rproc_dev_init (1 ); -if (ret) { -printf ("%s: ATF failed to Initialize on rproc: ret= %d\n" , - __func__, ret); -hang (); - } +if (ret) +panic ("%s: ATF failed to initialize on rproc (%d)\n" , __func__, + ret); ret =rproc_load (1 , spl_image->entry_point,0x200 ); -if (ret) { -printf ("%s: ATF failed to load on rproc: ret= %d\n" , - __func__, ret); -hang (); - } +if (ret) +panic ("%s: ATF failed to load on rproc (%d)\n" , __func__, ret); -/* Add an extra newline to differentiate the ATF logs from SPL*/ +/* Add an extra newline to differentiate the ATF logs from SPL */ printf ("Starting ATF on ARM64 core...\n\n" ); ret =rproc_start (1 ); -if (ret) { -printf ("%s: ATF failed to start on rproc: ret= %d\n" , - __func__, ret); -hang (); - } +if (ret) +panic ("%s: ATF failed to start on rproc (%d)\n" , __func__, ret); -debug ("ATF started. Wait indefiniely\n" ); +debug ("ATF started. Waiting indefinitely...\n" );while (1 ) asmvolatile ("wfe" ); }
Signature · 1 line
2.17.1
PATCH 1/1 arm: mach-k3: common: Clean up ATF image startup function
Quoted 6 lines · Andreas Dannenberg
Perform some cosmetic cleanup of the ATF image startup function, namely fixing a spelling mistake, capitalization of a few words, spacing, as well aligning how errors are printed and as using
panic()for cases that were using a combination ofprintf()+hang().Signed-off-by Andreas Dannenberg <[email protected]>
Thanks and regards,
Lokesh
Quoted 7 lines · Andreas Dannenberg
Perform some cosmetic cleanup of the ATF image startup function, namely fixing a spelling mistake, capitalization of a few words, spacing, as well aligning how errors are printed and as using
panic()for cases that were using a combination ofprintf()+hang().Signed-off-by Andreas Dannenberg <[email protected]>Reviewed-by Lokesh Vutla <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190210/424b6baf/attachment.sig>