Skip to contentSkip to conversation

phy: bcm-sr-pcie: Change operation when PIPEMUX=1

PATCH Applied Ray Jui 3 participants 3 messages Feb 4, 2019 – Feb 6, 2019 Generic PHY framework

lore
Share & tools
lore

Ray Jui

author
#0 lore raw

PATCH 1/1 phy: bcm-sr-pcie: Change operation when PIPEMUX=1

From: Qingmin Liu <[email protected]>

When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.

---
 drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/broadcom/phy-bcm-sr-pcie.c +2 -2
index c10e95f86de5..96a3af126a78 100644
@@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
 static const u8 pipemux_table[] = {
 	/* PIPEMUX = 0, EP 1x16 */
 	0x00,
-	/* PIPEMUX = 1, EP 2x8 */
-	0x00,
+	/* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
+	0x80,
 	/* PIPEMUX = 2, EP 4x4 */
 	0x00,
 	/* PIPEMUX = 3, RC 2x8, cores 0, 7 */
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Looks good.

Quoted 6 lines · Ray Jui

From: Qingmin Liu <[email protected]>

When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.

Quoted 19 lines
---
  drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/broadcom/phy-bcm-sr-pcie.c +2 -2
index c10e95f86de5..96a3af126a78 100644
@@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
  static const u8 pipemux_table[] = {
  	/* PIPEMUX = 0, EP 1x16 */
  	0x00,
-	/* PIPEMUX = 1, EP 2x8 */
-	0x00,
+	/* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
+	0x80,
  	/* PIPEMUX = 2, EP 4x4 */
  	0x00,
  	/* PIPEMUX = 3, RC 2x8, cores 0, 7 */
#2 lore raw
Quoted 10 lines · Scott Branden

Looks good.

Quoted 6 lines · Ray Jui

From: Qingmin Liu <[email protected]>

When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.

merged, thanks.

-Kishon

Quoted 20 lines
Quoted 20 lines

---
  drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/broadcom/phy-bcm-sr-pcie.c +2 -2
index c10e95f86de5..96a3af126a78 100644
@@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
   static const u8 pipemux_table[] = {
       /* PIPEMUX = 0, EP 1x16 */
       0x00,
-    /* PIPEMUX = 1, EP 2x8 */
-    0x00,
+    /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
+    0x80,
       /* PIPEMUX = 2, EP 4x4 */
       0x00,
       /* PIPEMUX = 3, RC 2x8, cores 0, 7 */