Skip to contentSkip to conversation

hw: Drop useless inclusion of hw/i386/pc.h

PATCH Applied Philippe Mathieu-Daudé 6 participants 11 messages Feb 4, 2019 – Feb 6, 2019

lore
Share & tools
lore
#0 lore raw

cover hw: Drop useless inclusion of hw/i386/pc.h

Since 47973a2dbf, it is useless to include "hw/i386/pc.h" on the ppc/unicore32/sparc64 boards.

The last non-x86 targets still requiring it are alpha/hppa/mips, because the I8259 intc is still deeply mixed with the PC board.

Philippe Mathieu-Daudé (3):
hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h" hw/ppc/prep: Drop useless inclusion of "hw/i386/pc.h"

 hw/ppc/prep.c       | 1 -
 hw/sparc64/sun4u.c  | 1 -
 hw/unicore32/puv3.c | 1 -
 3 files changed, 3 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/3 hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

---
 hw/sparc64/sun4u.c | 1 -
 1 file changed, 1 deletion(-)
hw/sparc64/sun4u.c +0 -1
index f76b19e4e9..fdf3f14a29 100644
@@ -33,7 +33,6 @@
 #include "hw/pci/pci_bus.h"
 #include "hw/pci/pci_host.h"
 #include "hw/pci-host/sabre.h"
-#include "hw/i386/pc.h"
 #include "hw/char/serial.h"
 #include "hw/char/parallel.h"
 #include "hw/timer/m48t59.h"
Signature · 1 line
2.20.1
Reviewed-by on v1 1/3
#2 lore raw

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"

Quoted 14 lines · Philippe Mathieu-Daudé

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

---
 hw/sparc64/sun4u.c | 1 -
 1 file changed, 1 deletion(-)
hw/sparc64/sun4u.c +0 -0
index f76b19e4e9..fdf3f14a29 100644

hw/sparc64/sun4u.c line 38

Quoted 7 lines
hw/sparc64/sun4u.c +0 -1
@@ -33,7 +33,6 @@
 #include "hw/pci/pci_bus.h"
 #include "hw/pci/pci_host.h"
 #include "hw/pci-host/sabre.h"
-#include "hw/i386/pc.h"
 #include "hw/char/serial.h"
 #include "hw/char/parallel.h"
 #include "hw/timer/m48t59.h"
Reviewed-by on v1 1/3
#3 lore raw

Re: [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"

In reply to Philippe Mathieu-Daudé
Quoted 14 lines · Philippe Mathieu-Daudé

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

---
 hw/sparc64/sun4u.c | 1 -
 1 file changed, 1 deletion(-)
hw/sparc64/sun4u.c +0 -0
index f76b19e4e9..fdf3f14a29 100644

hw/sparc64/sun4u.c line 38

Quoted 7 lines
hw/sparc64/sun4u.c +0 -1
@@ -33,7 +33,6 @@
 #include "hw/pci/pci_bus.h"
 #include "hw/pci/pci_host.h"
 #include "hw/pci-host/sabre.h"
-#include "hw/i386/pc.h"
 #include "hw/char/serial.h"
 #include "hw/char/parallel.h"
 #include "hw/timer/m48t59.h"

ATB,

Mark.

#4 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h"

In reply to Philippe Mathieu-Daudé
Quoted 15 lines · Philippe Mathieu-Daudé

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

---
 hw/sparc64/sun4u.c | 1 -
 1 file changed, 1 deletion(-)
hw/sparc64/sun4u.c +0 -0
index f76b19e4e9..fdf3f14a29 100644

hw/sparc64/sun4u.c line 38

Quoted 7 lines
hw/sparc64/sun4u.c +0 -1
@@ -33,7 +33,6 @@
 #include "hw/pci/pci_bus.h"
 #include "hw/pci/pci_host.h"
 #include "hw/pci-host/sabre.h"
-#include "hw/i386/pc.h"
 #include "hw/char/serial.h"
 #include "hw/char/parallel.h"
 #include "hw/timer/m48t59.h"

Applied to my trivial-patches branch.

Thanks,
Laurent

#5 lore raw

PATCH 2/3 hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"

In reply to Philippe Mathieu-Daudé

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

---
 hw/unicore32/puv3.c | 1 -
 1 file changed, 1 deletion(-)
hw/unicore32/puv3.c +0 -1
index 830fe3face..b42e600f74 100644
@@ -15,7 +15,6 @@
 #include "ui/console.h"
 #include "hw/boards.h"
 #include "hw/loader.h"
-#include "hw/i386/pc.h"
 #include "sysemu/qtest.h"
 
 #undef DEBUG_PUV3
Signature · 1 line
2.20.1
Reviewed-by on v1 2/3
#6 lore raw

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"

Quoted 15 lines · Philippe Mathieu-Daudé

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

---
 hw/unicore32/puv3.c | 1 -
 1 file changed, 1 deletion(-)
hw/unicore32/puv3.c +0 -0
index 830fe3face..b42e600f74 100644

hw/unicore32/puv3.c line 20

Quoted 7 lines
hw/unicore32/puv3.c +0 -1
@@ -15,7 +15,6 @@
 #include "ui/console.h"
 #include "hw/boards.h"
 #include "hw/loader.h"
-#include "hw/i386/pc.h"
 #include "sysemu/qtest.h"
 
 #undef DEBUG_PUV3
#7 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"

In reply to Philippe Mathieu-Daudé
Quoted 15 lines · Philippe Mathieu-Daudé

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

---
 hw/unicore32/puv3.c | 1 -
 1 file changed, 1 deletion(-)
hw/unicore32/puv3.c +0 -0
index 830fe3face..b42e600f74 100644

hw/unicore32/puv3.c line 20

Quoted 7 lines
hw/unicore32/puv3.c +0 -1
@@ -15,7 +15,6 @@
 #include "ui/console.h"
 #include "hw/boards.h"
 #include "hw/loader.h"
-#include "hw/i386/pc.h"
 #include "sysemu/qtest.h"
 
 #undef DEBUG_PUV3

Applied to my trivial-patches branch.

Thanks,
Laurent

#8 lore raw

PATCH 3/3 hw/ppc/prep: Drop useless inclusion of "hw/i386/pc.h"

In reply to Philippe Mathieu-Daudé

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

---
 hw/ppc/prep.c | 1 -
 1 file changed, 1 deletion(-)
hw/ppc/prep.c +0 -1
index 7bda86a7d0..847d320465 100644
@@ -26,7 +26,6 @@
 #include "cpu.h"
 #include "hw/hw.h"
 #include "hw/timer/m48t59.h"
-#include "hw/i386/pc.h"
 #include "hw/char/serial.h"
 #include "hw/block/fdc.h"
 #include "net/net.h"
Signature · 1 line
2.20.1
Applied
#10 lore raw

Re: [Qemu-devel] [PATCH 3/3] hw/ppc/prep: Drop useless inclusion of "hw/i386/pc.h"

Quoted 8 lines · Hervé Poussineau

Le 04/02/2019 à 22:04, Philippe Mathieu-Daudé a écrit :

Quoted 5 lines

In 47973a2dbf we split the last generic chipset out of the PC board, but forgot to remove the include of "hw/i386/pc.h". Since it is now unused, remove it.

Applied to ppc-for-4.0, thanks.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson