Skip to contentSkip to conversation

package/pugixml: force-enable 'long long' support to support gcc<4.8

PATCH New Thomas De Schampheleire 2 participants 3 messages Feb 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/pugixml: force-enable 'long long' support to support gcc<4.8

From: Thomas De Schampheleire <[email protected]>

Although pugixml will enable 'long long' support automatically if it detects C++11 (gcc 4.8+), we would like to support older gcc compilers too.

---
 package/pugixml/pugixml.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/pugixml/pugixml.mk +6 -0
index acf22604c4..8edaddd827 100644
@@ -10,6 +10,12 @@ PUGIXML_LICENSE = MIT
 PUGIXML_LICENSE_FILES = readme.txt
 PUGIXML_INSTALL_STAGING = YES
 
+# Pugixml will automatically enable 'long long' support on C++11 compilers,
+# which means gcc 4.8+. As gcc always supports the 'long long' type,
+# force-enable this option to support older gcc versions. See also:
+# https://gcc.gnu.org/onlinedocs/gcc/Long-Long.html
+PUGIXML_BUILD_DEFINES += PUGIXML_HAS_LONG_LONG
+
 ifeq ($(BR2_PACKAGE_PUGIXML_XPATH_SUPPORT),)
 PUGIXML_BUILD_DEFINES += PUGIXML_NO_XPATH
 endif
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 package/pugixml: force-enable 'long long' support to support gcc<4.8

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

From: Thomas De Schampheleire <[email protected]> Although pugixml will enable 'long long' support automatically if it detects C++11 (gcc 4.8+), we would like to support older gcc compilers too.

4.8 is really old, but OK.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/pugixml: force-enable 'long long' support to support gcc<4.8

El mar., 5 feb. 2019 a las 20:55, Peter Korsgaard
(<[email protected]>) escribi?:

Quoted 10 lines
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

From: Thomas De Schampheleire <[email protected]> Although pugixml will enable 'long long' support automatically if it detects C++11 (gcc 4.8+), we would like to support older gcc compilers too.

4.8 is really old, but OK.

Yes. The Marvell Octeon toolchain still has 4.7.0...

Thanks for applying...

/Thomas