Skip to contentSkip to conversation

xfs/252: requires fallocate support for preallocation

PATCH In review Christoph Hellwig 2 participants 2 messages Feb 5, 2019 – Feb 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/252: requires fallocate support for preallocation

xfs/252 has a few feature tests, but misses checking for preallocation support. Because of that it will fail instead of not being run for and XFS file system in always COW mode.

---
 tests/xfs/252 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/252 +1 -0
index df795b81..42650ad1 100755
@@ -31,6 +31,7 @@ _supported_fs xfs
 _supported_os Linux
 
 _require_test
+_require_xfs_io_command "fallocate"
 _require_xfs_io_command "fpunch"
 _require_xfs_io_command "fiemap"
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 14 lines · Christoph Hellwig

xfs/252 has a few feature tests, but misses checking for preallocation support. Because of that it will fail instead of not being run for and XFS file system in always COW mode.

---
 tests/xfs/252 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/252 +0 -0
index df795b81..42650ad1 100755

tests/xfs/252 _supported_fs xfs · line 34

Quoted 4 lines
tests/xfs/252 +1 -0
@@ -31,6 +31,7 @@ _supported_fs xfs
 _supported_os Linux
 
 _require_test
+_require_xfs_io_command "fallocate"

The xfs_io command should be "falloc", fixed on commit :)

Thanks,
Eryu

Quoted 6 lines
tests/xfs/252 +0 -0
 _require_xfs_io_command "fpunch"
 _require_xfs_io_command "fiemap"
 
Signature · 1 line
2.20.1