Skip to contentSkip to conversation

WPE WebKit

PATCH New Francois Perrad 3 participants 12 messages Feb 5, 2019 – Feb 11, 2019

lore
Share & tools
lore
#0 lore raw

v2 cover WPE WebKit

Another port of WebKit (https://wpewebkit.org/), a project started in 2018.

v1 -> v2
- wpewebkit : use WPEWEBKIT_ARCH_SUPPORTS variables (duplicated from webkitgtk)
- cog : use release 0.2.0
- cog : add dbus as mandatory dependency
- cog : use the default setting of COG_DBUS_SYSTEM_BUS

rfc -> v1
- full refactor after Adrian's review
- libwpe : version 1.0.0 (stable) instead of 1.1.0 (instable)
- wbebackend-fdo : version 1.0.0 (stable) instead of 1.1.0 (instable)
- add cog, a WPE WebKit launcher

Francois Perrad (4):
libwpe: new package
wpebackend-fdo: new package
wpewebkit: new package
cog: new package

 DEVELOPERS                                 |   8 ++
 package/Config.in                          |   4 +
 package/cog/Config.in                      |  21 ++++
 package/cog/cog.hash                       |   5 +
 package/cog/cog.mk                         |  17 +++
 package/libwpe/Config.in                   |  13 +++
 package/libwpe/libwpe.hash                 |   7 ++
 package/libwpe/libwpe.mk                   |  22 ++++
 package/wpebackend-fdo/Config.in           |  19 ++++
 package/wpebackend-fdo/wpebackend-fdo.hash |   7 ++
 package/wpebackend-fdo/wpebackend-fdo.mk   |  15 +++
 package/wpewebkit/Config.in                | 114 +++++++++++++++++++++
 package/wpewebkit/wpewebkit.hash           |   8 ++
 package/wpewebkit/wpewebkit.mk             |  61 +++++++++++
 14 files changed, 321 insertions(+)
 create mode 100644 package/cog/Config.in
 create mode 100644 package/cog/cog.hash
 create mode 100644 package/cog/cog.mk
 create mode 100644 package/libwpe/Config.in
 create mode 100644 package/libwpe/libwpe.hash
 create mode 100644 package/libwpe/libwpe.mk
 create mode 100644 package/wpebackend-fdo/Config.in
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.hash
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.mk
 create mode 100644 package/wpewebkit/Config.in
 create mode 100644 package/wpewebkit/wpewebkit.hash
 create mode 100644 package/wpewebkit/wpewebkit.mk
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/4 libwpe: new package

---
 DEVELOPERS                 |  2 ++
 package/Config.in          |  1 +
 package/libwpe/Config.in   | 13 +++++++++++++
 package/libwpe/libwpe.hash |  7 +++++++
 package/libwpe/libwpe.mk   | 22 ++++++++++++++++++++++
 5 files changed, 45 insertions(+)
 create mode 100644 package/libwpe/Config.in
 create mode 100644 package/libwpe/libwpe.hash
 create mode 100644 package/libwpe/libwpe.mk
DEVELOPERS +2 -0
index 7a49852cd..c82ec889f 100644
@@ -67,6 +67,7 @@ F:	package/sngrep/
 N:	Adrian Perez de Castro <[email protected]>
 F:	package/brotli/
 F:	package/libepoxy/
+F:	package/libwpe/
 F:	package/webkitgtk/
 F:	package/woff2/
 
@@ -810,6 +811,7 @@ F:	package/gdbm/
 F:	package/libtomcrypt/
 F:	package/libtommath/
 F:	package/libump/
+F:	package/libwpe/
 F:	package/linenoise/
 F:	package/ljlinenoise/
 F:	package/lpeg/
package/Config.in +1 -0
index 037e81e48..1c3080c24 100644
@@ -1286,6 +1286,7 @@ menu "Graphics"
 	source "package/libva-intel-driver/Config.in"
 	source "package/libvdpau/Config.in"
 	source "package/libvips/Config.in"
+	source "package/libwpe/Config.in"
 	source "package/menu-cache/Config.in"
 	source "package/opencv/Config.in"
 	source "package/opencv3/Config.in"
package/libwpe/Config.in new file +13 -0
new file mode 100644
index 000000000..c11c85398
@@ -0,0 +1,13 @@
+comment "libwpe needs a toolchain w/ C++, dynamic library and an OpenEGL-capable backend"
+	depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS
+
+config BR2_PACKAGE_LIBWPE
+	bool "libwpe"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_LIBXKBCOMMON
+	help
+	  Base library for the WPE WebKit port.
+
+	  https://wpewebkit.org/
package/libwpe/libwpe.hash new file +7 -0
new file mode 100644
index 000000000..58dba92e6
@@ -0,0 +1,7 @@
+# From https://wpewebkit.org/releases/libwpe-1.0.0.tar.xz.sums
+md5 b5ea32bd644811d5c6433cf1439763f7 libwpe-1.0.0.tar.xz
+sha1 6e51591c00a9a6128e19920807e6874794c723fd libwpe-1.0.0.tar.xz
+sha256 aff11612123f9ab85a8b9a4bcdfb3a7503eba0a0d2d96f2cdecd30e911091719 libwpe-1.0.0.tar.xz
+
+# Hashes for license files:
+sha256 6efc9991641b47b1f4e727db7f090d0ade00117dcbbc74be622f2baceddb1f22 COPYING
package/libwpe/libwpe.mk new file +22 -0
new file mode 100644
index 000000000..aad1214e1
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libwpe
+#
+################################################################################
+
+LIBWPE_VERSION = 1.0.0
+LIBWPE_SITE = https://wpewebkit.org/releases
+LIBWPE_SOURCE = libwpe-$(LIBWPE_VERSION).tar.xz
+LIBWPE_INSTALL_STAGING = YES
+LIBWPE_LICENSE = BSD-2-Clause
+LIBWPE_LICENSE_FILES = COPYING
+LIBWPE_DEPENDENCIES = libegl libxkbcommon
+
+# Workaround for https://github.com/raspberrypi/userland/issues/316
+ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
+LIBWPE_CONF_OPTS += \
+	-DCMAKE_C_FLAGS='$(TARGET_CFLAGS) -D_GNU_SOURCE' \
+	-DCMAKE_CXX_FLAGS='$(TARGET_CFLAGS) -D_GNU_SOURCE'
+endif
+
+$(eval $(cmake-package))
Signature · 1 line
2.17.1
#2 lore raw

PATCH v2 2/4 wpebackend-fdo: new package

In reply to Francois Perrad
---
 DEVELOPERS                                 |  2 ++
 package/Config.in                          |  1 +
 package/wpebackend-fdo/Config.in           | 19 +++++++++++++++++++
 package/wpebackend-fdo/wpebackend-fdo.hash |  7 +++++++
 package/wpebackend-fdo/wpebackend-fdo.mk   | 15 +++++++++++++++
 5 files changed, 44 insertions(+)
 create mode 100644 package/wpebackend-fdo/Config.in
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.hash
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.mk
DEVELOPERS +2 -0
index c82ec889f..792cf8534 100644
@@ -70,6 +70,7 @@ F:	package/libepoxy/
 F:	package/libwpe/
 F:	package/webkitgtk/
 F:	package/woff2/
+F:	package/wpebackend-fdo/
 
 N:	Adrien Gallou?t <[email protected]>
 F:	package/bird/
@@ -830,6 +831,7 @@ F:	package/qemu/
 F:	package/sdl2_mixer/
 F:	package/sdl2_net/
 F:	package/tekui/
+F:	package/wpebackend-fdo/
 F:	package/wsapi-fcgi/
 F:	package/wsapi-xavante/
 F:	utils/scancpan
package/Config.in +1 -0
index 1c3080c24..76244b04b 100644
@@ -1305,6 +1305,7 @@ menu "Graphics"
 	source "package/webkitgtk/Config.in"
 	source "package/webp/Config.in"
 	source "package/woff2/Config.in"
+	source "package/wpebackend-fdo/Config.in"
 	source "package/zbar/Config.in"
 	source "package/zxing-cpp/Config.in"
 endmenu
package/wpebackend-fdo/Config.in new file +19 -0
new file mode 100644
index 000000000..06392c93f
@@ -0,0 +1,19 @@
+comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend"
+	depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
+		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+
+config BR2_PACKAGE_WPEBACKEND_FDO
+	bool "wpebackend-fdo"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
+	depends on BR2_USE_WCHAR # gettext
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBWPE
+	select BR2_PACKAGE_WAYLAND
+	help
+	  WPEBackend interface using freedesktop.org API.
+
+	  https://wpewebkit.org/
package/wpebackend-fdo/wpebackend-fdo.hash new file +7 -0
new file mode 100644
index 000000000..20c89d324
@@ -0,0 +1,7 @@
+# From https://wpewebkit.org/releases/wpebackend-fdo-1.0.0.tar.xz.sums
+md5 5318728afb3bf7417293af67ce427963 wpebackend-fdo-1.0.0.tar.xz
+sha1 7ee22bc1d585616f4ad2047d8be54ec396486211 wpebackend-fdo-1.0.0.tar.xz
+sha256 7a747f87a1ae46d30144369050e3ce348b58986d04e1a139ba75c198fa636729 wpebackend-fdo-1.0.0.tar.xz
+
+# Hashes for license files:
+sha256 c9f6803371047fad3e72200ec6cd226329a5ee08ac61104c8211c2761fb46825 COPYING
package/wpebackend-fdo/wpebackend-fdo.mk new file +15 -0
new file mode 100644
index 000000000..06c87cb9b
@@ -0,0 +1,15 @@
+################################################################################
+#
+# wpebackend-fdo
+#
+################################################################################
+
+WPEBACKEND_FDO_VERSION = 1.0.0
+WPEBACKEND_FDO_SITE = https://wpewebkit.org/releases
+WPEBACKEND_FDO_SOURCE = wpebackend-fdo-$(WPEBACKEND_FDO_VERSION).tar.xz
+WPEBACKEND_FDO_INSTALL_STAGING = YES
+WPEBACKEND_FDO_LICENSE = BSD-2-Clause
+WPEBACKEND_FDO_LICENSE_FILES = COPYING
+WPEBACKEND_FDO_DEPENDENCIES = libglib2 libwpe wayland
+
+$(eval $(cmake-package))
Signature · 1 line
2.17.1
#3 lore raw

PATCH v2 2/4 wpebackend-fdo: new package

Hello,

Quoted 8 lines · On Tue, 5 Feb 2019 21:41:50 +0100 Francois Perrad <[email protected]> wrote:
package/wpebackend-fdo/Config.in new file +2 -0
new file mode 100644
index 000000000..06392c93f
@@ -0,0 +1,19 @@
+comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend"
+	depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \

package/wpebackend-fdo/Config.in line 12

Quoted 10 lines
package/wpebackend-fdo/Config.in new file +10 -0
+		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+
+config BR2_PACKAGE_WPEBACKEND_FDO
+	bool "wpebackend-fdo"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
+	depends on BR2_USE_WCHAR # gettext
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_PACKAGE_HAS_LIBEGL

I changed this like this:

+       depends on !BR2_STATIC_LIBS # wayland
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, libglib2
+       depends on BR2_USE_WCHAR # libglib2
+       depends on BR2_USE_MMU # libglib2
+       depends on BR2_PACKAGE_HAS_LIBEGL

i.e we care more about why this particular package needed those "depends on" rather than why those "depends on" where needed by the packages we are selecting.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH v2 3/4 wpewebkit: new package

In reply to Francois Perrad
---
 DEVELOPERS                       |   2 +
 package/Config.in                |   1 +
 package/wpewebkit/Config.in      | 114 +++++++++++++++++++++++++++++++
 package/wpewebkit/wpewebkit.hash |   8 +++
 package/wpewebkit/wpewebkit.mk   |  61 +++++++++++++++++
 5 files changed, 186 insertions(+)
 create mode 100644 package/wpewebkit/Config.in
 create mode 100644 package/wpewebkit/wpewebkit.hash
 create mode 100644 package/wpewebkit/wpewebkit.mk
DEVELOPERS +2 -0
index 792cf8534..938a9365a 100644
@@ -71,6 +71,7 @@ F:	package/libwpe/
 F:	package/webkitgtk/
 F:	package/woff2/
 F:	package/wpebackend-fdo/
+F:	package/wpewebkit/
 
 N:	Adrien Gallou?t <[email protected]>
 F:	package/bird/
@@ -832,6 +833,7 @@ F:	package/sdl2_mixer/
 F:	package/sdl2_net/
 F:	package/tekui/
 F:	package/wpebackend-fdo/
+F:	package/wpewebkit/
 F:	package/wsapi-fcgi/
 F:	package/wsapi-xavante/
 F:	utils/scancpan
package/Config.in +1 -0
index 76244b04b..693de953d 100644
@@ -1306,6 +1306,7 @@ menu "Graphics"
 	source "package/webp/Config.in"
 	source "package/woff2/Config.in"
 	source "package/wpebackend-fdo/Config.in"
+	source "package/wpewebkit/Config.in"
 	source "package/zbar/Config.in"
 	source "package/zxing-cpp/Config.in"
 endmenu
package/wpewebkit/Config.in new file +114 -0

114 lines not on this page · raw message

package/wpewebkit/wpewebkit.hash new file +8 -0
new file mode 100644
index 000000000..39937a346
@@ -0,0 +1,8 @@
+# From https://wpewebkit.org/releases/wpewebkit-2.22.3.tar.xz.sums
+md5 6d0c693ea49a93fc9e701cf784245ea5 wpewebkit-2.22.3.tar.xz
+sha1 d8a22bec787f38939c7922dc43bf27c9144cef74 wpewebkit-2.22.3.tar.xz
+sha256 241f177cded1a4ba3088716650eaaac25588878882170789b3c630ac45dbb2fa wpewebkit-2.22.3.tar.xz
+
+# Hashes for license files:
+sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
+sha256 f2b3bd09663381deb99721109d22b47af1213bb43007a8b56a06c6375c8050ce Source/WebCore/LICENSE-LGPL-2.1
package/wpewebkit/wpewebkit.mk new file +61 -0

61 lines not on this page · raw message

Signature · 1 line
2.17.1
#5 lore raw

PATCH v2 3/4 wpewebkit: new package

Hello Fran?ois,

Thanks for the update to the patch set. This is looking good now in my eyes, and I think the whole patch series can be merged now.

Quoted 1 line · Francois Perrad
Quoted 251 lines
---
 DEVELOPERS                       |   2 +
 package/Config.in                |   1 +
 package/wpewebkit/Config.in      | 114 +++++++++++++++++++++++++++++++
 package/wpewebkit/wpewebkit.hash |   8 +++
 package/wpewebkit/wpewebkit.mk   |  61 +++++++++++++++++
 5 files changed, 186 insertions(+)
 create mode 100644 package/wpewebkit/Config.in
 create mode 100644 package/wpewebkit/wpewebkit.hash
 create mode 100644 package/wpewebkit/wpewebkit.mk
DEVELOPERS +2 -0
index 792cf8534..938a9365a 100644
@@ -71,6 +71,7 @@ F:	package/libwpe/
 F:	package/webkitgtk/
 F:	package/woff2/
 F:	package/wpebackend-fdo/
+F:	package/wpewebkit/
 
 N:	Adrien Gallou?t <[email protected]>
 F:	package/bird/
@@ -832,6 +833,7 @@ F:	package/sdl2_mixer/
 F:	package/sdl2_net/
 F:	package/tekui/
 F:	package/wpebackend-fdo/
+F:	package/wpewebkit/
 F:	package/wsapi-fcgi/
 F:	package/wsapi-xavante/
 F:	utils/scancpan
package/Config.in +1 -0
index 76244b04b..693de953d 100644
@@ -1306,6 +1306,7 @@ menu "Graphics"
 	source "package/webp/Config.in"
 	source "package/woff2/Config.in"
 	source "package/wpebackend-fdo/Config.in"
+	source "package/wpewebkit/Config.in"
 	source "package/zbar/Config.in"
 	source "package/zxing-cpp/Config.in"
 endmenu
package/wpewebkit/Config.in new file +114 -0
new file mode 100644
index 000000000..1fb89f1f6
@@ -0,0 +1,114 @@
+config BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
+	bool
+	# ARM needs BLX, so v5t+, BE completely untested so disabled
+	default y if BR2_arm && !BR2_ARM_CPU_ARMV4
+	default y if BR2_aarch64 || BR2_aarch64_be
+	default y if BR2_i386 || BR2_x86_64
+	# Disabled on MIPS big endian due to sigbus
+	default y if BR2_mipsel || BR2_mips64el
+	# Disabled on PowerPC pending runtime testing
+	# Disabled on SuperH because of segfault
+	depends on BR2_USE_MMU # libglib2
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
+
+config BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS_JIT
+	bool
+	# ARM needs NEON for JIT.
+	default y if BR2_ARM_CPU_HAS_NEON
+	# AArch64 is supported upstream but not well tested on big-endian mode.
+	default y if BR2_aarch64
+	# i386 & x86_64 don't have any special requirements.
+	default y if BR2_i386
+	default y if BR2_x86_64
+	# JIT is known not to work on MIPS64.
+	# Plain MIPS32 (pre R2) is not well tested and likely broken, and R6
+	# is unsupported, see https://bugs.webkit.org/show_bug.cgi?id=191258
+	# The MIPS support is completely untested in big-endian mode.
+	default y if BR2_mipsel && BR2_MIPS_CPU_MIPS32R2
+	default y if BR2_mipsel && BR2_MIPS_CPU_MIPS32R5
+
+comment "wpewebkit needs an OpenGL ES w/ EGL backend"
+	depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
+
+config BR2_PACKAGE_WPEWEBKIT
+	bool "wpewebkit"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on !BR2_BINFMT_FLAT # icu
+	depends on BR2_INSTALL_LIBSTDCPP # icu
+	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
+	depends on BR2_USE_WCHAR # gettext
+	depends on BR2_PACKAGE_HAS_LIBGLES
+	depends on BR2_PACKAGE_HAS_LIBEGL
+	depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
+	select BR2_PACKAGE_CAIRO
+	select BR2_PACKAGE_CAIRO_PNG
+	select BR2_PACKAGE_HARFBUZZ
+	select BR2_PACKAGE_ICU
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBEPOXY
+	select BR2_PACKAGE_LIBGCRYPT
+	select BR2_PACKAGE_LIBPNG
+	select BR2_PACKAGE_LIBSOUP
+	select BR2_PACKAGE_LIBTASN1
+	select BR2_PACKAGE_LIBXSLT
+	select BR2_PACKAGE_WAYLAND_PROTOCOLS
+	select BR2_PACKAGE_WEBP
+	select BR2_PACKAGE_WEBP_DEMUX
+	select BR2_PACKAGE_WPEBACKEND_FDO
+	help
+	  WPE (Web Platform for Embedded) port of the WebKit engine,
+	  to allow embedders to create simple and performant systems
+	  based on Web platform technologies.
+
+	  https://wpewebkit.org/
+
+if BR2_PACKAGE_WPEWEBKIT
+
+config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
+	bool "multimedia support"
+	select BR2_PACKAGE_GSTREAMER1
+	select BR2_PACKAGE_GST1_PLUGINS_BAD
+	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PLAYBACK
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ISOMP4
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_RTSP
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
+	select BR2_PACKAGE_GST1_LIBAV
+	help
+	  This option pulls in all of the required dependencies
+	  to enable multimedia (video/audio) support.
+
+if BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
+
+config BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL
+	bool "use gstreamer-gl"
+	default y
+	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
+	help
+	  Use the GStreamer GL elements for handling video content.
+	  This is recommended as it improves performance of video
+	  playback. In some target configurations incorrect rendering
+	  might be produced, and disabling this option may help.
+
+endif
+
+config BR2_PACKAGE_WPEWEBKIT_WEBDRIVER
+	bool "WebDriver support"
+	help
+	  Enable support for WebDriver. This will build and install the
+	  WebKitWebDriver program in the target.
+
+endif
package/wpewebkit/wpewebkit.hash new file +8 -0
new file mode 100644
index 000000000..39937a346
@@ -0,0 +1,8 @@
+# From https://wpewebkit.org/releases/wpewebkit-2.22.3.tar.xz.sums
+md5 6d0c693ea49a93fc9e701cf784245ea5 wpewebkit-2.22.3.tar.xz
+sha1 d8a22bec787f38939c7922dc43bf27c9144cef74 wpewebkit-2.22.3.tar.xz
+sha256 241f177cded1a4ba3088716650eaaac25588878882170789b3c630ac45dbb2fa wpewebkit-2.22.3.tar.xz
+
+# Hashes for license files:
+sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
+sha256 f2b3bd09663381deb99721109d22b47af1213bb43007a8b56a06c6375c8050ce Source/WebCore/LICENSE-LGPL-2.1
package/wpewebkit/wpewebkit.mk new file +61 -0
new file mode 100644
index 000000000..e5bae6347
@@ -0,0 +1,61 @@
+################################################################################
+#
+# wpewebkit
+#
+################################################################################
+
+WPEWEBKIT_VERSION = 2.22.3
+WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
+WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
+WPEWEBKIT_INSTALL_STAGING = YES
+WPEWEBKIT_LICENSE = LGPL-2.1+, BSD-2-Clause
+WPEWEBKIT_LICENSE_FILES = \
+	Source/WebCore/LICENSE-APPLE \
+	Source/WebCore/LICENSE-LGPL-2.1
+WPEWEBKIT_DEPENDENCIES = host-gperf host-python host-ruby \
+	harfbuzz cairo icu jpeg libepoxy libgcrypt libgles libsoup libtasn1 \
+	libpng libxslt wayland-protocols webp wpebackend-fdo
+
+WPEWEBKIT_CONF_OPTS = \
+	-DPORT=WPE \
+	-DENABLE_API_TESTS=OFF \
+	-DENABLE_MINIBROWSER=OFF
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS_JIT),y)
+WEBKITGTK_CONF_OPTS += -DENABLE_JIT=ON
+else
+WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
+WPEWEBKIT_CONF_OPTS += \
+	-DENABLE_VIDEO=ON \
+	-DENABLE_WEB_AUDIO=ON
+WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
+else
+WPEWEBKIT_CONF_OPTS += \
+	-DENABLE_VIDEO=OFF \
+	-DENABLE_WEB_AUDIO=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL),y)
+WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=ON
+WPEWEBKIT_DEPENDENCIES += gst1-plugins-bad
+else
+WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_WEBDRIVER),y)
+WPEWEBKIT_CONF_OPTS += -DENABLE_WEBDRIVER=ON
+else
+WPEWEBKIT_CONF_OPTS += -DENABLE_WEBDRIVER=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_WOFF2),y)
+WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=ON
+WPEWEBKIT_DEPENDENCIES += woff2
+else
+WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
+endif
+
+$(eval $(cmake-package))
Signature · 6 lines
2.17.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190205/f6dc5302/attachment.asc>

#6 lore raw

PATCH v2 3/4 wpewebkit: new package

In reply to Francois Perrad

Hello,

Quoted 1 line · On Tue, 5 Feb 2019 21:41:51 +0100 Francois Perrad <[email protected]> wrote:

+comment "wpewebkit needs an OpenGL ES w/ EGL backend"

This comment lacked a:

depends BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS depends on !BR2_BINFMT_FLAT

package/wpewebkit/Config.in line 32

Quoted 1 line
package/wpewebkit/Config.in new file +1 -0
+	depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL

There was no comment about all the other "depends on" that you have below, so I fixed that.

package/wpewebkit/Config.in line 44

Quoted 11 lines
package/wpewebkit/Config.in new file +11 -0
+config BR2_PACKAGE_WPEWEBKIT
+	bool "wpewebkit"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on !BR2_BINFMT_FLAT # icu
+	depends on BR2_INSTALL_LIBSTDCPP # icu
+	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
+	depends on BR2_USE_WCHAR # gettext
+	depends on BR2_PACKAGE_HAS_LIBGLES
+	depends on BR2_PACKAGE_HAS_LIBEGL
+	depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS

I fixed this to:

+       depends on !BR2_STATIC_LIBS # wayland
+       depends on !BR2_BINFMT_FLAT # icu
+       depends on BR2_INSTALL_LIBSTDCPP # harfbuzz, icu
+       depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, icu, libsoup
+       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
+       depends on BR2_HOST_GCC_AT_LEAST_4_8 # icu
+       depends on BR2_USE_WCHAR # icu, libsoup
+       depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
+       depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy
+       depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS

i.e, mainly BR2_HOST_GCC_AT_LEAST_4_8 was missing, and I changed the comments to be more relevant (IMO).

package/wpewebkit/Config.in line 56

Quoted 12 lines
package/wpewebkit/Config.in new file +12 -0
+	select BR2_PACKAGE_CAIRO
+	select BR2_PACKAGE_CAIRO_PNG
+	select BR2_PACKAGE_HARFBUZZ
+	select BR2_PACKAGE_ICU
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBEPOXY
+	select BR2_PACKAGE_LIBGCRYPT
+	select BR2_PACKAGE_LIBPNG
+	select BR2_PACKAGE_LIBSOUP
+	select BR2_PACKAGE_LIBTASN1
+	select BR2_PACKAGE_LIBXSLT
+	select BR2_PACKAGE_WAYLAND_PROTOCOLS

You can't select this package without selecting BR2_PACKAGE_WAYLAND. I know wpebackend-fdo selects wayland, but to me it looks more obvious if we also select BR2_PACKAGE_WAYLAND here.

package/wpewebkit/wpewebkit.mk line 27

Quoted 9 lines
package/wpewebkit/wpewebkit.mk new file +9 -0
+WPEWEBKIT_CONF_OPTS = \
+	-DPORT=WPE \
+	-DENABLE_API_TESTS=OFF \
+	-DENABLE_MINIBROWSER=OFF
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS_JIT),y)
+WEBKITGTK_CONF_OPTS += -DENABLE_JIT=ON
+else
+WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF

Notice the bad copy/paste here ? It should be WPEWEBKIT_CONF_OPTS, not WEBKITGTK_CONF_OPTS.

I fixed up this issue and the minor nits above and applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#7 lore raw

PATCH v2 4/4 cog: new package

In reply to Francois Perrad
---
 DEVELOPERS            |  2 ++
 package/Config.in     |  1 +
 package/cog/Config.in | 21 +++++++++++++++++++++
 package/cog/cog.hash  |  5 +++++
 package/cog/cog.mk    | 17 +++++++++++++++++
 5 files changed, 46 insertions(+)
 create mode 100644 package/cog/Config.in
 create mode 100644 package/cog/cog.hash
 create mode 100644 package/cog/cog.mk
DEVELOPERS +2 -0
index 938a9365a..3017b6e68 100644
@@ -66,6 +66,7 @@ F:	package/sngrep/
 
 N:	Adrian Perez de Castro <[email protected]>
 F:	package/brotli/
+F:	package/cog/
 F:	package/libepoxy/
 F:	package/libwpe/
 F:	package/webkitgtk/
@@ -807,6 +808,7 @@ F:	configs/olimex_a20_olinuxino_*
 F:	package/4th/
 F:	package/botan/
 F:	package/chipmunk/
+F:	package/cog/
 F:	package/dado/
 F:	package/ficl/
 F:	package/gdbm/
package/Config.in +1 -0
index 693de953d..08ee2094c 100644
@@ -259,6 +259,7 @@ endmenu
 menu "Graphic libraries and applications (graphic/text)"
 
 comment "Graphic applications"
+	source "package/cog/Config.in"
 	source "package/fswebcam/Config.in"
 	source "package/ghostscript/Config.in"
 	source "package/glmark2/Config.in"
package/cog/Config.in new file +21 -0
new file mode 100644
index 000000000..4aee4ac91
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_COG
+	bool "cog"
+	depends on BR2_PACKAGE_WPEWEBKIT
+	select BR2_PACKAGE_DBUS
+	help
+	  Single "window" launcher for the WebKit WPE port, and
+	  helper library for implementing WPE launcher. It does
+	  not provide any chrome, and is suitable to be used
+	  as a Web application container.
+
+if BR2_PACKAGE_COG
+
+config BR2_PACKAGE_COG_PROGRAMS_HOME_URI
+	string "home uri"
+	default "https://wpewebkit.org"
+	help
+	  Default URI to open when "cog" is launched. If an empty
+	  string is used, there is no default and the URI to open
+	  must be always specified in the command line.
+
+endif
package/cog/cog.hash new file +5 -0
new file mode 100644
index 000000000..97daf7274
@@ -0,0 +1,5 @@
+# Locally generated
+sha256 a6abadb78395226bac2e1dd5467feab2cc8c493eab6894a09a51a8e072e38c06  cog-v0.2.0.tar.gz
+
+# Hashes for license files:
+sha256 e6c42d93c68b292bcccf6d2ec3e13da85df90b718ba27c2c2a01053a9d009252  COPYING
package/cog/cog.mk new file +17 -0
new file mode 100644
index 000000000..43f13152c
@@ -0,0 +1,17 @@
+################################################################################
+#
+# cog
+#
+################################################################################
+
+COG_VERSION = v0.2.0
+COG_SITE = $(call github,Igalia,cog,$(COG_VERSION))
+COG_DEPENDENCIES = dbus wpewebkit wpebackend-fdo
+COG_LICENSE = MIT
+COG_LICENSE_FILES = COPYING
+COG_CONF_OPTS = \
+	-DCOG_BUILD_PROGRAMS=ON \
+	-DCOG_PLATFORM_FDO=ON \
+	-DCOG_HOME_URI='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))'
+
+$(eval $(cmake-package))
Signature · 1 line
2.17.1
#8 lore raw

PATCH v2 4/4 cog: new package

Quoted 1 line · Francois Perrad
Quoted 111 lines
---
 DEVELOPERS            |  2 ++
 package/Config.in     |  1 +
 package/cog/Config.in | 21 +++++++++++++++++++++
 package/cog/cog.hash  |  5 +++++
 package/cog/cog.mk    | 17 +++++++++++++++++
 5 files changed, 46 insertions(+)
 create mode 100644 package/cog/Config.in
 create mode 100644 package/cog/cog.hash
 create mode 100644 package/cog/cog.mk
DEVELOPERS +2 -0
index 938a9365a..3017b6e68 100644
@@ -66,6 +66,7 @@ F:	package/sngrep/
 
 N:	Adrian Perez de Castro <[email protected]>
 F:	package/brotli/
+F:	package/cog/
 F:	package/libepoxy/
 F:	package/libwpe/
 F:	package/webkitgtk/
@@ -807,6 +808,7 @@ F:	configs/olimex_a20_olinuxino_*
 F:	package/4th/
 F:	package/botan/
 F:	package/chipmunk/
+F:	package/cog/
 F:	package/dado/
 F:	package/ficl/
 F:	package/gdbm/
package/Config.in +1 -0
index 693de953d..08ee2094c 100644
@@ -259,6 +259,7 @@ endmenu
 menu "Graphic libraries and applications (graphic/text)"
 
 comment "Graphic applications"
+	source "package/cog/Config.in"
 	source "package/fswebcam/Config.in"
 	source "package/ghostscript/Config.in"
 	source "package/glmark2/Config.in"
package/cog/Config.in new file +21 -0
new file mode 100644
index 000000000..4aee4ac91
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_COG
+	bool "cog"
+	depends on BR2_PACKAGE_WPEWEBKIT
+	select BR2_PACKAGE_DBUS
+	help
+	  Single "window" launcher for the WebKit WPE port, and
+	  helper library for implementing WPE launcher. It does
+	  not provide any chrome, and is suitable to be used
+	  as a Web application container.
+
+if BR2_PACKAGE_COG
+
+config BR2_PACKAGE_COG_PROGRAMS_HOME_URI
+	string "home uri"
+	default "https://wpewebkit.org"
+	help
+	  Default URI to open when "cog" is launched. If an empty
+	  string is used, there is no default and the URI to open
+	  must be always specified in the command line.
+
+endif
package/cog/cog.hash new file +5 -0
new file mode 100644
index 000000000..97daf7274
@@ -0,0 +1,5 @@
+# Locally generated
+sha256 a6abadb78395226bac2e1dd5467feab2cc8c493eab6894a09a51a8e072e38c06  cog-v0.2.0.tar.gz
+
+# Hashes for license files:
+sha256 e6c42d93c68b292bcccf6d2ec3e13da85df90b718ba27c2c2a01053a9d009252  COPYING
package/cog/cog.mk new file +17 -0
new file mode 100644
index 000000000..43f13152c
@@ -0,0 +1,17 @@
+################################################################################
+#
+# cog
+#
+################################################################################
+
+COG_VERSION = v0.2.0
+COG_SITE = $(call github,Igalia,cog,$(COG_VERSION))
+COG_DEPENDENCIES = dbus wpewebkit wpebackend-fdo
+COG_LICENSE = MIT
+COG_LICENSE_FILES = COPYING
+COG_CONF_OPTS = \
+	-DCOG_BUILD_PROGRAMS=ON \
+	-DCOG_PLATFORM_FDO=ON \
+	-DCOG_HOME_URI='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))'
+
+$(eval $(cmake-package))
Signature · 6 lines
2.17.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190205/e165a5c8/attachment.asc>

#9 lore raw

PATCH v2 4/4 cog: new package

In reply to Francois Perrad

Hello,

package/cog/Config.in line 4

Quoted 10 lines · On Tue, 5 Feb 2019 21:41:52 +0100 Francois Perrad <[email protected]> wrote:
package/cog/Config.in new file +4 -0
new file mode 100644
index 000000000..4aee4ac91
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_COG
+	bool "cog"
+	depends on BR2_PACKAGE_WPEWEBKIT
+	select BR2_PACKAGE_DBUS

I added the "depends on" of dbus here (even if they are implied by the depends on wpewebkit), and added the corresponding Config.in comments.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#10 lore raw

v2 cover WPE WebKit

In reply to Francois Perrad

Hello Fran?ois,

Quoted 7 lines · Francois Perrad

Another port of WebKit (https://wpewebkit.org/), a project started in 2018.

v1 -> v2
- wpewebkit : use WPEWEBKIT_ARCH_SUPPORTS variables (duplicated from webkitgtk)
- cog : use release 0.2.0
- cog : add dbus as mandatory dependency
- cog : use the default setting of COG_DBUS_SYSTEM_BUS

The patch series looks good to me, and I think it can all be merged now :) Thanks again for updating it!

-Adri?n

Quoted 31 lines

rfc -> v1
- full refactor after Adrian's review
- libwpe : version 1.0.0 (stable) instead of 1.1.0 (instable)
- wbebackend-fdo : version 1.0.0 (stable) instead of 1.1.0 (instable)
- add cog, a WPE WebKit launcher

Francois Perrad (4):
libwpe: new package
wpebackend-fdo: new package
wpewebkit: new package
cog: new package

 DEVELOPERS                                 |   8 ++
 package/Config.in                          |   4 +
 package/cog/Config.in                      |  21 ++++
 package/cog/cog.hash                       |   5 +
 package/cog/cog.mk                         |  17 +++
 package/libwpe/Config.in                   |  13 +++
 package/libwpe/libwpe.hash                 |   7 ++
 package/libwpe/libwpe.mk                   |  22 ++++
 package/wpebackend-fdo/Config.in           |  19 ++++
 package/wpebackend-fdo/wpebackend-fdo.hash |   7 ++
 package/wpebackend-fdo/wpebackend-fdo.mk   |  15 +++
 package/wpewebkit/Config.in                | 114 +++++++++++++++++++++
 package/wpewebkit/wpewebkit.hash           |   8 ++
 package/wpewebkit/wpewebkit.mk             |  61 +++++++++++
 14 files changed, 321 insertions(+)
 create mode 100644 package/cog/Config.in
 create mode 100644 package/cog/cog.hash
 create mode 100644 package/cog/cog.mk
 create mode 100644 package/libwpe/Config.in
Quoted 16 lines
 create mode 100644 package/libwpe/libwpe.hash
 create mode 100644 package/libwpe/libwpe.mk
 create mode 100644 package/wpebackend-fdo/Config.in
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.hash
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.mk
 create mode 100644 package/wpewebkit/Config.in
 create mode 100644 package/wpewebkit/wpewebkit.hash
 create mode 100644 package/wpewebkit/wpewebkit.mk
Signature · 6 lines
2.17.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190205/463c288f/attachment-0001.asc>

#11 lore raw

v2 cover WPE WebKit

In reply to Francois Perrad

Hello,

Quoted 5 lines · On Tue, 5 Feb 2019 21:41:48 +0100 Francois Perrad <[email protected]> wrote:

Francois Perrad (4):
libwpe: new package
wpebackend-fdo: new package
wpewebkit: new package
cog: new package

Thanks, I have applied the series to the next branch. I did a few adjustements, mainly on cleaning up the comments next to the depends on, but also adding a few missing depends on, and more importantly, fixing a serious typo in the wpewebkit package (which was reported by check-package).

I'll reply to the individual patches.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com