tools/bpf: silence a libbpf unnecessary warning
Subsystems (4)
PATCH 1/1 tools/bpf: silence a libbpf unnecessary warning
Commit 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function") refactored function bpf_map_find_btf_info() and moved bulk of implementation into btf.c as btf__get_map_kv_tids(). This change introduced a bug such that test_btf will print out the following warning although the test passed:
BTF libbpf test[2] (test_btf_nokv.o): libbpf: map:btf_map
container_name:____btf_map_btf_map cannot be found in BTF. Missing BPF_ANNOTATE_KV_PAIR?
Previously, the error message is guarded with pr_debug(). Commit 96408c43447a changed it to pr_warning() and hence caused the warning.
Restoring to pr_debug() for the message fixed the issue.
--- tools/lib/bpf/btf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/lib/bpf/btf.c +2 -2
@@ -531,8 +531,8 @@ int btf__get_map_kv_tids(const struct btf *btf, const char *map_name, container_id =btf__find_by_name (btf, container_name);if (container_id <0 ) { -pr_warning ("map:%s container_name:%s cannot be found in BTF. Missing BPF_ANNOTATE_KV_PAIR?\n" , - map_name, container_name); +pr_debug ("map:%s container_name:%s cannot be found in BTF. Missing BPF_ANNOTATE_KV_PAIR?\n" , + map_name, container_name);return container_id; }
Signature · 1 line
2.17.1
Alexei Starovoitov
AppliedQuoted 10 lines · Yonghong Song
Commit
96408c43447a("tools/bpf: implement libbpfbtf__get_map_kv_tids()API function") refactored functionbpf_map_find_btf_info()and moved bulk of implementation intobtf.casbtf__get_map_kv_tids(). This change introduced a bug such thattest_btfwill print out the following warning although the test passed:
BTF libbpf test[2] (test_btf_nokv.o): libbpf: map:btf_map
container_name:____btf_map_btf_map cannot be found in BTF. MissingBPF_ANNOTATE_KV_PAIR?
Quoted 8 lines
Previously, the error message is guarded with
pr_debug(). Commit96408c43447achanged it topr_warning()and hence caused the warning.Restoring to
pr_debug()for the message fixed the issue.Fixes 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function")Signed-off-by Yonghong Song <[email protected]>
Applied. It fixed the issue I was seeing. Thanks!