Skip to contentSkip to conversation

batman-adv: fix memory leak in in batadv_dat_put_dhcp

PATCH New Martin Weinelt 1 participant 1 message Feb 6, 2019 Batman advanced

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 batman-adv: fix memory leak in in batadv_dat_put_dhcp

Consume the skb to avoid leaking memory.

Fixes 1fd1ce2d383f ("batman-adv: Snoop DHCPACKs for DAT")
---
 net/batman-adv/distributed-arp-table.c | 2 ++
 1 file changed, 2 insertions(+)
net/batman-adv/distributed-arp-table.c +2 -0
index 899ab051..310a4f35 100644
@@ -1711,6 +1711,8 @@ static void batadv_dat_put_dhcp(struct batadv_priv *bat_priv, u8 *chaddr,
 	batadv_dat_send_data(bat_priv, skb, yiaddr, vid, BATADV_P_DAT_DHT_PUT);
 	batadv_dat_send_data(bat_priv, skb, ip_dst, vid, BATADV_P_DAT_DHT_PUT);
 
+	consume_skb(skb);
+
 	batadv_dbg(BATADV_DBG_DAT, bat_priv,
 		   "Snooped from outgoing DHCPACK (server address): %pI4, %pM (vid: %i)\n",
 		   &ip_dst, hw_dst, batadv_print_vid(vid));
Signature · 1 line
2.20.1