Skip to contentSkip to conversation

package/zeromq: Allow building with draft APIs enabled

PATCH New Lionel Flandrin 2 participants 4 messages Feb 5, 2019 – Feb 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/zeromq: Allow building with draft APIs enabled

---
 package/zeromq/Config.in | 7 +++++++
 package/zeromq/zeromq.mk | 4 ++++
 2 files changed, 11 insertions(+)
package/zeromq/Config.in +7 -0
index 69be9f002c..fdcdebc691 100644
@@ -52,4 +52,11 @@ config BR2_PACKAGE_ZEROMQ_PGM
 	  3208) implemented either over raw IP packets or UDP
 	  datagrams (encapsulated PGM).
 
+config BR2_PACKAGE_ZEROMQ_DRAFTS
+	bool "Enable ZeroMQ draft APIs"
+	help
+	  Enable unstable draft ZeroMQ APIs
+
+	  https://pyzmq.readthedocs.io/en/latest/draft.html
+
 endif
package/zeromq/zeromq.mk +4 -0
index da57f8745c..0761e54405 100644
@@ -47,6 +47,10 @@ else
 ZEROMQ_CONF_OPTS += --without-pgm
 endif
 
+ifeq ($(BR2_PACKAGE_ZEROMQ_DRAFTS),y)
+ZEROMQ_CONF_OPTS += --enable-drafts
+endif
+
 # ZeroMQ uses libsodium if it's available.
 ifeq ($(BR2_PACKAGE_LIBSODIUM),y)
 ZEROMQ_DEPENDENCIES += libsodium
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 package/python-pyzmq: Enable draft APIs when supported by ZeroMQ

This doesn't introduce a new config flag, instead it just automatically enables draft support if it's configured in the zeromq package itself.

---
 package/python-pyzmq/python-pyzmq.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/python-pyzmq/python-pyzmq.mk +4 -0
index 1f7cb5d613..b977cca927 100644
@@ -22,4 +22,8 @@ endef
 
 PYTHON_PYZMQ_POST_PATCH_HOOKS += PYTHON_PYZMQ_PATCH_ZEROMQ_VERSION
 
+ifeq ($(BR2_PACKAGE_ZEROMQ_DRAFTS),y)
+PYTHON_PYZMQ_BUILD_OPTS += --enable-drafts
+endif
+
 $(eval $(python-package))
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/2 package/python-pyzmq: Enable draft APIs when supported by ZeroMQ

Quoted 7 lines · On Tue, 5 Feb 2019 11:28:14 +0100 Lionel Flandrin <[email protected]> wrote:

This doesn't introduce a new config flag, instead it just automatically enables draft support if it's configured in the zeromq package itself.

---
 package/python-pyzmq/python-pyzmq.mk | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/2 package/zeromq: Allow building with draft APIs enabled

In reply to Lionel Flandrin

Hello Lionel,

Quoted 11 lines · On Tue, 5 Feb 2019 11:28:13 +0100 Lionel Flandrin <[email protected]> wrote:
---
 package/zeromq/Config.in | 7 +++++++
 package/zeromq/zeromq.mk | 4 ++++
 2 files changed, 11 insertions(+)
package/zeromq/Config.in +0 -0
index 69be9f002c..fdcdebc691 100644

package/zeromq/Config.in config BR2_PACKAGE_ZEROMQ_PGM · line 56

Quoted 5 lines
package/zeromq/Config.in +2 -0
@@ -52,4 +52,11 @@ config BR2_PACKAGE_ZEROMQ_PGM
 	  3208) implemented either over raw IP packets or UDP
 	  datagrams (encapsulated PGM).
 
+config BR2_PACKAGE_ZEROMQ_DRAFTS
+	bool "Enable ZeroMQ draft APIs"

Changed to:

bool "Draft APIs support"

package/zeromq/Config.in config BR2_PACKAGE_ZEROMQ_PGM · line 58

Quoted 2 lines
package/zeromq/Config.in +2 -0
+ifeq ($(BR2_PACKAGE_ZEROMQ_DRAFTS),y)
+ZEROMQ_CONF_OPTS += --enable-drafts

Added:

else
ZEROMQ_CONF_OPTS += --disable-drafts

Applied with those changes!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com