Skip to contentSkip to conversation

net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface

PATCH Applied Nicolas Ferre 2 participants 6 messages Feb 6, 2019 – Feb 8, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface

This removes a line left while adding the correct compatibility string for sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string.

---
 Documentation/devicetree/bindings/net/macb.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/devicetree/bindings/net/macb.txt +1 -2
index 3e17ac1d5d58..f5c414b10e27 100644
@@ -3,8 +3,7 @@
 Required properties:
 - compatible: Should be "cdns,[<chip>-]{macb|gem}"
   Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC.
-  Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs or the 10/100Mbit IP
-  available on sama5d3 SoCs.
+  Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs.
   Use "cdns,np4-macb" for NP4 SoC devices.
   Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb".
   Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 2/3 net/macb: bindings doc: add sam9x60 binding

Add the compatibility sting documentation for sam9x60 10/100 interface.

---
Hi Rob,

Your tag is missing for this patch.

 Documentation/devicetree/bindings/net/macb.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/net/macb.txt +1 -0
index f5c414b10e27..174f292d8a3e 100644
@@ -4,6 +4,7 @@ Required properties:
 - compatible: Should be "cdns,[<chip>-]{macb|gem}"
   Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC.
   Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs.
+  Use "cdns,sam9x60-macb" for Microchip sam9x60 SoC.
   Use "cdns,np4-macb" for NP4 SoC devices.
   Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb".
   Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on
Signature · 1 line
2.17.1
#3 lore raw

PATCH v2 3/3 net: macb: add sam9x60-macb compatibility string

In reply to Nicolas Ferre

Add a new compatibility string for this product. It's using at91sam9260-macb layout but has a newer hardware revision: it's safer to use its own string.

---
v2: applies on top of next-20190206

 drivers/net/ethernet/cadence/macb_main.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/cadence/macb_main.c +1 -0
index 2b2882615e8b..eaabe8c278ec 100644
@@ -3943,6 +3943,7 @@ static const struct of_device_id macb_dt_ids[] = {
 	{ .compatible = "cdns,np4-macb", .data = &np4_config },
 	{ .compatible = "cdns,pc302-gem", .data = &pc302gem_config },
 	{ .compatible = "cdns,gem", .data = &pc302gem_config },
+	{ .compatible = "cdns,sam9x60-macb", .data = &at91sam9260_config },
 	{ .compatible = "atmel,sama5d2-gem", .data = &sama5d2_config },
 	{ .compatible = "atmel,sama5d3-gem", .data = &sama5d3_config },
 	{ .compatible = "atmel,sama5d3-macb", .data = &sama5d3macb_config },
Signature · 1 line
2.17.1
maintainer Applied
#4 lore raw

Re: [PATCH v2 3/3] net: macb: add sam9x60-macb compatibility string

From: Nicolas Ferre <[email protected]>
Date: Wed, 6 Feb 2019 18:56:10 +0100

Quoted 5 lines

Add a new compatibility string for this product. It's using at91sam9260-macb layout but has a newer hardware revision: it's safer to use its own string.

Applied to net-next.