Skip to contentSkip to conversation

tc: fix memory leak in error path

PATCH New Stephen Hemminger 1 participant 1 message Feb 6, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tc: fix memory leak in error path

If value passed to parse_percent was not valid, it would leak the dynamic allocation from sscanf.

Fixes 927e3cfb52b5 ("tc: B.W limits can now be specified in %.")
---
 tc/tc_util.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tc/tc_util.c +2 -1
index ab717890bb2a..1377b536e72f 100644
@@ -195,7 +195,7 @@ static int parse_percent_rate(char *rate, const char *str, const char *dev)
 	long dev_mbit;
 	int ret;
 	double perc, rate_mbit;
-	char *str_perc;
+	char *str_perc = NULL;
 
 	if (!dev[0]) {
 		fprintf(stderr, "No device specified; specify device to rate limit by percentage\n");
@@ -230,6 +230,7 @@ static int parse_percent_rate(char *rate, const char *str, const char *dev)
 	return 0;
 
 malf:
+	free(str_perc);
 	fprintf(stderr, "Specified rate value could not be read or is malformed\n");
 	return -1;
 }
Signature · 1 line
2.20.1