Skip to contentSkip to conversation

test-date: drop unused parameter to getnanos()

PATCH New Jeff King 1 participant 1 message Feb 6, 2019

lore
Share & tools
lore

Jeff King

author
#0 lore raw

PATCH 1/1 test-date: drop unused parameter to getnanos()

The getnanos() helper always gets the current time from our getnanotime() facility. The caller cannot override it via TEST_DATE_NOW, and hence we simply ignore the "now" parameter to the function. Let's remove it, as it may mislead callers into thinking it does something.

---
This goes on the js/vsts-ci branch.

Noticed by merging 'next' with my -Wunused-parameters work-in-progress. :)

 t/helper/test-date.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
t/helper/test-date.c +2 -2
index 792a805374..f9e2b91ed1 100644
@@ -83,7 +83,7 @@ static void parse_approx_timestamp(const char **argv, struct timeval *now)
 	}
 }
 
-static void getnanos(const char **argv, struct timeval *now)
+static void getnanos(const char **argv)
 {
 	double seconds = getnanotime() / 1.0e9;
 
@@ -119,7 +119,7 @@ int cmd__date(int argc, const char **argv)
 	else if (!strcmp(*argv, "timestamp"))
 		parse_approx_timestamp(argv+1, &now);
 	else if (!strcmp(*argv, "getnanos"))
-		getnanos(argv+1, &now);
+		getnanos(argv+1);
 	else if (!strcmp(*argv, "is64bit"))
 		return sizeof(timestamp_t) == 8 ? 0 : 1;
 	else if (!strcmp(*argv, "time_t-is64bit"))
Signature · 1 line
2.20.1.1122.g2972e48916