Skip to contentSkip to conversation

syscalls/clock_gettime: create syscall clock_gettime tests

PATCH Superseded Rafael David Tinoco 2 participants 10 messages Feb 6, 2019 – Feb 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 syscalls/clock_gettime: create syscall clock_gettime tests

Fixes 342

clock_gettime01 creates a new test, using new API, based on existing and older kernel/timers/clock_gettime02 test. clock_gettime02 creates another test based on older kernel/timers/clock_gettime03 test. Both will be deleted in the next commits.

---
 runtest/syscalls                              |   3 +
 .../kernel/syscalls/clock_gettime/.gitignore  |   2 +
 .../kernel/syscalls/clock_gettime/Makefile    |  10 ++
 .../syscalls/clock_gettime/clock_gettime01.c  | 134 +++++++++++++++
 .../syscalls/clock_gettime/clock_gettime02.c  | 155 ++++++++++++++++++
 5 files changed, 304 insertions(+)
 create mode 100644 testcases/kernel/syscalls/clock_gettime/.gitignore
 create mode 100644 testcases/kernel/syscalls/clock_gettime/Makefile
 create mode 100644 testcases/kernel/syscalls/clock_gettime/clock_gettime01.c
 create mode 100644 testcases/kernel/syscalls/clock_gettime/clock_gettime02.c
runtest/syscalls +3 -0
index 668c87cd1..7bccda996 100644
@@ -79,6 +79,9 @@ clock_nanosleep01 clock_nanosleep01
 clock_nanosleep02 clock_nanosleep02
 clock_nanosleep2_01 clock_nanosleep2_01
 
+clock_gettime01 clock_gettime01
+clock_gettime02 clock_gettime02
+
 clock_settime01 clock_settime01
 clock_settime02 clock_settime02
 
testcases/kernel/syscalls/clock_gettime/.gitignore new file +2 -0
new file mode 100644
index 000000000..0f9b24ab6
@@ -0,0 +1,2 @@
+clock_gettime01
+clock_gettime02
testcases/kernel/syscalls/clock_gettime/Makefile new file +10 -0
new file mode 100644
index 000000000..79f671f1c
@@ -0,0 +1,10 @@
+# Copyright (c) 2019 - Linaro Limited. All rights reserved.
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+top_srcdir		?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+
+LDLIBS+=-lrt
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
\ No newline at end of file
testcases/kernel/syscalls/clock_gettime/clock_gettime01.c new file +134 -0

134 lines not on this page · raw message

testcases/kernel/syscalls/clock_gettime/clock_gettime02.c new file +155 -0

155 lines not on this page · raw message

Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 timers/clock_gettime: remove clock_gettime tests

clock_gettime{01,02} syscall tests were created, using the new API, based on existing and older kernel/timers/clock_gettime{02,03} tests.

This commit deletes older timers/clock_gettime/* tests.

---
 runtest/timers                                |   2 -
 .../kernel/timers/clock_gettime/.gitignore    |   2 -
 .../kernel/timers/clock_gettime/Makefile      |  27 ---
 .../timers/clock_gettime/clock_gettime02.c    | 120 ------------
 .../timers/clock_gettime/clock_gettime03.c    | 173 ------------------
 5 files changed, 324 deletions(-)
 delete mode 100644 testcases/kernel/timers/clock_gettime/.gitignore
 delete mode 100644 testcases/kernel/timers/clock_gettime/Makefile
 delete mode 100644 testcases/kernel/timers/clock_gettime/clock_gettime02.c
 delete mode 100644 testcases/kernel/timers/clock_gettime/clock_gettime03.c
runtest/timers +0 -2
index 618d2cb0c..5f5ecb6ee 100644
@@ -1,6 +1,4 @@
 #DESCRIPTION:Posix Timer Tests
-clock_gettime02 clock_gettime02
-clock_gettime03 clock_gettime03
 timer_create02 timer_create02
 timer_create03 timer_create03
 timer_create04 timer_create04
testcases/kernel/timers/clock_gettime/.gitignore deleted +0 -2
deleted file mode 100644
index 004e74214..000000000
@@ -1,2 +0,0 @@
-/clock_gettime02
-/clock_gettime03
testcases/kernel/timers/clock_gettime/Makefile deleted +0 -27
deleted file mode 100644
index 8de247075..000000000
@@ -1,27 +0,0 @@
-#
-#  Copyright (c) International Business Machines  Corp., 2001
-#
-#  This program is free software;  you can redistribute it and/or modify
-#  it under the terms of the GNU General Public License as published by
-#  the Free Software Foundation; either version 2 of the License, or
-#  (at your option) any later version.
-#
-#  This program is distributed in the hope that it will be useful,
-#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
-#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
-#  the GNU General Public License for more details.
-#
-#  You should have received a copy of the GNU General Public License
-#  along with this program;  if not, write to the Free Software
-#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-#
-
-top_srcdir		?= ../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-CPPFLAGS		+= -D_GNU_SOURCE -I$(abs_srcdir)/../include
-
-LDLIBS			+= -lpthread -lrt
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/timers/clock_gettime/clock_gettime02.c deleted +0 -120

120 lines not on this page · raw message

testcases/kernel/timers/clock_gettime/clock_gettime03.c deleted +0 -173

173 lines not on this page · raw message

Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/2 syscalls/clock_gettime: create syscall clock_gettime tests

In reply to Rafael David Tinoco

Hi!

Quoted 7 lines
testcases/kernel/syscalls/clock_gettime/clock_gettime01.c new file +7 -0
+struct test_case {
+	clockid_t clocktype;
+	int exp_ret;
+	int exp_err;
+	int unsupported;
+};
+

testcases/kernel/syscalls/clock_gettime/clock_gettime01.c line 43

Quoted 10 lines
testcases/kernel/syscalls/clock_gettime/clock_gettime01.c new file +10 -0
+struct test_case tc[] = {
+	{
+	 .clocktype = CLOCK_REALTIME,
+	 },
+	{
+	 .clocktype = CLOCK_REALTIME_COARSE,
+#ifndef CLOCK_REALTIME_COARSE
+	 .exp_ret = -1,
+	 .exp_err = EINVAL,
+#endif

Depending on the constant beind defined is completely wrong here. The only way how to figure out if the clock is being supported or not is to call the clock_gettime() with correct paramters and check for EINVAL.

So I guess that in this test we should call clock_gettime() for paticular clock and:

* For certain clocks that are implemented for long enough, we expect success, I would say that at least CLOCK_REALTIME, CLOCK_MONOTONIC and CLOCK_*_CPUTIME_ID should be implemented for long enough to be supported everywhere

* The rest of the clocks should be allowed either to pass or return EINVAL

* In case that the call passed we should check that the timespec has been changed (we should zero it before the call)

* Also many architectures have vDSO for clock_gettime() we should also check that the syscall and vDSO are consistent in this case

Quoted 255 lines
testcases/kernel/syscalls/clock_gettime/clock_gettime01.c new file +91 -0
+	 },
+	{
+	 .clocktype = CLOCK_MONOTONIC,
+#ifndef CLOCK_MONOTONIC
+	 .exp_ret = -1,
+	 .exp_err = EINVAL,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_MONOTONIC_COARSE,
+#ifndef CLOCK_MONOTONIC_COARSE
+	 .exp_ret = -1,
+	 .exp_err = EINVAL,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_MONOTONIC_RAW,
+#ifndef CLOCK_MONOTONIC_RAW
+	 .exp_ret = -1,
+	 .exp_err = EINVAL,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_BOOTTIME,
+#ifndef CLOCK_BOOTTIME
+	 .exp_ret = -1,
+	 .exp_err = EINVAL,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_PROCESS_CPUTIME_ID,
+#ifndef CLOCK_PROCESS_CPUTIME_ID
+	 .exp_ret = -1,
+	 .exp_err = EINVAL,
+#endif
+	 },
+{
+	 .clocktype = CLOCK_THREAD_CPUTIME_ID,
+#ifndef CLOCK_THREAD_CPUTIME_ID
+	 .exp_ret = -1,
+	 .exp_err = EINVAL,
+#endif
+	 },
+};
+
+static void verify_clock_gettime(unsigned int i)
+{
+	struct timespec spec;
+
+	TEST(clock_gettime(tc[i].clocktype, &spec));
+
+	if (TST_RET == -1 && tc[i].exp_ret == -1) {
+
+		if (tc[i].exp_err == TST_ERR) {
+			tst_res(TPASS, "clock_gettime(2): unsupported clock %s "
+					"failed as expected",
+					tst_clock_name(tc[i].clocktype));
+		} else {
+			tst_res(TFAIL | TTERRNO, "clock_gettime(2): "
+					"unsupported clock %s failed "
+					"unexpectedly",
+					tst_clock_name(tc[i].clocktype));
+		}
+		return;
+	}
+
+	if (TST_RET == -1 && tc[i].exp_ret == 0) {
+
+		tst_res(TFAIL | TTERRNO, "clock_gettime(2): clock %s "
+					"failed unexpectedly",
+					tst_clock_name(tc[i].clocktype));
+		return;
+	}
+
+	if (TST_RET == 0 && tc[i].exp_ret == -1) {
+
+		tst_res(TFAIL, "clock_gettime(2): unsupported clock %s passed "
+				"unexpectedly",
+				tst_clock_name(tc[i].clocktype));
+		return;
+	}
+
+	tst_res(TPASS, "clock_gettime(2): clock %s passed",
+			tst_clock_name(tc[i].clocktype));
+}
+
+static struct tst_test test = {
+	.test = verify_clock_gettime,
+	.tcnt = ARRAY_SIZE(tc),
+	.needs_root = 1,
+};
testcases/kernel/syscalls/clock_gettime/clock_gettime02.c new file +155 -0
new file mode 100644
index 000000000..5985cdec0
@@ -0,0 +1,155 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2019 Linaro Limited. All rights reserved.
+ * Author: Rafael David Tinoco <[email protected]>
+ */
+/*
+ * Bad argument tests for clock_gettime(2) on multiple clocks:
+ *
+ *  1) MAX_CLOCKS                - bad clock
+ *  2) MAX_CLOCKS + 1            - bad clock
+ *  3) CLOCK_REALTIME            - bad time spec ptr (if supported)
+ *  4) CLOCK_MONOTONIC           - bad time spec ptr (if supported)
+ *  5) CLOCK_REALTIME_COARSE     - bad time spec ptr (if supported)
+ *  6) CLOCK_MONOTONIC_COARSE    - bad time spec ptr (if supported)
+ *  7) CLOCK_MONOTONIC_RAW       - bad time spec ptr (if supported)
+ *  8) CLOCK_BOOTTIME            - bad time spec ptr (if supported)
+ *  9) CLOCK_PROCESS_CPUTIME_ID  - bad time spec ptr (if supported)
+ * 10) CLOCK_THREAD_CPUTIME_ID   - bad time spec ptr (if supported)
+ */
+
+#include "config.h"
+#include "tst_test.h"
+#include "lapi/syscalls.h"
+#include "lapi/posix_clocks.h"
+#include "tst_timer.h"
+#include "tst_safe_clocks.h"
+
+#define DELTA_SEC 10
+#define NSEC_PER_SEC (1000000000L)
+#define MAX_CLOCKS 16
+
+struct test_case {
+	clockid_t clocktype;
+	int exp_err;
+};
+
+struct test_case tc[] = {
+	{
+	 .clocktype = MAX_CLOCKS,
+	 .exp_err = EINVAL,
+	 },
+	{
+	 .clocktype = MAX_CLOCKS + 1,
+	 .exp_err = EINVAL,
+	 },
+	{
+	 .clocktype = CLOCK_REALTIME,
+	 .exp_err = EFAULT,
+	 },
+	{
+	 .clocktype = CLOCK_MONOTONIC,
+	 .exp_err = EFAULT,
+	 },
+	/*
+	 * Different POSIX clocks have different (*clock_get)() handlers.
+	 * It justifies testing EFAULT for all.
+	 */
+	{
+	 .clocktype = CLOCK_REALTIME_COARSE,
+#ifndef CLOCK_REALTIME_COARSE
+	 .exp_err = EINVAL,
+#else
+	 .exp_err = EFAULT,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_MONOTONIC_COARSE,
+#ifndef CLOCK_MONOTONIC_COARSE
+	 .exp_err = EINVAL,
+#else
+	 .exp_err = EFAULT,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_MONOTONIC_RAW,
+#ifndef CLOCK_MONOTONIC_RAW
+	 .exp_err = EINVAL,
+#else
+	 .exp_err = EFAULT,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_BOOTTIME,
+#ifndef CLOCK_BOOTTIME
+	 .exp_err = EINVAL,
+#else
+	 .exp_err = EFAULT,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_PROCESS_CPUTIME_ID,
+#ifndef CLOCK_PROCESS_CPUTIME_ID
+	 .exp_err = EINVAL,
+#else
+	 .exp_err = EFAULT,
+#endif
+	 },
+	{
+	 .clocktype = CLOCK_THREAD_CPUTIME_ID,
+#ifndef CLOCK_THREAD_CPUTIME_ID
+	 .exp_err = EINVAL,
+#else
+	 .exp_err = EFAULT,
+#endif
+	 },
+};
+
+/*
+ * Some tests may cause libc to segfault when passing bad arguments.
+ */
+static int sys_clock_gettime(clockid_t clk_id, struct timespec *tp)
+{
+	return tst_syscall(__NR_clock_gettime, clk_id, tp);
+}
+
+static void verify_clock_gettime(unsigned int i)
+{
+	struct timespec spec, *specptr;
+
+	specptr = &spec;
+
+	/* bad pointer case */
+	if (tc[i].exp_err == EFAULT)
+		specptr = tst_get_bad_addr(NULL);
+
+	TEST(sys_clock_gettime(tc[i].clocktype, specptr));
+
+	if (TST_RET == -1) {
+
+		if (tc[i].exp_err == TST_ERR) {
+			tst_res(TPASS, "clock_gettime(2): %sclock %s failed as "
+					"expected", (tc[i].exp_err == EINVAL) ?
+					"unsupported " : "",
+					tst_clock_name(tc[i].clocktype));
+		} else {
+			tst_res(TFAIL | TTERRNO, "clock_gettime(2): %sclock %s "
+					"failed unexpectedly",
+					(tc[i].exp_err == EINVAL) ?
+					"unsupported " : "",
+					tst_clock_name(tc[i].clocktype));
+		}
+		return;
+	}
+
+	tst_res(TFAIL, "clock_gettime(2): %sclock %s passed unexpectedly",
+			(tc[i].exp_err == EINVAL) ? "unsupported " : "",
+			tst_clock_name(tc[i].clocktype));
+}
+
+static struct tst_test test = {
+	.test = verify_clock_gettime,
+	.tcnt = ARRAY_SIZE(tc),
+	.needs_root = 1,
+	.restore_wallclock = 1,
+};
Signature · 1 line
2.20.1
Signature · 2 lines
Cyril Hrubis
[email protected]
#3 lore raw

PATCH 1/2 syscalls/clock_gettime: create syscall clock_gettime tests

Hey o/

Quoted 16 lines · Cyril Hrubis

Hi!

Quoted 13 lines
testcases/kernel/syscalls/clock_gettime/clock_gettime01.c new file +13 -0
+struct test_case {
+	clockid_t clocktype;
+	int exp_ret;
+	int exp_err;
+	int unsupported;
+};
+
+struct test_case tc[] = {
+	{
+	 .clocktype = CLOCK_REALTIME,
+	 },
+	{
+	 .clocktype = CLOCK_REALTIME_COARSE,
Quoted 9 lines

testcases/kernel/syscalls/clock_gettime/clock_gettime01.c line 43

Quoted 4 lines
testcases/kernel/syscalls/clock_gettime/clock_gettime01.c new file +4 -0
+#ifndef CLOCK_REALTIME_COARSE
+	 .exp_ret = -1,
+	 .exp_err = EINVAL,
+#endif

Depending on the constant beind defined is completely wrong here. The only way how to figure out if the clock is being supported or not is to call the clock_gettime() with correct paramters and check for EINVAL.

Yes I had doubts about compilation vs runtime also for the #ifndefs.

Quoted 7 lines

So I guess that in this test we should call clock_gettime() for paticular clock and:

* For certain clocks that are implemented for long enough, we expect success, I would say that at least CLOCK_REALTIME, CLOCK_MONOTONIC and CLOCK_*_CPUTIME_ID should be implemented for long enough to be supported everywhere

Alright.

Quoted 3 lines

* The rest of the clocks should be allowed either to pass or return EINVAL

Makes sense.

Quoted 2 lines

* In case that the call passed we should check that the timespec has been changed (we should zero it before the call)

Ok.

Quoted 2 lines

* Also many architectures have vDSO for clock_gettime() we should also check that the syscall and vDSO are consistent in this case

Alright, will force the syscall and later use regular libc call to wrap into vDSO is available.

Thanks for the feedback!

Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20190207/88b0bdb1/attachment-0001.html>

#4 lore raw

PATCH v2 1/2 syscalls/clock_gettime: create clock_gettime syscall tests

In reply to Cyril Hrubis
Fixes 342

clock_gettime{01,02} are created using the new API, based on existing kernel/timers/clock_gettime{02,03} tests, which will be deleted in the next commits.

---
 runtest/syscalls                              |   3 +
 .../kernel/syscalls/clock_gettime/.gitignore  |   2 +
 .../kernel/syscalls/clock_gettime/Makefile    |  10 ++
 .../syscalls/clock_gettime/clock_gettime01.c  | 141 ++++++++++++++++++
 .../syscalls/clock_gettime/clock_gettime02.c  | 139 +++++++++++++++++
 5 files changed, 295 insertions(+)
 create mode 100644 testcases/kernel/syscalls/clock_gettime/.gitignore
 create mode 100644 testcases/kernel/syscalls/clock_gettime/Makefile
 create mode 100644 testcases/kernel/syscalls/clock_gettime/clock_gettime01.c
 create mode 100644 testcases/kernel/syscalls/clock_gettime/clock_gettime02.c
runtest/syscalls +3 -0
index 668c87cd1..7bccda996 100644
@@ -79,6 +79,9 @@ clock_nanosleep01 clock_nanosleep01
 clock_nanosleep02 clock_nanosleep02
 clock_nanosleep2_01 clock_nanosleep2_01
 
+clock_gettime01 clock_gettime01
+clock_gettime02 clock_gettime02
+
 clock_settime01 clock_settime01
 clock_settime02 clock_settime02
 
testcases/kernel/syscalls/clock_gettime/.gitignore new file +2 -0
new file mode 100644
index 000000000..0f9b24ab6
@@ -0,0 +1,2 @@
+clock_gettime01
+clock_gettime02
testcases/kernel/syscalls/clock_gettime/Makefile new file +10 -0
new file mode 100644
index 000000000..79f671f1c
@@ -0,0 +1,10 @@
+# Copyright (c) 2019 - Linaro Limited. All rights reserved.
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+top_srcdir		?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+
+LDLIBS+=-lrt
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
\ No newline at end of file
testcases/kernel/syscalls/clock_gettime/clock_gettime01.c new file +141 -0

141 lines not on this page · raw message

testcases/kernel/syscalls/clock_gettime/clock_gettime02.c new file +139 -0

139 lines not on this page · raw message

Signature · 1 line
2.20.1
#5 lore raw

PATCH v2 1/2 syscalls/clock_gettime: create clock_gettime syscall tests

Quoted 23 lines
testcases/kernel/syscalls/clock_gettime/clock_gettime02.c new file +16 -0
new file mode 100644
index 000000000..4db52c09d
@@ -0,0 +1,139 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2019 Linaro Limited. All rights reserved.
+ * Author: Rafael David Tinoco <[email protected]>
+ */
+/*
+ * Bad argument tests for clock_gettime(2) on multiple clocks:
+ *
+ *  1) MAX_CLOCKS
+ *  2) MAX_CLOCKS + 1
+ *  3) CLOCK_REALTIME
+ *  4) CLOCK_MONOTONIC
+ *  5) CLOCK_PROCESS_CPUTIME_ID
+ *  6) CLOCK_THREAD_CPUTIME_ID
+ *  7) CLOCK_REALTIME_COARSE
+ *  8) CLOCK_MONOTONIC_COARSE

testcases/kernel/syscalls/clock_gettime/clock_gettime02.c line 26

Quoted 10 lines
testcases/kernel/syscalls/clock_gettime/clock_gettime02.c new file +10 -0
+ *  9) CLOCK_MONOTONIC_RAW
+ * 10) CLOCK_BOOTTIME
+ */
+
+#include "config.h"
+#include "tst_test.h"
+#include "lapi/syscalls.h"
+#include "lapi/posix_clocks.h"
+#include "tst_timer.h"
+#include “tst_safe_clocks.h"

<garbage>

testcases/kernel/syscalls/clock_gettime/clock_gettime02.c line 31

Quoted 4 lines
testcases/kernel/syscalls/clock_gettime/clock_gettime02.c new file +4 -0
+#include <stdio.h>
+
+#define DELTA_SEC 10
+#define NSEC_PER_SEC (1000000000L)

</garbage>

Sorry, sent out the patch too soon. Let me know if you can amend it, removing those 3 lines, or you want me to submit it again.

Thanks a lot.

#6 lore raw

PATCH v2 2/2 timers/clock_gettime: remove clock_gettime tests

In reply to Rafael David Tinoco

clock_gettime{01,02} syscall tests were created, using the new API, based on existing and older kernel/timers/clock_gettime{02,03} tests.

This commit deletes older timers/clock_gettime/* tests.

---
 runtest/timers                                |   2 -
 .../kernel/timers/clock_gettime/.gitignore    |   2 -
 .../kernel/timers/clock_gettime/Makefile      |  27 ---
 .../timers/clock_gettime/clock_gettime02.c    | 120 ------------
 .../timers/clock_gettime/clock_gettime03.c    | 173 ------------------
 5 files changed, 324 deletions(-)
 delete mode 100644 testcases/kernel/timers/clock_gettime/.gitignore
 delete mode 100644 testcases/kernel/timers/clock_gettime/Makefile
 delete mode 100644 testcases/kernel/timers/clock_gettime/clock_gettime02.c
 delete mode 100644 testcases/kernel/timers/clock_gettime/clock_gettime03.c
runtest/timers +0 -2
index 618d2cb0c..5f5ecb6ee 100644
@@ -1,6 +1,4 @@
 #DESCRIPTION:Posix Timer Tests
-clock_gettime02 clock_gettime02
-clock_gettime03 clock_gettime03
 timer_create02 timer_create02
 timer_create03 timer_create03
 timer_create04 timer_create04
testcases/kernel/timers/clock_gettime/.gitignore deleted +0 -2
deleted file mode 100644
index 004e74214..000000000
@@ -1,2 +0,0 @@
-/clock_gettime02
-/clock_gettime03
testcases/kernel/timers/clock_gettime/Makefile deleted +0 -27
deleted file mode 100644
index 8de247075..000000000
@@ -1,27 +0,0 @@
-#
-#  Copyright (c) International Business Machines  Corp., 2001
-#
-#  This program is free software;  you can redistribute it and/or modify
-#  it under the terms of the GNU General Public License as published by
-#  the Free Software Foundation; either version 2 of the License, or
-#  (at your option) any later version.
-#
-#  This program is distributed in the hope that it will be useful,
-#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
-#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
-#  the GNU General Public License for more details.
-#
-#  You should have received a copy of the GNU General Public License
-#  along with this program;  if not, write to the Free Software
-#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-#
-
-top_srcdir		?= ../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-CPPFLAGS		+= -D_GNU_SOURCE -I$(abs_srcdir)/../include
-
-LDLIBS			+= -lpthread -lrt
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/timers/clock_gettime/clock_gettime02.c deleted +0 -120

120 lines not on this page · raw message

testcases/kernel/timers/clock_gettime/clock_gettime03.c deleted +0 -173

173 lines not on this page · raw message

Signature · 1 line
2.20.1
#7 lore raw

PATCH v3 1/2 syscalls/clock_gettime: create clock_gettime syscall tests

In reply to Cyril Hrubis
Fixes 342

clock_gettime{01,02} are created using the new API, based on existing kernel/timers/clock_gettime{02,03} tests, which will be deleted in the next commits.

---
 runtest/syscalls                              |   3 +
 .../kernel/syscalls/clock_gettime/.gitignore  |   2 +
 .../kernel/syscalls/clock_gettime/Makefile    |  10 ++
 .../syscalls/clock_gettime/clock_gettime01.c  | 141 ++++++++++++++++++
 .../syscalls/clock_gettime/clock_gettime02.c  | 135 +++++++++++++++++
 5 files changed, 291 insertions(+)
 create mode 100644 testcases/kernel/syscalls/clock_gettime/.gitignore
 create mode 100644 testcases/kernel/syscalls/clock_gettime/Makefile
 create mode 100644 testcases/kernel/syscalls/clock_gettime/clock_gettime01.c
 create mode 100644 testcases/kernel/syscalls/clock_gettime/clock_gettime02.c
runtest/syscalls +3 -0
index 668c87cd1..7bccda996 100644
@@ -79,6 +79,9 @@ clock_nanosleep01 clock_nanosleep01
 clock_nanosleep02 clock_nanosleep02
 clock_nanosleep2_01 clock_nanosleep2_01
 
+clock_gettime01 clock_gettime01
+clock_gettime02 clock_gettime02
+
 clock_settime01 clock_settime01
 clock_settime02 clock_settime02
 
testcases/kernel/syscalls/clock_gettime/.gitignore new file +2 -0
new file mode 100644
index 000000000..0f9b24ab6
@@ -0,0 +1,2 @@
+clock_gettime01
+clock_gettime02
testcases/kernel/syscalls/clock_gettime/Makefile new file +10 -0
new file mode 100644
index 000000000..79f671f1c
@@ -0,0 +1,10 @@
+# Copyright (c) 2019 - Linaro Limited. All rights reserved.
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+top_srcdir		?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+
+LDLIBS+=-lrt
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
\ No newline at end of file
testcases/kernel/syscalls/clock_gettime/clock_gettime01.c new file +141 -0

141 lines not on this page · raw message

testcases/kernel/syscalls/clock_gettime/clock_gettime02.c new file +135 -0

135 lines not on this page · raw message

Signature · 1 line
2.20.1
#8 lore raw

PATCH v3 2/2 timers/clock_gettime: remove clock_gettime tests

clock_gettime{01,02} syscall tests were created, using the new API, based on existing and older kernel/timers/clock_gettime{02,03} tests.

This commit deletes older timers/clock_gettime/* tests.

---
 runtest/timers                                |   2 -
 .../kernel/timers/clock_gettime/.gitignore    |   2 -
 .../kernel/timers/clock_gettime/Makefile      |  27 ---
 .../timers/clock_gettime/clock_gettime02.c    | 120 ------------
 .../timers/clock_gettime/clock_gettime03.c    | 173 ------------------
 5 files changed, 324 deletions(-)
 delete mode 100644 testcases/kernel/timers/clock_gettime/.gitignore
 delete mode 100644 testcases/kernel/timers/clock_gettime/Makefile
 delete mode 100644 testcases/kernel/timers/clock_gettime/clock_gettime02.c
 delete mode 100644 testcases/kernel/timers/clock_gettime/clock_gettime03.c
runtest/timers +0 -2
index 618d2cb0c..5f5ecb6ee 100644
@@ -1,6 +1,4 @@
 #DESCRIPTION:Posix Timer Tests
-clock_gettime02 clock_gettime02
-clock_gettime03 clock_gettime03
 timer_create02 timer_create02
 timer_create03 timer_create03
 timer_create04 timer_create04
testcases/kernel/timers/clock_gettime/.gitignore deleted +0 -2
deleted file mode 100644
index 004e74214..000000000
@@ -1,2 +0,0 @@
-/clock_gettime02
-/clock_gettime03
testcases/kernel/timers/clock_gettime/Makefile deleted +0 -27
deleted file mode 100644
index 8de247075..000000000
@@ -1,27 +0,0 @@
-#
-#  Copyright (c) International Business Machines  Corp., 2001
-#
-#  This program is free software;  you can redistribute it and/or modify
-#  it under the terms of the GNU General Public License as published by
-#  the Free Software Foundation; either version 2 of the License, or
-#  (at your option) any later version.
-#
-#  This program is distributed in the hope that it will be useful,
-#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
-#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
-#  the GNU General Public License for more details.
-#
-#  You should have received a copy of the GNU General Public License
-#  along with this program;  if not, write to the Free Software
-#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-#
-
-top_srcdir		?= ../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-CPPFLAGS		+= -D_GNU_SOURCE -I$(abs_srcdir)/../include
-
-LDLIBS			+= -lpthread -lrt
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/timers/clock_gettime/clock_gettime02.c deleted +0 -120

120 lines not on this page · raw message

testcases/kernel/timers/clock_gettime/clock_gettime03.c deleted +0 -173

173 lines not on this page · raw message

Signature · 1 line
2.20.1