Skip to contentSkip to conversation

ip-link: Fix listing of alias interfaces

PATCH In review Phil Sutter 4 participants 7 messages Feb 7, 2019 – Feb 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ip-link: Fix listing of alias interfaces

Commit 50b9950dd9011 ("link dump filter") accidentally broke listing of links in the old alias interface notation:

| % ip link show eth0:1
| RTNETLINK answers: No such device
| Cannot send link get request: No such device

Prior to the above commit, link lookup was performed via ifindex returned by if_nametoindex(). The latter uses SIOCGIFINDEX ioctl call which on kernel side causes the colon-suffix to be dropped before doing the interface lookup. Netlink API though doesn't care about that at all. To keep things backward compatible, mimick ioctl API behaviour and drop the colon-suffix prior to sending the RTM_GETLINK request.

Fixes 50b9950dd9011 ("link dump filter")
---
 ip/ipaddress.c | 1 +
 1 file changed, 1 insertion(+)
ip/ipaddress.c +1 -0
index 2bc33f3a3b3f2..bc30d326ca0a3 100644
@@ -1974,6 +1974,7 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
 	 * the link device
 	 */
 	if (filter_dev && filter.group == -1 && do_link == 1) {
+		*strchrnul(filter_dev, ':') = '\0';
 		if (iplink_get(filter_dev, RTEXT_FILTER_VF) < 0) {
 			perror("Cannot send link get request");
 			delete_json_obj();
Signature · 1 line
2.20.1
#1 lore raw
Quoted 14 lines · On Thu, 7 Feb 2019 14:05:27 +0100 Phil Sutter <[email protected]> wrote:

Commit 50b9950dd9011 ("link dump filter") accidentally broke listing of links in the old alias interface notation:

| % ip link show eth0:1
| RTNETLINK answers: No such device
| Cannot send link get request: No such device

Prior to the above commit, link lookup was performed via ifindex returned by if_nametoindex(). The latter uses SIOCGIFINDEX ioctl call which on kernel side causes the colon-suffix to be dropped before doing the interface lookup. Netlink API though doesn't care about that at all. To keep things backward compatible, mimick ioctl API behaviour and drop the colon-suffix prior to sending the RTM_GETLINK request.

Quoted 2 lines
Fixes 50b9950dd9011 ("link dump filter")

What about mistaken usage where the text after the colon is not a number, or has additional colon?

#2 lore raw
Quoted 17 lines · Stephen Hemminger
Quoted 14 lines · On Thu, 7 Feb 2019 14:05:27 +0100 Phil Sutter <[email protected]> wrote:

Commit 50b9950dd9011 ("link dump filter") accidentally broke listing of links in the old alias interface notation:

| % ip link show eth0:1
| RTNETLINK answers: No such device
| Cannot send link get request: No such device

Prior to the above commit, link lookup was performed via ifindex returned by if_nametoindex(). The latter uses SIOCGIFINDEX ioctl call which on kernel side causes the colon-suffix to be dropped before doing the interface lookup. Netlink API though doesn't care about that at all. To keep things backward compatible, mimick ioctl API behaviour and drop the colon-suffix prior to sending the RTM_GETLINK request.

Quoted 5 lines
Quoted 2 lines
Fixes 50b9950dd9011 ("link dump filter")

What about mistaken usage where the text after the colon is not a number, or has additional colon?

That's completely ignored in ioctl-case as well. See dev_ioctl() in kernel sources:

| colon = strchr(ifr->ifr_name, ':');
| if (colon)
|         *colon = 0;

If you pass 'group 0' to link show command, ioctl code path is taken. It allows (and drops) arbitrary input after the colon (as long as the total name doesn't exceed 15 characters).

Cheers, Phil

#3 lore raw
Quoted 27 lines · Phil Sutter
Quoted 17 lines · Stephen Hemminger
Quoted 14 lines · On Thu, 7 Feb 2019 14:05:27 +0100 Phil Sutter <[email protected]> wrote:

Commit 50b9950dd9011 ("link dump filter") accidentally broke listing of links in the old alias interface notation:

| % ip link show eth0:1
| RTNETLINK answers: No such device
| Cannot send link get request: No such device

Prior to the above commit, link lookup was performed via ifindex returned by if_nametoindex(). The latter uses SIOCGIFINDEX ioctl call which on kernel side causes the colon-suffix to be dropped before doing the interface lookup. Netlink API though doesn't care about that at all. To keep things backward compatible, mimick ioctl API behaviour and drop the colon-suffix prior to sending the RTM_GETLINK request.

Quoted 5 lines
Quoted 2 lines
Fixes 50b9950dd9011 ("link dump filter")

What about mistaken usage where the text after the colon is not a number, or has additional colon?

That's completely ignored in ioctl-case as well. See dev_ioctl() in kernel sources:

Quoted 7 lines
| colon = strchr(ifr->ifr_name, ':');
| if (colon)
|         *colon = 0;

If you pass 'group 0' to link show command, ioctl code path is taken. It allows (and drops) arbitrary input after the colon (as long as the total name doesn't exceed 15 characters).

Not only that, other ip link subcommands also use ioctl for interface lookup so that e.g. "ip link del dummy1:x" deletes dummy1 without any complaint.

But as I mentioned earlier in http://patchwork.ozlabs.org/patch/1037934/
I'm not sure this behaviour is really desirable.

Michal Kubecek

#4 lore raw
Quoted 6 lines · Michal Kubecek

Not only that, other ip link subcommands also use ioctl for interface lookup so that e.g. "ip link del dummy1:x" deletes dummy1 without any complaint.

But as I mentioned earlier in http://patchwork.ozlabs.org/patch/1037934/
I'm not sure this behaviour is really desirable.

I sent a patch some time ago to convert ll_name_to_index to use an netlink message first and only fallback to if_nametoindex if it fails. That should fix the problem you mentioned

#5 lore raw
In reply to Phil Sutter
Quoted 14 lines · On Thu, 7 Feb 2019 14:05:27 +0100 Phil Sutter <[email protected]> wrote:

Commit 50b9950dd9011 ("link dump filter") accidentally broke listing of links in the old alias interface notation:

| % ip link show eth0:1
| RTNETLINK answers: No such device
| Cannot send link get request: No such device

Prior to the above commit, link lookup was performed via ifindex returned by if_nametoindex(). The latter uses SIOCGIFINDEX ioctl call which on kernel side causes the colon-suffix to be dropped before doing the interface lookup. Netlink API though doesn't care about that at all. To keep things backward compatible, mimick ioctl API behaviour and drop the colon-suffix prior to sending the RTM_GETLINK request.

Quoted 2 lines
Fixes 50b9950dd9011 ("link dump filter")

It is a regression, but the original code was kind of broken. iproute2 doesn't need or want the old style alias interface notation.

#6 lore raw

Hi Stephen,

Quoted 17 lines · Stephen Hemminger
Quoted 14 lines · On Thu, 7 Feb 2019 14:05:27 +0100 Phil Sutter <[email protected]> wrote:

Commit 50b9950dd9011 ("link dump filter") accidentally broke listing of links in the old alias interface notation:

| % ip link show eth0:1
| RTNETLINK answers: No such device
| Cannot send link get request: No such device

Prior to the above commit, link lookup was performed via ifindex returned by if_nametoindex(). The latter uses SIOCGIFINDEX ioctl call which on kernel side causes the colon-suffix to be dropped before doing the interface lookup. Netlink API though doesn't care about that at all. To keep things backward compatible, mimick ioctl API behaviour and drop the colon-suffix prior to sending the RTM_GETLINK request.

Quoted 5 lines
Quoted 2 lines
Fixes 50b9950dd9011 ("link dump filter")

It is a regression, but the original code was kind of broken. iproute2 doesn't need or want the old style alias interface notation.

Thanks for your clarification!

Cheers, Phil