ath10k: Handle bundle tx completion for management pkts
v2 cover ath10k: Handle bundle tx completion for management pkts
WCN3990 sends the tx completion for management frames via wmi. The tx completion for the multiple management frames can also be bundled in a single wmi event and sent to the host driver. This reduces the number of WMI events sent to the host driver by the target.
Enable the support in firmware to send tx completion for management frames, bundled in a single event, by setting the proper flag in wmi init command.
Handle the bundled management tx completion event in host driver.
Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
Changes from v1:
- Addressed comments to remove tricky typecasting.
- Fixed compilation warnings.
Rakesh Pillai (2):
ath10k: Handle bundled tx completion for management frames
ath10k: Enable bundle tx compl for management frames in WCN3990
drivers/net/wireless/ath/ath10k/wmi-ops.h | 13 +++++++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 65 ++++++++++++++++++++++++++++++- drivers/net/wireless/ath/ath10k/wmi-tlv.h | 3 ++ drivers/net/wireless/ath/ath10k/wmi.c | 23 +++++++++++ drivers/net/wireless/ath/ath10k/wmi.h | 7 ++++ 5 files changed, 110 insertions(+), 1 deletion(-)
Signature · 7 lines
2.7.4 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
PATCH v2 1/2 ath10k: Handle bundled tx completion for management frames
WCN3990 supports sending tx completion for multiple management frames bundled together in a single event.
Add support to handle the bundled tx completion
event for WCN3990.
Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
--- drivers/net/wireless/ath/ath10k/wmi-ops.h | 13 +++++++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 63 +++++++++++++++++++++++++++++++ drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 + drivers/net/wireless/ath/ath10k/wmi.c | 23 +++++++++++ drivers/net/wireless/ath/ath10k/wmi.h | 7 ++++ 5 files changed, 107 insertions(+)
drivers/net/wireless/ath/ath10k/wmi-ops.h +13 -0
@@ -33,6 +33,9 @@ struct wmi_ops { struct wmi_mgmt_rx_ev_arg *arg);int (*pull_mgmt_tx_compl)(struct ath10k *ar,struct sk_buff *skb,struct wmi_tlv_mgmt_tx_compl_ev_arg *arg); +int (*pull_mgmt_tx_bundle_compl)( +struct ath10k *ar,struct sk_buff *skb, +struct wmi_tlv_mgmt_tx_bundle_compl_ev_arg *arg);int (*pull_ch_info)(struct ath10k *ar,struct sk_buff *skb,struct wmi_ch_info_ev_arg *arg); int (*pull_vdev_start)(struct ath10k *ar, struct sk_buff *skb,
@@ -280,6 +283,16 @@ ath10k_wmi_pull_mgmt_tx_compl(struct ath10k *ar, struct sk_buff *skb, }static inline int +ath10k_wmi_pull_mgmt_tx_bundle_compl (struct ath10k *ar,struct sk_buff *skb, +struct wmi_tlv_mgmt_tx_bundle_compl_ev_arg *arg) +{ +if (!ar->wmi.ops->pull_mgmt_tx_bundle_compl) +return -EOPNOTSUPP ; + +return ar->wmi.ops->pull_mgmt_tx_bundle_compl (ar, skb, arg); +} + +static inline int ath10k_wmi_pull_mgmt_rx (struct ath10k *ar,struct sk_buff *skb,struct wmi_mgmt_rx_ev_arg *arg) {
drivers/net/wireless/ath/ath10k/wmi-tlv.c +63 -0
81 lines not on this page · raw message
drivers/net/wireless/ath/ath10k/wmi-tlv.h +1 -0
@@ -321,6 +321,7 @@ enum wmi_tlv_event_id {WMI_TLV_OFFLOAD_BCN_TX_STATUS_EVENTID ,WMI_TLV_OFFLOAD_PROB_RESP_TX_STATUS_EVENTID ,WMI_TLV_MGMT_TX_COMPLETION_EVENTID , +WMI_TLV_MGMT_TX_BUNDLE_COMPLETION_EVENTID ,WMI_TLV_TX_DELBA_COMPLETE_EVENTID =WMI_TLV_EV (WMI_TLV_GRP_BA_NEG ),WMI_TLV_TX_ADDBA_COMPLETE_EVENTID , WMI_TLV_BA_RSP_SSN_EVENTID,
drivers/net/wireless/ath/ath10k/wmi.c +23 -0
@@ -2383,6 +2383,29 @@ int ath10k_wmi_event_mgmt_tx_compl(struct ath10k *ar, struct sk_buff *skb)return 0 ; } +int ath10k_wmi_event_mgmt_tx_bundle_compl (struct ath10k *ar,struct sk_buff *skb) +{ +struct wmi_tlv_mgmt_tx_bundle_compl_ev_arg arg; +u32 num_reports; +int i, ret; + + ret =ath10k_wmi_pull_mgmt_tx_bundle_compl (ar, skb, &arg); +if (ret) { +ath10k_warn (ar,"failed to parse bundle mgmt compl event: %d\n" , ret); +return ret; + } + + num_reports =__le32_to_cpu (arg.num_reports); + +for (i =0 ; i < num_reports; i++) +wmi_process_mgmt_tx_comp (ar,__le32_to_cpu (arg.desc_ids[i]), +__le32_to_cpu (arg.status[i])); + +ath10k_dbg (ar,ATH10K_DBG_WMI ,"wmi tlv event bundle mgmt tx completion\n" ); + +return 0 ; +} +int ath10k_wmi_event_mgmt_rx (struct ath10k *ar,struct sk_buff *skb) {struct wmi_mgmt_rx_ev_arg arg = {};
drivers/net/wireless/ath/ath10k/wmi.h +7 -0
@@ -6688,6 +6688,12 @@ struct wmi_tlv_mgmt_tx_compl_ev_arg {__le32 pdev_id; }; +struct wmi_tlv_mgmt_tx_bundle_compl_ev_arg { +__le32 num_reports; +const __le32 *desc_ids; +const __le32 *status; +}; +struct wmi_mgmt_rx_ev_arg {__le32 channel;__le32 snr;
@@ -7244,6 +7250,7 @@ int ath10k_wmi_start_scan_verify(const struct wmi_start_scan_arg *arg);int ath10k_wmi_event_scan (struct ath10k *ar,struct sk_buff *skb);int ath10k_wmi_event_mgmt_rx (struct ath10k *ar,struct sk_buff *skb);int ath10k_wmi_event_mgmt_tx_compl (struct ath10k *ar,struct sk_buff *skb); +int ath10k_wmi_event_mgmt_tx_bundle_compl (struct ath10k *ar,struct sk_buff *skb);void ath10k_wmi_event_chan_info (struct ath10k *ar,struct sk_buff *skb);void ath10k_wmi_event_echo (struct ath10k *ar,struct sk_buff *skb);int ath10k_wmi_event_debug_mesg (struct ath10k *ar,struct sk_buff *skb);
Signature · 1 line
2.7.4
Re: [PATCH v2 1/2] ath10k: Handle bundled tx completion for management frames
Quoted 11 lines · Rakesh Pillai
WCN3990 supports sending tx completion for multiple management frames bundled together in a single event.
Add support to handle the bundled tx completion
event for WCN3990.Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1Signed-off-by Rakesh Pillai <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
cc123fac978f ath10k: Handle bundled tx completion for management frames 543271334483 ath10k: Enable bundle tx compl for management frames in WCN3990
Signature · 9 lines
https://patchwork.kernel.org/patch/10780541/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v2 1/2] ath10k: Handle bundled tx completion for management frames
In reply to Rakesh PillaiQuoted 11 lines · Rakesh Pillai
WCN3990 supports sending tx completion for multiple management frames bundled together in a single event.
Add support to handle the bundled tx completion
event for WCN3990.Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1Signed-off-by Rakesh Pillai <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
cc123fac978f ath10k: Handle bundled tx completion for management frames 543271334483 ath10k: Enable bundle tx compl for management frames in WCN3990
Signature · 3 lines
https://patchwork.kernel.org/patch/10780541/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH v2 2/2 ath10k: Enable bundle tx compl for management frames in WCN3990
In reply to Rakesh PillaiWCN3990 sends tx completion of multiple management frames bundled together in a single event, if the host driver exposes the support to handle this bundled tx completion event. This reduces the number of WMI events which are sent to the host driver by the target.
Set the BUNDLE_TX_COMPL flag in the host capability flags when host sends the wmi init command, to indicate the host capability to handle bundled tx completion for management frames.
Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
--- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 +- drivers/net/wireless/ath/ath10k/wmi-tlv.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/wmi-tlv.c +1 -1
@@ -1688,7 +1688,7 @@ static struct sk_buff *ath10k_wmi_tlv_op_gen_init(struct ath10k *ar) cfg->num_ocb_vdevs =__cpu_to_le32 (0 ); cfg->num_ocb_channels =__cpu_to_le32 (0 ); cfg->num_ocb_schedules =__cpu_to_le32 (0 ); - cfg->host_capab =__cpu_to_le32 (0 ); + cfg->host_capab =__cpu_to_le32 (WMI_TLV_FLAG_MGMT_BUNDLE_TX_COMPL );ath10k_wmi_put_host_mem_chunks (ar, chunks);
drivers/net/wireless/ath/ath10k/wmi-tlv.h +2 -0
@@ -1593,6 +1593,8 @@ struct chan_info_params {u32 mac_clk_mhz; }; +#define WMI_TLV_FLAG_MGMT_BUNDLE_TX_COMPL BIT(9) +struct wmi_tlv_mgmt_tx_compl_ev {__le32 desc_id;__le32 status;
Signature · 7 lines
2.7.4 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k