stat cleanup/bugfix patches
cover stat cleanup/bugfix patches
From: Vincent Fu <[email protected]>
Jens, please consider these two cleanup/bugfix patches for stat.c
Vincent
Vincent Fu (2):
stat: clean up calc_clat_percentiles
stat: put 'percentiles' object in appropriate 'clat_ns' or 'lat_ns'
parent
stat.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/2 stat: clean up calc_clat_percentiles
From: Vincent Fu <[email protected]>
We already know the size of the buffer needed. So there is no need to do anything fancy when allocating it.
--- stat.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
stat.c +4 -6
@@ -139,7 +139,6 @@ unsigned int calc_clat_percentiles(uint64_t *io_u_plat, unsigned long long nr, {unsigned long long sum =0 ;unsigned int len, i, j =0 ; -unsigned int oval_len =0 ;unsigned long long *ovals =NULL ;bool is_last;
@@ -161,6 +160,10 @@ unsigned int calc_clat_percentiles(uint64_t *io_u_plat, unsigned long long nr,if (len >1 )qsort ((void *)plist, len,sizeof (plist[0 ]), double_cmp); + ovals =malloc (len *sizeof (*ovals)); +if (!ovals) +return 0 ; +/* * Calculate bucket values, note down max and min values */
@@ -170,11 +173,6 @@ unsigned int calc_clat_percentiles(uint64_t *io_u_plat, unsigned long long nr,while (sum >= (plist[j].u.f /100.0 * nr)) {assert (plist[j].u.f <=100.0 ); -if (j == oval_len) { - oval_len +=100 ; - ovals =realloc (ovals, oval_len *sizeof (*ovals)); - } - ovals[j] =plat_idx_to_val (i);if (ovals[j] < *minv) *minv = ovals[j];
Signature · 1 line
2.17.1
PATCH 2/2 stat: put 'percentiles' object in appropriate 'clat_ns' or 'lat_ns' parent
In reply to [email protected]From: Vincent Fu <[email protected]>
In the JSON output, the 'percentiles' object currently always appears within the 'clat_ns' object. Put it inside the 'lat_ns' object when --lat_percentiles=1 is set.
--- stat.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
stat.c +4 -1
@@ -1088,7 +1088,8 @@ static void add_ddir_status_json(struct thread_stat *ts, len =0 ; percentile_object =json_create_object (); -json_object_add_value_object (tmp_object,"percentile" , percentile_object); +if (ts->clat_percentiles) +json_object_add_value_object (tmp_object,"percentile" , percentile_object);for (i =0 ; i < len; i++) {snprintf (buf,sizeof (buf),"%f" , ts->percentile_list[i].u.f);json_object_add_value_int (percentile_object, (const char *)buf, ovals[i]);
@@ -1127,6 +1128,8 @@ static void add_ddir_status_json(struct thread_stat *ts,json_object_add_value_int (tmp_object,"max" , max);json_object_add_value_float (tmp_object,"mean" , mean);json_object_add_value_float (tmp_object,"stddev" , dev); +if (ts->lat_percentiles) +json_object_add_value_object (tmp_object,"percentile" , percentile_object);if (output_format &FIO_OUTPUT_JSON_PLUS && ts->lat_percentiles)json_object_add_value_object (tmp_object,"bins" , clat_bins_object);
Signature · 1 line
2.17.1
Quoted 6 lines · On 2/7/19 8:51 AM, [email protected] wrote:
From: Vincent Fu <[email protected]>
Jens, please consider these two cleanup/bugfix patches for
stat.cVincent
Quoted 7 lines
Vincent Fu (2):
stat: clean upcalc_clat_percentiles
stat: put 'percentiles' object in appropriate 'clat_ns' or 'lat_ns'
parentstat.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
Looks good, applied both. Thanks Vincent.
Signature · 1 line
Jens Axboe