Skip to contentSkip to conversation

tools/bpf: add missing strings.h include

PATCH Applied Andrii Nakryiko 2 participants 2 messages Feb 7, 2019 – Feb 8, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tools/bpf: add missing strings.h include

Few files in libbpf are using bzero() function (defined in strings.h header), but don't include corresponding header. When libbpf is added as a dependency to pahole, this undeterministically causes warnings on some machines:

bpf.c:225:2: warning: implicit declaration of function ‘bzero’ [-Wimplicit-function-declaration]

  bzero(&attr, sizeof(attr));
    ^~~~~
---
 tools/lib/bpf/bpf.c    | 1 +
 tools/lib/bpf/btf.c    | 1 +
 tools/lib/bpf/libbpf.c | 1 +
 3 files changed, 3 insertions(+)
tools/lib/bpf/bpf.c +1 -0
index 3defad77dc7a..92fd27fe0599 100644
@@ -22,6 +22,7 @@
  */
 
 #include <stdlib.h>
+#include <strings.h>
 #include <memory.h>
 #include <unistd.h>
 #include <asm/unistd.h>
tools/lib/bpf/btf.c +1 -0
index ab6528c935a1..4324eb47d214 100644
@@ -4,6 +4,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <strings.h>
 #include <unistd.h>
 #include <errno.h>
 #include <linux/err.h>
tools/lib/bpf/libbpf.c +1 -0
index 47969aa0faf8..8d64ada5f728 100644
@@ -18,6 +18,7 @@
 #include <libgen.h>
 #include <inttypes.h>
 #include <string.h>
+#include <strings.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <errno.h>
Signature · 1 line
2.17.1
#1 lore raw
Quoted 10 lines · Andrii Nakryiko

Few files in libbpf are using bzero() function (defined in strings.h header), but don't include corresponding header. When libbpf is added as a dependency to pahole, this undeterministically causes warnings on some machines:

bpf.c:225:2: warning: implicit declaration of function ‘bzero’ [-Wimplicit-function-declaration]

  bzero(&attr, sizeof(attr));
    ^~~~~

Applied, Thanks