Skip to contentSkip to conversation

fs/nsfs.c: include linux/proc_fs.h for open_related_ns()

PATCH RESEND In review Eric Biggers 1 participant 2 messages Jan 10, 2019 – Feb 7, 2019 VFS

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 fs/nsfs.c: include linux/proc_fs.h for open_related_ns()

From: Eric Biggers <[email protected]>

open_related_ns() is defined in fs/nsfs.c and declared in linux/proc_fs.h, but the declaration isn't included at the point of the definition. Include the header to enforce that the definition matches the declaration.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

---
 fs/nsfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/nsfs.c +1 -0
index 60702d677bd4e..a7ff518400a10 100644
@@ -2,6 +2,7 @@
 #include <linux/mount.h>
 #include <linux/file.h>
 #include <linux/fs.h>
+#include <linux/proc_fs.h>
 #include <linux/proc_ns.h>
 #include <linux/magic.h>
 #include <linux/ktime.h>
Signature · 1 line
2.20.1.97.g81188d93c3-goog
#1 lore raw
Quoted 29 lines · Eric Biggers

From: Eric Biggers <[email protected]>

open_related_ns() is defined in fs/nsfs.c and declared in linux/proc_fs.h, but the declaration isn't included at the point of the definition. Include the header to enforce that the definition matches the declaration.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

---
 fs/nsfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/nsfs.c +1 -0
index 60702d677bd4e..a7ff518400a10 100644
@@ -2,6 +2,7 @@
 #include <linux/mount.h>
 #include <linux/file.h>
 #include <linux/fs.h>
+#include <linux/proc_fs.h>
 #include <linux/proc_ns.h>
 #include <linux/magic.h>
 #include <linux/ktime.h>
Signature · 1 line
2.20.1.97.g81188d93c3-goog

Ping. Al, are you planning to apply this?

- Eric