Skip to contentSkip to conversation

xhci: Drop superfluous initialization in xhci_queue_ctrl_tx()

PATCH New Andrey Smirnov 1 participant 1 message Feb 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xhci: Drop superfluous initialization in xhci_queue_ctrl_tx()

Simplify field's initialization by directly assigning its final value instead of initializing the variable to sero and then bitwise or-ing it.

---

Changes since [v1]:

- Fixed a typo in commit message

[v1] https://lore.kernel.org/lkml/[email protected]

 drivers/usb/host/xhci-ring.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/host/xhci-ring.c +1 -2
index 40fa25c4d041..91e592bfb80d 100644
@@ -3379,8 +3379,7 @@ int xhci_queue_ctrl_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
 	/* Queue setup TRB - see section 6.4.1.2.1 */
 	/* FIXME better way to translate setup_packet into two u32 fields? */
 	setup = (struct usb_ctrlrequest *) urb->setup_packet;
-	field = 0;
-	field |= TRB_IDT | TRB_TYPE(TRB_SETUP);
+	field = TRB_IDT | TRB_TYPE(TRB_SETUP);
 	if (start_cycle == 0)
 		field |= 0x1;