drm/virtio: do NOT reuse resource ids
Subsystems (3)
Gerd Hoffmann
maintainerPATCH 1/1 drm/virtio: do NOT reuse resource ids
Bisected guest kernel changes crashing qemu. Landed at "6c1cd97bda drm/virtio: fix resource id handling". Looked again, and noticed we where not only leaking *some* ids, but *all* ids. The old code never ever called virtio_gpu_resource_id_put().
So, commit 6c1cd97bda effectively makes the linux kernel starting re-using IDs after releasing them, and apparently virglrenderer can't deal with that. Oops.
This patch puts a temporary stopgap into place for the 5.0 release.
Cc David Airlie <[email protected]>
Signed-off-by Gerd Hoffmann <[email protected]>
---
Notes:
Hi Dave, I'll be offline next week, so please commit to drm-next-fixes if you think this patch is acceptable.
drivers/gpu/drm/virtio/virtgpu_object.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
drivers/gpu/drm/virtio/virtgpu_object.c +13 -0
@@ -28,10 +28,21 @@static int virtio_gpu_resource_id_get (struct virtio_gpu_device *vgdev,uint32_t *resid) { +#if 0 int handle =ida_alloc (&vgdev->resource_ida,GFP_KERNEL );if (handle <0 )return handle; +#else +static int handle; + +/* +* FIXME: dirty hack to avoid re-using IDs, virglrenderer +* can't deal with that. Needs fixing in virglrenderer, also +* should figure a better way to handle that in the guest. +*/ + handle++; +#endif *resid = handle +1 ;return 0 ;
@@ -39,7 +50,9 @@ static int virtio_gpu_resource_id_get(struct virtio_gpu_device *vgdev,static void virtio_gpu_resource_id_put (struct virtio_gpu_device *vgdev,uint32_t id) { +#if 0 ida_free (&vgdev->resource_ida, id -1 ); +#endif }static void virtio_gpu_ttm_bo_destroy (struct ttm_buffer_object *tbo)
Signature · 6 lines
2.9.3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel