mtd: lpddr_cmds: Mark expected switch fall-through
PATCH 1/1 mtd: lpddr_cmds: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’:drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (mode == FL_READY && chip->oldstate == FL_READY)
^
drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
--- drivers/mtd/lpddr/lpddr_cmds.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/lpddr/lpddr_cmds.c +1 -0
@@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip *chip, int mode)/* Only if there's no operation suspended... */ if (mode ==FL_READY && chip->oldstate ==FL_READY )return 0 ; +/* fall through */ default : sleep:
Signature · 1 line
2.20.1
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
Quoted 29 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’:drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (mode ==FL_READY&&chip->oldstate==FL_READY)^
drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here
default:
^~~~~~~Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/mtd/lpddr/lpddr_cmds.c | 1 + 1 file changed, 1 insertion(+)drivers/mtd/lpddr/lpddr_cmds.c +0
-0
drivers/mtd/lpddr/lpddr_cmds.c static int chip_ready(struct map_info *map, struct flchip *chip, int mode) · line 324
Quoted 7 lines
drivers/mtd/lpddr/lpddr_cmds.c +1
-0@@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip *chip, int mode)/* Only if there's no operation suspended... */ if (mode ==FL_READY && chip->oldstate ==FL_READY )return 0 ; +/* fall through */ default : sleep:
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi all,
If no one cares I'll add this to my tree for 5.2.
Thanks
--
Gustavo
Quoted 47 lines · Gustavo A. R. Silva
Hi all,
Friendly ping:
Who can take this?
Thanks
--
GustavoQuoted 36 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’:drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (mode ==FL_READY&&chip->oldstate==FL_READY)^
drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here
default:
^~~~~~~Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/mtd/lpddr/lpddr_cmds.c | 1 + 1 file changed, 1 insertion(+)drivers/mtd/lpddr/lpddr_cmds.c +1
-0@@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip *chip, int mode)/* Only if there's no operation suspended... */ if (mode ==FL_READY && chip->oldstate ==FL_READY )return 0 ; +/* fall through */ default : sleep:
Quoted 14 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’:drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (mode ==FL_READY&&chip->oldstate==FL_READY)^
drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here
default:
^~~~~~~
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
-Kees
Quoted 19 lines
--- drivers/mtd/lpddr/lpddr_cmds.c | 1 + 1 file changed, 1 insertion(+)drivers/mtd/lpddr/lpddr_cmds.c +1
-1@@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip *chip, int mode)/* Only if there's no operation suspended... */ if (mode ==FL_READY && chip->oldstate ==FL_READY )return 0 ; +/* fall through */ default : sleep: --2.20.1
Signature · 1 line
Kees Cook