can: mcp251x: mark expected switch fall-through

PATCH New Gustavo A. R. Silva 1 participant 1 message Feb 8, 2019

Subsystems (3)

Networking Network drivers CAN network drivers

lore

Share & tools

lore

Gustavo A. R. Silva

author

2019-02-08 19:02 UTC #0 lore raw

PATCH 1/1 can: mcp251x: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, the /* fall through */ comment is placed at the bottom of the case statement, which is what GCC is expecting to find.

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/net/can/spi/mcp251x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/net/can/spi/mcp251x.c +2 -1

index e90817608645..17257c73c302 100644
@@ -875,7 +875,8 @@ static irqreturn_t mcp251x_can_ist(int irq, void *dev_id)
 			if (new_state >= CAN_STATE_ERROR_WARNING &&
 			    new_state <= CAN_STATE_BUS_OFF)
 				priv->can.can_stats.error_warning++;
-		case CAN_STATE_ERROR_WARNING:	/* fallthrough */
+			/* fall through */
+		case CAN_STATE_ERROR_WARNING:
 			if (new_state >= CAN_STATE_ERROR_PASSIVE &&
 			    new_state <= CAN_STATE_BUS_OFF)
 				priv->can.can_stats.error_passive++;

Signature · 1 line

2.20.1