xen-netback: mark expected switch fall-through
Subsystems (3)
PATCH 1/1 xen-netback: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
--- drivers/net/xen-netback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/xen-netback/xenbus.c +1 -1
@@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev,set_backend_state (be, XenbusStateClosed);if (xenbus_dev_is_online (dev))break ; -/* fall through if not online */ +/* fall through - if not online */ case XenbusStateUnknown:set_backend_state (be, XenbusStateClosed);device_unregister (&dev->dev);
Signature · 1 line
2.20.1
From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 8 Feb 2019 13:58:38 -0600
Quoted 9 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.
Quoted 6 lines · David Miller
From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 8 Feb 2019 13:58:38 -0600Quoted 3 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Quoted 9 lines
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied.
Thanks, Dave.
--
Gustavo
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 6 lines · David Miller
From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 8 Feb 2019 13:58:38 -0600Quoted 3 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Quoted 9 lines
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied.
Thanks, Dave.
--
Gustavo
From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 8 Feb 2019 13:58:38 -0600
Quoted 9 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 20 lines
Quoted 1 line
Quoted 1 line · On 08.02.19 at 20:58, <[email protected]> wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/xen-netback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/xen-netback/xenbus.c +0
-0
drivers/net/xen-netback/xenbus.c static void frontend_changed(struct xenbus_device *dev, · line 659
Quoted 6 lines
drivers/net/xen-netback/xenbus.c +1
-1@@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev,set_backend_state (be, XenbusStateClosed);if (xenbus_dev_is_online (dev))break ; -/* fall through if not online */ +/* fall through - if not online */ case XenbusStateUnknown:
Considering the fall-through was already annotated, I don't think title and description really justify the change. Is the compiler after a particular wording here?
Jan
Quoted 20 lines
Quoted 1 line
Quoted 1 line · On 08.02.19 at 20:58, <[email protected]> wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/xen-netback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/xen-netback/xenbus.c +0
-0
drivers/net/xen-netback/xenbus.c static void frontend_changed(struct xenbus_device *dev, · line 659
Quoted 6 lines
drivers/net/xen-netback/xenbus.c +1
-1@@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev,set_backend_state (be, XenbusStateClosed);if (xenbus_dev_is_online (dev))break ; -/* fall through if not online */ +/* fall through - if not online */ case XenbusStateUnknown:
Considering the fall-through was already annotated, I don't think title and description really justify the change. Is the compiler after a particular wording here?
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel