Skip to contentSkip to conversation

package/opentracing-cpp: needs dynamic library support

PATCH New Thomas De Schampheleire 2 participants 2 messages Feb 8, 2019 – Feb 11, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/opentracing-cpp: needs dynamic library support

From: Thomas De Schampheleire <[email protected]>

opentracing-cpp requires dlfcn.h from src/dynamic_load_unix.cpp. This file is compiled unconditionally.

Disable opentracing-cpp on BR2_STATIC_LIBS configurations.

---
 package/opentracing-cpp/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/opentracing-cpp/Config.in +4 -2
index ebcce35aa8..ff3067b7d1 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_OPENTRACING_CPP
 	bool "opentracing-cpp"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
 	help
@@ -9,8 +10,9 @@ config BR2_PACKAGE_OPENTRACING_CPP
 
 	  http://opentracing.io
 
-comment "opentracing-cpp needs a toolchain w/ C++, threads, gcc >= 4.8"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+comment "opentracing-cpp needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.8"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
+		|| BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 
 comment "opentracing-cpp needs exception_ptr"
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 package/opentracing-cpp: needs dynamic library support

Quoted 5 lines · On Fri, 8 Feb 2019 21:50:41 +0100 Thomas De Schampheleire…

From: Thomas De Schampheleire <[email protected]>

opentracing-cpp requires dlfcn.h from src/dynamic_load_unix.cpp. This file is compiled unconditionally.

Quoted 8 lines

Disable opentracing-cpp on BR2_STATIC_LIBS configurations.

---
 package/opentracing-cpp/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com