package/sg3_utils: ensure to build against librt when needed
PATCH 1/1 package/sg3_utils: ensure to build against librt when needed
The sg3_utils has provisions to build against librt when needed, but forgot to use that mechanism for the sg_turs program. This commit fixes that. The patch has been submitted upstream to the sg3_utils author.
Fixes:
http://autobuild.buildroot.net/results/67b890a41d05497820ea4f44e187257dd6818b0b/
--- ...le.am-add-missing-RT_LIB-for-sg_turs.patch | 29 +++++++++++++++++++ package/sg3_utils/sg3_utils.mk | 2 +- 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 package/sg3_utils/0002-src-Makefile.am-add-missing-RT_LIB-for-sg_turs.patch
package/sg3_utils/0002-src-Makefile.am-add-missing-RT_LIB-for-sg_turs.patch new file +29 -0
@@ -0,0 +1,29 @@ +From 68b0591cf37760e09e358533bbcecf36eddfceed Mon Sep 17 00:00:00 2001 +From: Thomas Petazzoni <[email protected]> +Date: Sun, 10 Feb 2019 14:46:41 +0100 +Subject: [PATCH] src/Makefile.am: add missing @RT_LIB@ for sg_turs + +The sg_turs program uses clock_gettime(), so it should link against +librt, as provided by @RT_LIB at . + +Signed-off-by: Thomas Petazzoni <[email protected]> +--- + src/Makefile.am | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/Makefile.am b/src/Makefile.am +index 881cf29..0eba680 100644 +--- a/src/Makefile.am ++++ b/src/Makefile.am +@@ -170,7 +170,7 @@ sg_test_rwbuf_LDADD = ../lib/libsgutils2.la + + sg_timestamp_LDADD = ../lib/libsgutils2.la + +-sg_turs_LDADD = ../lib/libsgutils2.la ++sg_turs_LDADD = ../lib/libsgutils2.la @RT_LIB@ + + sg_unmap_LDADD = ../lib/libsgutils2.la + +-- +2.20.1 +
package/sg3_utils/sg3_utils.mk +1 -1
@@ -14,7 +14,7 @@ SG3_UTILS_LICENSE := $(SG3_UTILS_LICENSE), GPL-2.0+ (programs), BSD-3-Clause (pr endif SG3_UTILS_LICENSE_FILES = COPYING BSD_LICENSE -# Patching configure.ac +# Patching configure.ac/Makefile.am SG3_UTILS_AUTORECONF = YES # install the libsgutils2 library
Signature · 1 line
2.20.1
PATCH 1/1 package/sg3_utils: ensure to build against librt when needed
Thomas,
Quoted 11 lines · Thomas Petazzoni
The
sg3_utilshas provisions to build against librt when needed, but forgot to use that mechanism for thesg_tursprogram. This commit fixes that. The patch has been submitted upstream to thesg3_utilsauthor.Fixes:
http://autobuild.buildroot.net/results/67b890a41d05497820ea4f44e187257dd6818b0b/
Signed-off-by Thomas Petazzoni <[email protected]>
Tested the working case on my build machine wasn't broken with this update. (don't have test bed to reproduce failure case)
Quoted 61 lines
--- ...le.am-add-missing-RT_LIB-for-sg_turs.patch | 29 +++++++++++++++++++ package/sg3_utils/sg3_utils.mk | 2 +- 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 package/sg3_utils/0002-src-Makefile.am-add-missing-RT_LIB-for-sg_turs.patchpackage/sg3_utils/0002-src-Makefile.am-add-missing-RT_LIB-for-sg_turs.patch new file +29
-0@@ -0,0 +1,29 @@ +From 68b0591cf37760e09e358533bbcecf36eddfceed Mon Sep 17 00:00:00 2001 +From: Thomas Petazzoni <[email protected]> +Date: Sun, 10 Feb 2019 14:46:41 +0100 +Subject: [PATCH] src/Makefile.am: add missing @RT_LIB@ for sg_turs + +The sg_turs program uses clock_gettime(), so it should link against +librt, as provided by @RT_LIB at . + +Signed-off-by: Thomas Petazzoni <[email protected]> +--- + src/Makefile.am | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/Makefile.am b/src/Makefile.am +index 881cf29..0eba680 100644 +--- a/src/Makefile.am ++++ b/src/Makefile.am +@@ -170,7 +170,7 @@ sg_test_rwbuf_LDADD = ../lib/libsgutils2.la + + sg_timestamp_LDADD = ../lib/libsgutils2.la + +-sg_turs_LDADD = ../lib/libsgutils2.la ++sg_turs_LDADD = ../lib/libsgutils2.la @RT_LIB@ + + sg_unmap_LDADD = ../lib/libsgutils2.la + +-- +2.20.1 +package/sg3_utils/sg3_utils.mk +1
-2@@ -14,7 +14,7 @@ SG3_UTILS_LICENSE := $(SG3_UTILS_LICENSE), GPL-2.0+ (programs), BSD-3-Clause (pr endif SG3_UTILS_LICENSE_FILES = COPYING BSD_LICENSE -# Patching configure.ac +# Patching configure.ac/Makefile.am SG3_UTILS_AUTORECONF = YES # install the libsgutils2 library --2.20.1
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 23 lines
Matthew Weber | Pr. Software Engineer | Commercial Avionics COLLINS AEROSPACE 400 Collins Road NE, Cedar Rapids, Iowa 52498, USA Tel: +1 319 295 7349 | FAX: +1 319 263 6099 matthew.weber at collins.com | collinsaerospace.com CONFIDENTIALITY WARNING: This message may contain proprietary and/or privileged information of Collins Aerospace and its affiliated companies. If you are not the intended recipient, please 1) Do not disclose, copy, distribute or use this message or its contents. 2) Advise the sender by return email. 3) Delete all copies (including all attachments) from your computer. Your cooperation is greatly appreciated. Any export restricted material should be shared using my matthew.weber at corp.rockwellcollins.com address.
Thomas Petazzoni
AppliedPATCH 1/1 package/sg3_utils: ensure to build against librt when needed
In reply to Thomas PetazzoniHello,
Quoted 7 lines · On Sun, 10 Feb 2019 14:51:30 +0100 Thomas Petazzoni…
The
sg3_utilshas provisions to build against librt when needed, but forgot to use that mechanism for thesg_tursprogram. This commit fixes that. The patch has been submitted upstream to thesg3_utilsauthor.Fixes:
Quoted 8 lines
http://autobuild.buildroot.net/results/67b890a41d05497820ea4f44e187257dd6818b0b/
Signed-off-by Thomas Petazzoni <[email protected]>--- ...le.am-add-missing-RT_LIB-for-sg_turs.patch | 29 +++++++++++++++++++ package/sg3_utils/sg3_utils.mk | 2 +- 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 package/sg3_utils/0002-src-Makefile.am-add-missing-RT_LIB-for-sg_turs.patch
Applied to master, thanks. FYI, the patch has been applied by the upstream maintainer.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/sg3_utils: ensure to build against librt when needed
In reply to Thomas PetazzoniQuoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
The
sg3_utilshas provisions to build against librt when needed, but forgot to use that mechanism for thesg_tursprogram. This commit fixes that. The patch has been submitted upstream to thesg3_utilsauthor.
Quoted 5 lines
Fixes:
http://autobuild.buildroot.net/results/67b890a41d05497820ea4f44e187257dd6818b0b/
Signed-off-by Thomas Petazzoni <[email protected]>
Committed to 2018.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard