pc-dimm: use same mechanism for [get|set]_addr
PATCH v2 1/1 pc-dimm: use same mechanism for [get|set]_addr
[get|set]_addr are two counterpart to access PCDIMMDevice.addr.
Since we have already set up a property PC_DIMM_ADDR_PROP for this field and use this mechanism in set_addr, it would be more proper to use the same mechanism in get_addr.
This patch uses object_property_get_uint() to replace the direct memory access to make [get|set]_addr with the same mechanism.
---
v2: replace NULL with error_abort to handle error properly
--- hw/mem/pc-dimm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
hw/mem/pc-dimm.c +1 -3
@@ -204,9 +204,7 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp)static uint64_t pc_dimm_md_get_addr (const MemoryDeviceState *md) { -const PCDIMMDevice *dimm =PC_DIMM (md); - -return dimm->addr; +return object_property_get_uint (OBJECT (md),PC_DIMM_ADDR_PROP , &error_abort); } static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr,
Signature · 1 line
2.19.1
Quoted 10 lines · On Mon, 11 Feb 2019 14:46:29 +0800 Wei Yang <[email protected]>…
[get|set]_addr are two counterpart to access PCDIMMDevice.addr.
Since we have already set up a property
PC_DIMM_ADDR_PROPfor this field and use this mechanism inset_addr, it would be more proper to use the same mechanism inget_addr.This patch uses
object_property_get_uint()to replace the direct memory access to make [get|set]_addr with the same mechanism.Signed-off-by Wei Yang <[email protected]>
Quoted 22 lines
---
v2: replace NULL witherror_abortto handle error properly--- hw/mem/pc-dimm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)hw/mem/pc-dimm.c +1
-3@@ -204,9 +204,7 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp)static uint64_t pc_dimm_md_get_addr (const MemoryDeviceState *md) { -const PCDIMMDevice *dimm =PC_DIMM (md); - -return dimm->addr; +return object_property_get_uint (OBJECT (md),PC_DIMM_ADDR_PROP , &error_abort); } static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr,
Quoted 9 lines · Igor Mammedov
Quoted 6 lines · On Mon, 11 Feb 2019 14:46:29 +0800 Wei Yang <[email protected]>…
[get|set]_addr are two counterpart to access PCDIMMDevice.addr.
Since we have already set up a property
PC_DIMM_ADDR_PROPfor this field and use this mechanism inset_addr, it would be more proper to use the same mechanism inget_addr.
Quoted 7 lines
Quoted 4 lines
This patch uses
object_property_get_uint()to replace the direct memory access to make [get|set]_addr with the same mechanism.Signed-off-by Wei Yang <[email protected]>Reviewed-by Igor Mammedov <[email protected]>
Thanks :-)
Quoted 22 lines
Quoted 22 lines
---
v2: replace NULL witherror_abortto handle error properly--- hw/mem/pc-dimm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)hw/mem/pc-dimm.c +1
-3@@ -204,9 +204,7 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp)static uint64_t pc_dimm_md_get_addr (const MemoryDeviceState *md) { -const PCDIMMDevice *dimm =PC_DIMM (md); - -return dimm->addr; +return object_property_get_uint (OBJECT (md),PC_DIMM_ADDR_PROP , &error_abort); } static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr,
Signature · 2 lines
Wei Yang Help you, Help me